Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d0a478d4-0d82-3760-1b54-632d40d43e62@intel.com>
Date:   Fri, 28 Jul 2023 17:05:24 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [patch v2 28/38] x86/cpu: Provide an AMD/HYGON specific topology
 parser
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     <x86@kernel.org>, Tom Lendacky <thomas.lendacky@amd.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        James Smart <james.smart@broadcom.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        <linux-scsi@vger.kernel.org>, Guenter Roeck <linux@roeck-us.net>,
        <linux-hwmon@vger.kernel.org>, "Jean Delvare" <jdelvare@suse.com>,
        Huang Rui <ray.huang@amd.com>, Juergen Gross <jgross@suse.com>,
        Steve Wahl <steve.wahl@hpe.com>,
        Mike Travis <mike.travis@hpe.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        "Russ Anderson" <russ.anderson@hpe.com>
References: <20230728105650.565799744@linutronix.de>
 <20230728120931.226185847@linutronix.de>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20230728120931.226185847@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1ozQzUxb2hrL0F5WXRFWWxBbmFoRVV5MEE4VzIwa05iRFBYU2Z0Z1N1bHhq?=
 =?utf-8?B?NXVVbkZ1N21wKzF4VW5ydEl5Y25XSkFUZ0toMzJBa3YybmRtdGpFQ2I1R1A4?=
 =?utf-8?B?K1JXdnU3WWl6K281M3ZZQkV0amJxQmJZeHQzcDFXNGxLZFhhZWhSRFJwMzJi?=
 =?utf-8?B?U3hJaFp2YUc3M0JmL1IzN0JuakpURWphT241SFZtbnR4L25iOHUzNzgreVdq?=
 =?utf-8?B?ODg2WWF0YlZLQ0dib0tkMU1zd2hEOS9sTnhHKytPUWcrb2cwcXRhWG1QbzRt?=
 =?utf-8?B?bVhlbktQRENvTXJPanNjRnRhSU40aHorOVF3eFE5WmJIMitQRXVRMVFoa28y?=
 =?utf-8?B?enRXZzN4RU5BSXIyNmwwMVF4ZnN3RW40K3k2TklMbmZQd0xvUEhvQ2tLSGVo?=
 =?utf-8?B?OHFoZ20vdTJDRkxRZzhLSnQ3NmFYclcxYmJnMU1WdHlKSGdmK0hGTW9MbjA2?=
 =?utf-8?B?TC9IZUdXSjZ0QlNRWm9MZGNqeXpvL3Jrd3FjbGExM2ZpUHhiY2w2UEhad0Zp?=
 =?utf-8?B?UVBKN2lMeEY4MExrREdnc3N4aUY2UERlR1ZpK2E2UW1tZlUzWDBMbEVyTk80?=
 =?utf-8?B?L0RubzZvWmM2QTMzRG84bTFMeDUybEN0dDV3OS9IQ3FKZU5EMGlIQWFRT05J?=
 =?utf-8?B?eVhITnVYUmxDNGlqbkR4L0sxaUJXY2FnRDlSSUE1VFBGZmxOeHM5M1pYUW1Z?=
 =?utf-8?B?V2hkTC9Ld1pmZXdsUklyYWNCVURONVUwclNMbHZqZUJPaEJUUXVUQ0ZjNyts?=
 =?utf-8?B?K2M4TVF0MUxxWUxLaGdaVTJTVXNIN2FlKzI2YXNGR1JBMmZSWlZ4S0ROWDlF?=
 =?utf-8?B?MnBuOE5INmRPaE5hMW44Y2M4UTVoZmJzeEdaZk83TkpjWTl4dDVDTm5ZdGdl?=
 =?utf-8?B?QjM4anJVOEZjaGUrTDE1MnpvQ2ViV0lHY0NUeVRqeXdyRWdoOVhYQ0kvajBP?=
 =?utf-8?B?bGpibVVSMjF2cG9HTzNhSDFtOGtLTWN2TjExa25uS21KVm1pR3RWWHBpalFv?=
 =?utf-8?B?NHhwWVhYZ0JVeWdBUHVtTVNkclN3aG11blJrNjVSbGg0YkYwVWJSdWFCdHNO?=
 =?utf-8?B?OTVodk0vdGZ2ZjdNWWNQTDN3ZjVFbU9KWElPUDBIdmFsVVZCUHpNTWxkSVRO?=
 =?utf-8?B?NTlSRUcyd1dhcldUUjg4Umg5T0VmZ05XeExaTGRCUW5HT1doR1RxYnh4a2FW?=
 =?utf-8?B?U0FVOWxuL1JZS0RwT3FLWTJ6c0YxZ2ptWHlQRm16ajBhRXpCSmNsQmF3eDhl?=
 =?utf-8?B?U0FxbU9MR1NVcGR0TVl6ZDdtbjNyZXBZamNwMTd6YWdJQ2lOQ1hnTjlKR2tt?=
 =?utf-8?B?ZWRsOXcwa2NuZHg3UXFpcHE0N0ZWczl3MUtUU2hKUUhPaXB2N2p4aDgrOEN3?=
 =?utf-8?B?SE9IRGlTby9ZSUF2blY1K2diQVJzeDZ2dFZnTkJsRlBKZHVISm9xa21YUWhL?=
 =?utf-8?B?TGVuaExDNnZSRXlmSHRCOUh4akZoOUIvWWlEdEVhZXRsMTVYYnJaanpDS0ZX?=
 =?utf-8?B?bDVaU3hWd1FaRGJWZlV6MUJ0N2cybzR4WEU2UnZWc2cxZllyek9QekFwWXh5?=
 =?utf-8?B?Nkg3R3QvM0haT053UDVwZzFoN016TmZMcEkvU3dibTZDdWFJNjVYbU5zdkRj?=
 =?utf-8?B?WG5QZ0dvU2pMMHZZc3hreFVMUlJkMlo0anRramNBUlkxUW5nRXBSS2NLUFox?=
 =?utf-8?B?NURSeXN6dTVmYnlyaS9iYWd6ZmRDQnVwaFRkNFNjUGozak55enlrbTF2TDg5?=
 =?utf-8?B?c3R2eXlIc2ZTeUd2U0doMy9neXFMSlVUZm54OThIRmUzZm1ZdkdHdkJGc2k1?=
 =?utf-8?B?emNsbFFGOGRTbzhXT1dQYUl1MFZ3QzNvbUtiNXE0Rndka1pRYzFwSnJsTEl3?=
 =?utf-8?B?Mm04NTd1dWYyOHQyeDMwd2wxTVhtK0VSTTdlVjJqUjYvV0pldE9IVW9aalR4?=
 =?utf-8?B?OGt0ZjRaOVJJT3ZvaFVsQ3JQRUdpaEJ1VFNsT05QcnNrYnFEZkRIc1poQzUr?=
 =?utf-8?B?amc3Tjc5czdXT1Z1Q2lOU0pmaWZkbnREQkpuZm5UVTBLaCtic3c2MDZXcnNG?=
 =?utf-8?B?c3I3N3BrbnFQekQxTVc3VGNUU3plcHpsZnIxV3diaUVIeldHZkRucmc4OTgw?=
 =?utf-8?Q?uwLzA2YbkRktoOta20fmtk0+J?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c92b0c99-2a14-490a-a9fc-08db8fc78350
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2023 00:05:26.9165
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fH8yCQPB3BBCRrSdBpcleiS3HlIyFkkVAYE+GYBW+8HPu8emYbTCP6DHwwWXsQ6pO1j9FpsKXnG3crRHy9B1Hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5503
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/28/2023 5:13 AM, Thomas Gleixner wrote:
> AMD/HYGON uses various methods for topology evaluation:
> 
>   - Leaf 0x80000008 and 0x8000001e based with an optional leaf 0xb,
>     which is the preferred variant for modern CPUs.
> 
>     Leaf 0xb will be superseeded by leaf 0x80000026 soon, which is just

s/superseeded/superseded


> +
> +	if (tscan->c->x86_vendor == X86_VENDOR_AMD) {
> +		if (tscan->c->x86 == 0x15)
> +			tscan->c->topo.cu_id = leaf.cuid;
> +
> +		cacheinfo_amd_init_llc_id(tscan->c, leaf.nodeid);
> +	} else {
> +		/*
> +		 * Pacakge ID is ApicId[6..] on Hygon CPUs. See commit

s/Pacakge/Package