Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <633489d5-f521-91a6-0448-208eb25ff63f@intel.com>
Date:   Fri, 28 Jul 2023 17:02:30 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [patch v2 21/38] x86/cpu: Provide cpu_init/parse_topology()
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     <x86@kernel.org>, Tom Lendacky <thomas.lendacky@amd.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        James Smart <james.smart@broadcom.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        <linux-scsi@vger.kernel.org>, Guenter Roeck <linux@roeck-us.net>,
        <linux-hwmon@vger.kernel.org>, "Jean Delvare" <jdelvare@suse.com>,
        Huang Rui <ray.huang@amd.com>, Juergen Gross <jgross@suse.com>,
        Steve Wahl <steve.wahl@hpe.com>,
        Mike Travis <mike.travis@hpe.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        "Russ Anderson" <russ.anderson@hpe.com>
References: <20230728105650.565799744@linutronix.de>
 <20230728120930.839913695@linutronix.de>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20230728120930.839913695@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTVCRkRFV1RhWDIvU2NxNkxCaGxKeS9GY2xlOE5RMzdSQnhUbG9KZ3NLV0dT?=
 =?utf-8?B?OGwwS1drOHk2elF4cThtdG50ZkFBaFUwUUczdzVYdHo2ZDRCQzZBczd4U2lD?=
 =?utf-8?B?U0JsT003RmxYRk1vQVBNcndCL0dJMDRzek05S2FtVEhCc3c4dDRGNEdiclFh?=
 =?utf-8?B?bFJRS0g3cmZWb1FHWjc3WHJhODVnK3A2ek4rZ0xyTkYrc3orazNFMEd5eXhV?=
 =?utf-8?B?ekJoQlcyVlkvL1hOWTZZemQxdDRPWEZaZmNuVlpYNHJuaXd4T1BuYXk1czc5?=
 =?utf-8?B?c2dGZzFlUUhWaEpSUWo1eS8vNzRwRFZkTmV5eWJ4RWpRcmh2SlQzVi9OL0ph?=
 =?utf-8?B?MkpmUFBnazR4LzVsMThva01PbS9wdmVwb0xvUC84MUEyTUkwRkpFK1JyT2dX?=
 =?utf-8?B?V2J5TDdFSFRzenI0UUxaa3BoUTVlUUZ1RTVQSU0wNHJQMEVVSlZ4SDBwaEdq?=
 =?utf-8?B?dzBRdWNlbVpYSnFWT3ptNUdLaFdUUk9OSzMzWTNuZmZveFF2SGhhRWErZ0V6?=
 =?utf-8?B?UjBiTkZ4R1R2QjUrcERPeGhrUHNRcGNxWUpieFJEaVh0dlg1Y2JrbUd1MG84?=
 =?utf-8?B?NG9oS05RdEQ0UngvQS90YTE4SEZyR2lNR01WV01ZV2Q3U1lRTGxOMFNKeVRp?=
 =?utf-8?B?UUNHalBJMU1zbWx2cUNpZVNINXM3R2pHblFtK3hYdjA2NmlvRzZ3cmVTUjlT?=
 =?utf-8?B?SVA5bjducVVlUG1ReGdhaklxOERYR0swUGVBbVpWTy84VUVjL29ENjJ6T08y?=
 =?utf-8?B?MGVNdVBnTEllMVJ1ZkIwSmQ1TFpoa1NkcjhpeVhQSWFLVTRTNlhNVS9mZ0h6?=
 =?utf-8?B?bVJrenNkWFVIY3RPaTRBOFozSVBaTlkvMk5YWTdJK0lHWUdad24zRm01aWQw?=
 =?utf-8?B?cW1kclEwM09mWjBqaXlEYVh5T04yTnhjOUUzSDRJM0VKSmF5dW5KYnJ5b2ti?=
 =?utf-8?B?MUx1UjF4d1p0N1U1ODBMZGtsZDM1dE9na3phYVh3c2JFMTJwMU1iMTY1bDRo?=
 =?utf-8?B?cHAxWDc1bVYxWW40d05kclpMUkVscTQ1Vkdsa1VsakhsOC9sNjlNTjdtMHk1?=
 =?utf-8?B?TVRrM0hJNW5nd1VzQ2lGOE45M1V1QVV5M05IN1MxSHNJYmExeE4rZDE3T1VO?=
 =?utf-8?B?REN5dFpGajcwNG5lY21aMExOQTlGR3czYkdBSUdyaG9LaVgzNHpyVEVndzJ4?=
 =?utf-8?B?MnJKSGdUSjBVaXNTc21pa01majNPUURJN2tmMEE2MGhGUHZTK1N1VDR1dVE1?=
 =?utf-8?B?NUE1WElTSE9heFVFWDBMTitGWjByY3Z6WW9WYjMyZkt6K2I1UlphRXMyUWtD?=
 =?utf-8?B?bWIrN0lRSTNCZ1FURFphM1pwOXp1cG1YVG4zTHZpR2FjRW02QmpsZlgreElP?=
 =?utf-8?B?U2pmYjhnWnd6WkJPbm1icG9QbEo4SCtBMU10a01Gc2NxM1BsYkhhc3U4V29z?=
 =?utf-8?B?b0dxQXhGYnVJcGJ3MzNJV0dsRzRrMkhid2oxME9kdWl5U0s4NzZ1cnQ3Zmpj?=
 =?utf-8?B?Q0ZsOWsvQ2I1SWI4YTBMbkpsUWJERStEN29vODJZNGxOUWRVMHZxbW52L05N?=
 =?utf-8?B?VjN3a0t6Yk80RHhPeUlOcDNtWlBDd2EvWWo0eEt6WURnZ3VWNEJLM1JScE0v?=
 =?utf-8?B?VWJpTVlxR21hSXdFNjhHdzRqcVMvUk9SRFhJNGxYN0J0c3BvUCswMU82ZDZy?=
 =?utf-8?B?UVlZVnVOSFo5QVNwUXloTWViYTQvZlI0dXYvRFc3ZEhEUzVEY2RPdVVVeHJt?=
 =?utf-8?B?bWRZM0pTVlVtbUNwWVc3SmpxeWZ6R3phMXdJdnJsYjU2WEw1eHNaQW13VVJp?=
 =?utf-8?B?UmpiZVNjd281SzJVeXJtc0FkaEVCYU1zV2hyNnF2UERjTDJDOTYyc3FITVVY?=
 =?utf-8?B?ekJCQzFLazdpZk1oVWx6ZFNSRm5CT1JRd3pXSEIvK2hySVFDQkl1YXkraENj?=
 =?utf-8?B?b0kxTEFWUVo0WWtVNDhSYmpwN3JQNXRQWXNQVnlFR055dFBsbmtUeVJjTjlN?=
 =?utf-8?B?LzJDKy9BR01MMXU4bUllTUJxT3pBREc5QTM4VVd4U3htUVVhVnJYR0d1cFQy?=
 =?utf-8?B?YjRSWlVWZlpWRTJVVEVsY0F4cVZrZzRnUHVqa3hqSjR1Mms4TE93Y1NweS9o?=
 =?utf-8?Q?J3ZN9XSRc32Vni25sXfPXZ5Ft?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bc744841-66c9-42ee-e52f-08db8fc71b86
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2023 00:02:32.7660
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kvQygSF/5XL5ugN3q9abmyp788i1owj3Pmx7ygRRAlKIyZENtiRIChVIjdSELwjvVQHZm2tFYkyUHtAN++pvFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5010
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/28/2023 5:13 AM, Thomas Gleixner wrote:
> Topology evaluation is a complete disaster and impenetrable mess. It's
> scattered all over the place with some vendor implementatins doing early

s/implementatins/implementations

> +static void parse_topology(struct topo_scan *tscan, bool early)
> +{
> +	const struct cpuinfo_topology topo_defaults = {
> +		.cu_id			= 0xff,
> +		.llc_id			= BAD_APICID,
> +		.l2c_id			= BAD_APICID,
> +	};
> +	struct cpuinfo_x86 *c = tscan->c;
> +	struct {
> +		u32	unused0		: 16,
> +			nproc		:  8,
> +			apicid		:  8;
> +	} ebx;
> +
> +	c->topo = topo_defaults;
> +
> +	if (fake_topology(tscan))
> +	    return;
> +

Spaces used for indenting "return" instead of a tab.