Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1938148rwb; Fri, 28 Jul 2023 18:39:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlHQjyC/QXPuwLFfBTbqb1IAr33fgopLQjkbT613KHcJZHCY5HaoD7AoOcoy3MWzLhY5AX4K X-Received: by 2002:a17:906:76ce:b0:99b:d594:8f8a with SMTP id q14-20020a17090676ce00b0099bd5948f8amr913982ejn.0.1690594749092; Fri, 28 Jul 2023 18:39:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690594749; cv=none; d=google.com; s=arc-20160816; b=JHpGTy4Je5Hsphk0FqhGhglQe2sbungkOEnFsNx/K03T3hcwUNbSmuKymp7/0Xapxd bBYh2/LDwJdJm6/vQYTXRH1Fq+Df8BHlbrgNM9CXihj7LgXjq8LhBt+6t6be3fu/9dZi 2p8Cf00C7YIg3iSROhPG31PGQY9Y2Z+JcFGAc/1xhjBmV1Na3xLGX5TF3+EyjTkSIBW8 yIQBNKepU1BQu1zN9wtQhZBjxXYdolYajdP8H1EmKPHMAnzah86oM2vNG6iGk4MgBwWW k9+wer1TtffacjiBCOpU3UTUTAAROageqrCiRBO5HSDjFZ04W9t75pplOTQw2oLMovQ2 8HIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=PZS0uNEvfyiwplc8DYNdKn2mosqUEMlAwLrRcNlVO/o=; fh=gz4ObIMc4NeQCHdZ3rWVwlgFHb+bHuhROoav4WyE1M4=; b=z+khJTM+bYjFOPNVOoDQP7gk53QhBerGWb3beILQCWHzugU97olsYViLTR22FVwdpU z9XFpv6ocWPrZONWiWUJwc8B623rswEW0cMYWBCi1hK9gubV2nxPh54LVFOB4ZhXF0Vt z0+9najFIaxHb7CWErnEaFO91g2L8qcjlmCbqvUM06Nl1Jf1FoB75TKO5F7iexEzVMi2 YzAvvy9nGhTcPMn7kJ9rgZbCIzYe1wG/KatfMdqLEyTZrOeuinKXZvseIzaIEBrnXZeR dj1r/KxyjS3UYF21Bdx8jE++lM9cSbEZ8/0DkwySQOy4rvp9cBaqjSg7XNociTJUOQEu qMZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BCiqoZRA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gg10-20020a170906e28a00b009888aa1da13si3588439ejb.752.2023.07.28.18.38.45; Fri, 28 Jul 2023 18:39:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BCiqoZRA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235937AbjG2AZs (ORCPT + 99 others); Fri, 28 Jul 2023 20:25:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235931AbjG2AZq (ORCPT ); Fri, 28 Jul 2023 20:25:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DA953C33; Fri, 28 Jul 2023 17:25:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A395E6221E; Sat, 29 Jul 2023 00:25:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FAACC433C7; Sat, 29 Jul 2023 00:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690590345; bh=xoYh6nl7Ymq+oEY+0iyKXVVHHgnEX73mQRAcXMXhUfA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BCiqoZRADYsp7o6W43xzzcFifZX/tdqC4zkUqVu6R4lkllSL+7EE0vp6+VLek8YBq Y6dJlZmalMnKiLu/4TKlRrBiBnAI1qDC+3pVNkOD6JbfGasZ4MjshJkm09OWQFFays VpfMI6e3Um+iCDfsKebGSboT8UH4PO70WLFF880LAlBfYz9N57xl17hAkBY+gDf7D3 1SchvxhtDTIocM1Fm8VJhpuwLhdq0GALw0ftDZ77FZ4oFBr144+3vD+etwu9NhSLiO iD6f/vTZMcWLuHAZ/RAnCe4VoWRS88niwBzOycLaSGvIE24lo7GMJ1Fcs3wfcp7H4r aczenDH6y1PNg== Date: Fri, 28 Jul 2023 17:25:43 -0700 From: Jakub Kicinski To: MD Danish Anwar Cc: Randy Dunlap , Roger Quadros , Simon Horman , Vignesh Raghavendra , Andrew Lunn , Richard Cochran , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Eric Dumazet , "David S. Miller" , , , , , , , Subject: Re: [PATCH v12 06/10] net: ti: icssg-prueth: Add ICSSG ethernet driver Message-ID: <20230728172543.2d5f5660@kernel.org> In-Reply-To: <20230727112827.3977534-7-danishanwar@ti.com> References: <20230727112827.3977534-1-danishanwar@ti.com> <20230727112827.3977534-7-danishanwar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Jul 2023 16:58:23 +0530 MD Danish Anwar wrote: > +/* Classifier helpers */ > +void icssg_class_set_mac_addr(struct regmap *miig_rt, int slice, u8 *mac); > +void icssg_class_set_host_mac_addr(struct regmap *miig_rt, const u8 *mac); > +void icssg_class_disable(struct regmap *miig_rt, int slice); > +void icssg_class_default(struct regmap *miig_rt, int slice, bool allmulti); > +void icssg_ft1_set_mac_addr(struct regmap *miig_rt, int slice, u8 *mac_addr); > + > +/* Buffer queue helpers */ > +int icssg_queue_pop(struct prueth *prueth, u8 queue); > +void icssg_queue_push(struct prueth *prueth, int queue, u16 addr); > +u32 icssg_queue_level(struct prueth *prueth, int queue); If you create the prototypes when the functions are added there will be less need for __maybe_unused. Compiler only cares about prototypes existing, not whether actual callers are in place.