Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230729005133.1095051-1-dmitry.torokhov@gmail.com>
In-Reply-To: <20230729005133.1095051-1-dmitry.torokhov@gmail.com>
From:   Guenter Roeck <groeck@google.com>
Date:   Fri, 28 Jul 2023 19:40:29 -0700
Message-ID: <CABXOdTfUs9wySb5ho+SS5MXVRwaD8gvJoUomS9NSx=QeU5nUxA@mail.gmail.com>
Subject: Re: [PATCH 01/22] Input: cros_ec_keyb - use device core to create
 driver-specific device attributes
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        chrome-platform@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jul 28, 2023 at 5:51=E2=80=AFPM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Instead of creating driver-specific device attributes with
> devm_device_add_group() have device core do this by setting up dev_groups
> pointer in the driver structure.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Guenter Roeck <groeck@chromium.org>

> ---
>  drivers/input/keyboard/cros_ec_keyb.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboa=
rd/cros_ec_keyb.c
> index e7ecfca838df..313b7a69dd69 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -686,10 +686,11 @@ static umode_t cros_ec_keyb_attr_is_visible(struct =
kobject *kobj,
>         return attr->mode;
>  }
>
> -static const struct attribute_group cros_ec_keyb_attr_group =3D {
> +static const struct attribute_group cros_ec_keyb_group =3D {
>         .is_visible =3D cros_ec_keyb_attr_is_visible,
>         .attrs =3D cros_ec_keyb_attrs,
>  };
> +__ATTRIBUTE_GROUPS(cros_ec_keyb);
>
>  static int cros_ec_keyb_probe(struct platform_device *pdev)
>  {
> @@ -730,12 +731,6 @@ static int cros_ec_keyb_probe(struct platform_device=
 *pdev)
>                 return err;
>         }
>
> -       err =3D devm_device_add_group(dev, &cros_ec_keyb_attr_group);
> -       if (err) {
> -               dev_err(dev, "failed to create attributes: %d\n", err);
> -               return err;
> -       }
> -
>         ckdev->notifier.notifier_call =3D cros_ec_keyb_work;
>         err =3D blocking_notifier_chain_register(&ckdev->ec->event_notifi=
er,
>                                                &ckdev->notifier);
> @@ -782,6 +777,7 @@ static struct platform_driver cros_ec_keyb_driver =3D=
 {
>         .remove =3D cros_ec_keyb_remove,
>         .driver =3D {
>                 .name =3D "cros-ec-keyb",
> +               .dev_groups =3D cros_ec_keyb_groups,
>                 .of_match_table =3D of_match_ptr(cros_ec_keyb_of_match),
>                 .acpi_match_table =3D ACPI_PTR(cros_ec_keyb_acpi_match),
>                 .pm =3D pm_sleep_ptr(&cros_ec_keyb_pm_ops),
> --
> 2.41.0.487.g6d72f3e995-goog
>