Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp2075843rwb; Fri, 28 Jul 2023 22:35:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlHeQVuRG9TwfIi1K/yIByP7lNpLRykiKGzPwFlJdAUqSOmH+d4zduIWOIBb2HnyfP/eMFQW X-Received: by 2002:a05:6a00:b4e:b0:67f:48a2:5d9f with SMTP id p14-20020a056a000b4e00b0067f48a25d9fmr5380478pfo.11.1690608937436; Fri, 28 Jul 2023 22:35:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690608937; cv=none; d=google.com; s=arc-20160816; b=z2afefg1VFllQtJnO4eDSFCLrt9YujOfOMPYSwHoiDcJJw99vPLspa4uQm2DebejTL dapnO3H9fjLzmuTQA6djtsK9FzMuTY4HAy7iwvIO9Vm9iWR2RRreypxitWSHK4Qq8iro j2HoAcC3n2FpMknk5Pz7tAXQ6EeB7SUfYexCdrRZ+QQ2Rth7bal6dQgHI9aGJWvUU/cZ AAUWY99qb3wkMNM4YF/QZ2TX6tvBVM7IPjRvpSvis8CaTXv3Zw3yBYOPGoxdk0APEGwq gMmL6Doi3QROFOk6I2r5Zl3+jjVe0elW/d/o4aT9tfXrjTAU9wBswImpAhIuclglo63Z 2c7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=qktoGjm3ZhfyXUi2IyMQ8F1rq78z7KyAsb8GuebGwA8=; fh=2cFGdnMsWLqDs8PWshjrr6TJFMJ9AUkKwMPbTWkOyEc=; b=e3vC1ZOTAVfKWKfDDbi2o/lEtno76EU7yOBwZiqLharcwkjVgDQJYc0NrHIE3PNnWp Tu4TnzCF3o6QYf3VdI57+K7ltzGlmK/DrOSv5cLJHgyPWUPd4yPnDl2Dze8rKLw9A2mL GBvGJGbYurZDEGgz8axHrpnepeqoK5RyMQRGV7p4V7AHUCmTdftNJeO11JJbpD66Ixlb yWRFK0yuPwvetvDXQMHzurYZe4nGB8ULy8fDa/gYRSI2eBGxL/aTyqWr/Iw4A/1W+oj9 0X+GY8rckAayfI39HaN+9UmPAaHRX6vEoVQGLZ7rGEqmux/UAEyofrsnQg+PCjAa8tS2 LHYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SVOJVsRo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a13-20020a634d0d000000b0055c5b8a8888si4082946pgb.684.2023.07.28.22.35.25; Fri, 28 Jul 2023 22:35:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SVOJVsRo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229976AbjG2BuX (ORCPT + 99 others); Fri, 28 Jul 2023 21:50:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbjG2BuW (ORCPT ); Fri, 28 Jul 2023 21:50:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C51E75 for ; Fri, 28 Jul 2023 18:50:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF1686221A for ; Sat, 29 Jul 2023 01:50:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 38B02C433C8; Sat, 29 Jul 2023 01:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690595420; bh=zHRAX00K8JGJW6dPGn+b56RgcIdMCopEEB6OpFLjofY=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=SVOJVsRo+HAth4PzRQAYGD6N1akStIDGe+gEYlXS5EzSxf3Ynz3gVOGPWhWNcjiVT LQgfBSNeiMkuaH15IYZPw3LR7xJ0jjSaUGE6XKyK/JBPMWl5JyeT+euJYbg0yCBrux 8lPASg9hB9U0gixiNQ+q5ZmmD2lM/4IK+ByDQTaBloV410UBDt1nCzAS7GrQQzoapG z0ZEoLs0GlMSXPgJ+H4Af7hqRqIP8PNsC3YhNLNGpZOyWFcWxOK2Z6VRKn5UV6hq/k Hqc2BV27Gy4bSfPMUKomHgGoEPtu3R43mmny94056rq6VjOqyvmo+9GieQ1iuapJkT 6zf0uF4Hklt+A== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 1BEBCE1CF31; Sat, 29 Jul 2023 01:50:20 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] mISDN: hfcpci: Fix potential deadlock on &hc->lock From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169059542010.13127.16700262507413576636.git-patchwork-notify@kernel.org> Date: Sat, 29 Jul 2023 01:50:20 +0000 References: <20230727085619.7419-1-dg573847474@gmail.com> In-Reply-To: <20230727085619.7419-1-dg573847474@gmail.com> To: Chengfeng Ye Cc: isdn@linux-pingi.de, alexanderduyck@fb.com, duoming@zju.edu.cn, yangyingliang@huawei.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Thu, 27 Jul 2023 08:56:19 +0000 you wrote: > As &hc->lock is acquired by both timer _hfcpci_softirq() and hardirq > hfcpci_int(), the timer should disable irq before lock acquisition > otherwise deadlock could happen if the timmer is preemtped by the hadr irq. > > Possible deadlock scenario: > hfcpci_softirq() (timer) > -> _hfcpci_softirq() > -> spin_lock(&hc->lock); > > -> hfcpci_int() > -> spin_lock(&hc->lock); (deadlock here) > > [...] Here is the summary with links: - [v2] mISDN: hfcpci: Fix potential deadlock on &hc->lock https://git.kernel.org/netdev/net/c/56c6be35fcbe You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html