Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp2166410rwb; Sat, 29 Jul 2023 00:56:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlHSbaPrqQlgHyZZDBQhCMlfWvEOFM8WdxxEFhMfZs1OKIv3ObucDThCcsl5KaXcKkmqhntp X-Received: by 2002:a05:6a20:6a1f:b0:137:c971:6a0c with SMTP id p31-20020a056a206a1f00b00137c9716a0cmr4242141pzk.31.1690617410963; Sat, 29 Jul 2023 00:56:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690617410; cv=none; d=google.com; s=arc-20160816; b=L2Yf1HRniRoA5FxxGlg7tB1dxasdV++iMqGMXmqs2Q4n7sH3oDCavJsNJmkx8JqA90 UAys+KnMG2pxcmfnkLXrCVA2AeOy1y81gQKc87i4KhYadv7QFtpKeT+7qQ6s0wrp2D4l CDs4gNr5/OHBTX/D0uJw0ZFnUuro7gtcfJID+gw3SAHpcIIXjYT9/rcryWC0atRZhc7u NslhhDgBXDVA2kjNVT/JEXpqQ49gmnll7qrg3h2xzADM1gF/NuYJJFMvOisP2LxD/h0u 9fokSY5j0sQCdLBgPIiHtTuvk6xgihzM8CYZ2RuuTP/njWpnEzDWq+DA4C6P2Jk4MClT aBYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=+GaVduxUMczbN/UGfa65iXCpdW8DWqsMIsxhI5s3Bz4=; fh=ozWe0fv9S+R1vo3Eh6R/OXXibD+PjdIa3AX+0KREK88=; b=o1XirFpYiLdQwH8+iCI6ClyerAib/WaYFVU4r+sjk5xhChnWWDqi2BXlKih3Q71n+9 uPLfRZN62ClRkKS95gdm/3KyGkYlkGRvUYaHzxYIZExE/JmR/Qwjv4YhjpMapAfoCQ9j GzOHJU3hNzupm3xsd6JHb6LJGeVkxQvwgA17b+NSDY53NdAnqs8T3olV4InPCj9c7Jts zeNaRzIEA9IwBKfkqtHi4sz+rNeVjTa8Nf+fj0Q3SgYOWYwOPnVvuO/DJX7DeGA7qPWn VaOJR2ZeikThegniYJOBHX2hDSRxBSbledwH58Jsy/anVVMetlo8iYGqkakkP5/fJoqk Jjpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cq24-20020a056a00331800b006870f7747f6si2370336pfb.160.2023.07.29.00.56.39; Sat, 29 Jul 2023 00:56:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230519AbjG2H21 (ORCPT + 99 others); Sat, 29 Jul 2023 03:28:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjG2H20 (ORCPT ); Sat, 29 Jul 2023 03:28:26 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3CA9E49D5 for ; Sat, 29 Jul 2023 00:28:25 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 36T7SGk7004141; Sat, 29 Jul 2023 09:28:16 +0200 Date: Sat, 29 Jul 2023 09:28:16 +0200 From: Willy Tarreau To: Mark Brown Cc: Ryan Roberts , Andrew Morton , Naresh Kamboju , linux-kernel@vger.kernel.org, Linux Kernel Functional Testing Subject: Re: [PATCH v1] tools/nolibc/stdio: add setvbuf() to set buffering mode Message-ID: <20230729072816.GE956@1wt.eu> References: <20230726070655.2713530-1-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 26, 2023 at 12:46:16PM +0100, Mark Brown wrote: > On Wed, Jul 26, 2023 at 08:06:55AM +0100, Ryan Roberts wrote: > > Add a minimal implementation of setvbuf(), which error checks the mode > > argument (as required by spec) and returns. Since nolibc never buffers > > output, nothing needs to be done. > > Reviewed-by: Mark Brown Looks good and queued, thanks to you both! Willy