Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <58bde8b7-018c-5f4c-282d-629cfb42515f@suse.com>
Date:   Sat, 29 Jul 2023 10:24:54 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] x86/cpu/amd: Report zenbleed in sysfs
Content-Language: en-US
To:     Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc:     x86@kernel.org, bp@alien8.de, tglx@linutronix.de,
        linux-kernel@vger.kernel.org
References: <20230727075446.1749969-1-nik.borisov@suse.com>
 <20230728231425.mku5wnsgfzx2kyeo@desk>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <20230728231425.mku5wnsgfzx2kyeo@desk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGJXZGlmYXVpSTVLWDdXN254LzUwSElFM1l5OEZKWjRRWW9ldmFGbWg0bkZI?=
 =?utf-8?B?SkhaZm9FUFlTSWFBZW9SallHYldUcjdWNzkzRnZLSU5qVnBaSXNxR1FIdFhp?=
 =?utf-8?B?cmQrQU50VE9aM0twYVpVY1NGSGpUUFdkUUZtVWhXbGMwMWpNOHgyeFpOc216?=
 =?utf-8?B?TTliMS9VWVNVdjV1SzZXQnAzU0tQcDJpd05lS0VZQk4yclNRbmNZM0l3dXNS?=
 =?utf-8?B?bnVqL1JadzllZGIzTDBjVCt0VzVzZzRzSEhiMGlCWVZ4MHRGd1M3NWN6b2FF?=
 =?utf-8?B?T1J6Rjl0elJMc05DWVpPbGZWQmFIUUsxRTYrekU5R0duQndwWEFUZnF4OWYv?=
 =?utf-8?B?M0pZZkdNSTFpZ3ZXTHJuVXJSeElDZzB0bzVHUXJ2SnVpaXhmTjdlaDlid0RP?=
 =?utf-8?B?VnpYWnR3T2pFQ0p5REZUUUNhK2VJVG9iWjN4b2oyQUYyVWhFajBOa2F1enMx?=
 =?utf-8?B?bjJZYkwySll0Y2FmSkdySzkvOGFkbEpNYXVVWEpTWE9TaFBBamkyekh3MjND?=
 =?utf-8?B?Wm8xcDQ2SGNMNG5PNHNFM21NS1J3RjhybkJTeDRsN3lSekhSZlJtZmhFVWtq?=
 =?utf-8?B?YWJsRVYveDBaREZyU1BnNlJzdDBFOE81ck9hSlljeVJyYVJXRE81bDEyczRs?=
 =?utf-8?B?L08rbUs4T09ZRjg3YU5WOG1OYVZtekMvS1dScWNBZ3M3aGpISzU4eXRqcVZt?=
 =?utf-8?B?Tko2REd3bmloZVd5SE9tTGIwQVBCN3NhLzZ2UlhML1ZBSFJpTVhJb2daanVj?=
 =?utf-8?B?RFBDZUU4OHcrczhkTXdmWElkN2g3bUt6bnNkT3k4dW1QV2tBZGx4UDgyZVVB?=
 =?utf-8?B?WkloSUNXNHIzTGMxTlpJM3lKd0FSTEtJY3lGMTVuSlpNRlFSRTVwbm5uNHlh?=
 =?utf-8?B?c0lkNHp2bHFNN0Vtam9nRjBjdnRtbWg0M3FGcmd1KzhYaVNmY1draXdMZGhO?=
 =?utf-8?B?SlhIOGpFdGFLa20rZU5pR3BQWXUvK2VSL200WVJHbHdDR0dHUmpSakFheG5q?=
 =?utf-8?B?czBuQjZxTEkxSll3UW9GVzhLNXV0YVhpcWJ6dmFpeVU3eUVJbENVbElNVjZE?=
 =?utf-8?B?TjBBa1orbnJ4eWNpYVFtVWRzY1NabVFTc3FXOU5TREI0Y29jMTFWWDhSMTdG?=
 =?utf-8?B?aEVsRzYzT3J0LzJRRy9EVVJUbTNGZmtEd0dVOEhJc3QzRlpFY0psZ0RlMTFm?=
 =?utf-8?B?YWllU2VFcjFUNk9jTHJPY1F3MXA3ZEhIbTd6eCtZdnFPdDUvaUFBbXBsRWJS?=
 =?utf-8?B?VitaWHNZTlJVYjlHcXR5RUk0S2NhckxZb3hXbEJrK3NiK0lYWFYwektwTmFI?=
 =?utf-8?B?akhncklFWTJDWS9EWHd2NnQxRllVNVh2Nnd2RmViK0ZHSmdtdXhQb0JueHhu?=
 =?utf-8?B?cGxZMDNPSEU0Y00yWmlwOUtCUUxjZ1hPazVzVTJnR0ZMMHc2c1JseHlvU2RB?=
 =?utf-8?B?TlpJNm52d0xDa0JyMjl5V2hBWkZIdVJ0d2Y1RFI5Y2ZXWDhCanpTNm9Ua1hs?=
 =?utf-8?B?bmVjUUFNUXVOS0Z1THJHeFBCQkJJOUxJTVZoWTNqR0ZlcXkxYysyS3ZMb3RU?=
 =?utf-8?B?YjlkakxCU1VNYVp1c1ZjejJETTlUTVJpOEx1VUFMNE84T3ZISWZ2eGVlSWZv?=
 =?utf-8?B?b25yTnNXTC9uVSszS2wxU1FOUjFxU3UrT3h0Vm5DZkQwQTVkSGpnV1h6WC81?=
 =?utf-8?B?UldrNUtPWWNtbkNISHk2U1NzQnlkKzhkcGlTaGNjZUlJMWp5QzFQcEVMVVNC?=
 =?utf-8?B?YlRZT0t5UlRQLzBNVGhPU1JWeVJyUE9XQlNWNXNOOGRKek0yQ25lV0RNekRt?=
 =?utf-8?B?OW5LTHBIQi8wWW1HaHZieUFWa0NSd0w0MWk0YXNUTGljNUwxWEp4eUQvamNx?=
 =?utf-8?B?NTBjb3FPak9USjloMk0vQ0JxUG8wZEZvZytaY3V4YjJOZUJvSWRPOU0xMDdL?=
 =?utf-8?B?MG10ejRNdXpERHowY2VtQVhsOG1pUE52WjBVdW5jWnB4aUdHbjk5ZU04QUsy?=
 =?utf-8?B?bWsrem1VbFpVS1l2Ti9HWVBWc0FsTjk5eWtFTVlUWkttMHFlaU14ZEx5cCtS?=
 =?utf-8?B?cERhT0ZoQnF0V0NXV3ZJZ08yT2JHNjlicVh3RHd4emdZZmNzTXZFZDFpM2U1?=
 =?utf-8?B?dHVJaytDTlhJUXhOa05EYy8zQ1BFa3FLa0kxUkZYNXIxT1pLN1lselVuWDZt?=
 =?utf-8?Q?0HYUZKS3LKJBmEDgz5J3itZZjxJrlzIVVb2Ks5QwEjk6?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3dcb5fb-8e6d-499c-1301-08db9004ea5f
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2023 07:24:59.1107
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SduY46KNeQW+x6zwuQuYXRD4gIXaUsFu/+s9hoaSbNqUyXUhmZBpY7druKQtHcMPc0LTmnBahTeTOvDrjB/n/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8412
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 29.07.23 г. 2:14 ч., Pawan Gupta wrote:
> On Thu, Jul 27, 2023 at 10:54:46AM +0300, Nikolay Borisov wrote:
>> Initial submission of Zenbleed fix omitted reporting the bug in sysfs.
>> There's no reason why it shouldn't be reported so let's add it among
>> the other vulnerabilities.
>>
>> Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
>> ---
>>   .../ABI/testing/sysfs-devices-system-cpu          |  1 +
>>   arch/x86/kernel/cpu/amd.c                         | 15 +++++++++++++++
>>   drivers/base/cpu.c                                |  8 ++++++++
>>   include/linux/cpu.h                               |  2 ++
>>   4 files changed, 26 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu
>> index ecd585ca2d50..30bb4196e451 100644
>> --- a/Documentation/ABI/testing/sysfs-devices-system-cpu
>> +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu
>> @@ -524,6 +524,7 @@ What:		/sys/devices/system/cpu/vulnerabilities
>>   		/sys/devices/system/cpu/vulnerabilities/itlb_multihit
>>   		/sys/devices/system/cpu/vulnerabilities/mmio_stale_data
>>   		/sys/devices/system/cpu/vulnerabilities/retbleed
>> +		/sys/devices/system/cpu/vulnerabilities/zenbleed
>>   Date:		January 2018
>>   Contact:	Linux kernel mailing list <linux-kernel@vger.kernel.org>
>>   Description:	Information about CPU vulnerabilities
>> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
>> index 26ad7ca423e7..3ab9745eafc5 100644
>> --- a/arch/x86/kernel/cpu/amd.c
>> +++ b/arch/x86/kernel/cpu/amd.c
>> @@ -1279,6 +1279,21 @@ u32 amd_get_highest_perf(void)
>>   }
>>   EXPORT_SYMBOL_GPL(amd_get_highest_perf);
>>   
>> +ssize_t cpu_show_zenbleed(struct device *dev, struct device_attribute *attr, char *buf)
>> +{
>> +
> 
> Extra newline.
> 
>> +	if (!cpu_has_amd_erratum(&boot_cpu_data, amd_zenbleed) ||
>> +	    !boot_cpu_has(X86_FEATURE_AVX) ||
>> +	    boot_cpu_has(X86_FEATURE_HYPERVISOR))
>> +		return sysfs_emit(buf, "Not affected\n");
>> +
>> +	if (!cpu_has_zenbleed_microcode()) {
> 
> For readability this can check of microcode present case, and drop the
> NOT operator.
> 
>> +		return sysfs_emit(buf, "Mitigation: Chickenbit\n");
> 
> Shouldn't this be checking if the chicken bit is set? And if its not set
> then report "Vulnerable".
> 
> But, looking at zenbleed_check() it appear that the chicken bit for
> zenbleed will always be present, and it will always be set if microcode
> is not present.

Yeah, but based on feedback I got from Boris it seems this is not going 
to be merged so it doesn't matter.

> 
>> +	} else {
>> +		return sysfs_emit(buf, "Mitigation: Microcode\n");
>> +	}
>> +}