Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230724074625.458456-1-boris@codesynthesis.com>
 <20230724074625.458456-2-boris@codesynthesis.com> <e11e6287-9b27-90d7-da95-1dc88348b8b0@infradead.org>
 <boris.20230725155503@codesynthesis.com>
In-Reply-To: <boris.20230725155503@codesynthesis.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sat, 29 Jul 2023 18:54:28 +0900
Message-ID: <CAK7LNASHM0Gp7t1tpCMekyYA0c0ntr8COztL9GEivr21MN+faA@mail.gmail.com>
Subject: Re: [PATCH 1/1] kconfig: port qconf to work with Qt6 in addition to Qt5
To:     Boris Kolpackov <boris@codesynthesis.com>
Cc:     Randy Dunlap <rdunlap@infradead.org>, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jul 25, 2023 at 10:58=E2=80=AFPM Boris Kolpackov
<boris@codesynthesis.com> wrote:
>
> Randy Dunlap <rdunlap@infradead.org> writes:
>
> > On 7/24/23 00:46, Boris Kolpackov wrote:
> >
> > > Tested with Qt5 5.15 and Qt6 6.4. Note that earlier versions of Qt5
> > > are no longer guaranteed to work.


This patch did not change scripts/kconfig/qconf-cfg.sh at all.
Hence, Qt5 is always linked.


Please change scripts/kconfig/qconf-cfg.sh so that:

  1. If Qt6 is installed, please link Qt6.
  2. If Qt6 is not installed but Qt5 is installed,
     please link Qt5


> >
> > Was there such a guarantee somewhere?
>
> I don't believe there was anything explicit, but seeing that the
> qconf source code hardly changed in the past couple of years, it
> could have worked with earlier versions of Qt5 and some people
> could have relied on that.
>
>
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > Tested-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks!


A request to reviewers/testers:

  Please make sure you tested this
  with both Qt5 and Qt6.


To check the Qt version you are running:
  1.   'make xconfig'
 2. See  Help -> About


--
Best Regards
Masahiro Yamada