Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 29 Jul 2023 11:52:38 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, jiri@resnulli.us, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH net-next] team: Remove NULL check before dev_{put, hold}
Message-ID: <ZMThZg+feS/PHE3x@corigine.com>
References: <20230727005741.114069-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230727005741.114069-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wBQ+BlpM2hw+QWmorlnUarrwyDy72jnpVfeQ/n9xZka6cSfg8KhBm/XNKipD?=
 =?us-ascii?Q?yuIRiP3dTeVHJ8Dx6v4CDvHi1cBvhs1jmKWaodTq29F4ew9O5Hj2OFnAF2U5?=
 =?us-ascii?Q?P9swg7854p8kG8zbc4R+djFk2VmUF8V02HYTyzL8qGx2oNWk0qUhFG6izTq4?=
 =?us-ascii?Q?qqWoZodj9CNutNUOzAck9/hmVZ64pJZQ0xvSR2y8eRlue4G0KIE5ScD9V61J?=
 =?us-ascii?Q?27ayLK6hyS25lcdgYttxWz4SRP2D3RkD7F41OAGeOPenwpobsX5+vpqavMIT?=
 =?us-ascii?Q?g5UEbPIQS4BelcIBsOx2A3mSnMBwLiwWQCcVWQcSy6jA4vPDxsJY61vVY1Rn?=
 =?us-ascii?Q?hWxX5h9qz0cNEdZ7AM0Uw+3fn2Eac5LRyud3p7PvuT8jPAQPwTVmGbTkSR6q?=
 =?us-ascii?Q?h1ed0KuoBJbJXsAzcsbzdzUPBL12jpuBi2viflMBUhCRw8YxIQvOhzdJz3VE?=
 =?us-ascii?Q?1OFtWRqOqSNa5g1221cLAxYmwh3/Aoi8GumslUmxCzvKFPI3p85e8ELN5WQg?=
 =?us-ascii?Q?WDiFxcE4U8d3YWL7k+d4s8Mzrd93gl76SeU1mPP6OmzoH6PLmg5ikDdi7Npf?=
 =?us-ascii?Q?xEum5hCy6SANpA4m1IXvsIpRMQ8Z2u8xgYvap65rJiJLlFgPkFBKlHOF33ri?=
 =?us-ascii?Q?89PoIvQKqrWM/mWrLAu6awlExu/MlHVK0wdvmIExegQhYE4XlIaCOV4dzRPl?=
 =?us-ascii?Q?i8tKJwge9YRMhCSerK8hdJvk8qM02Y6fJAr34NLXgT74iy3u++AEfc6lab89?=
 =?us-ascii?Q?ohybPWG2274YRJoywFRcYu+qflqJ+CHuL6Ri0B/U9iQf4MabRWaH/kmDzIiP?=
 =?us-ascii?Q?NuKMnysiDl4e4PIWiXfuzkzghATiux7pQsx6wlHugzJoPIc65kKlTBlMLow7?=
 =?us-ascii?Q?sysoaicPQavZBMQb9XQFS+7r+xjsf1cljdC5ldwwwrsvTXKrAPc6b+0PhXue?=
 =?us-ascii?Q?IxTRQEDYqXtT6OCtnJUDhUhmkxMfKpZjNetH3Byny69rdKNCCN+WjQn3KxMq?=
 =?us-ascii?Q?5E/F7ZRN/xzQezhf1/OJHi2F84ERJzeIa1k+QOhBuGRldz9G41CdzDggr9HG?=
 =?us-ascii?Q?gC5ghgKzt7OjNWSOwhXL6asWLjxdbPBT7LhAwQTE70ffOZyn+fcTYa78KHEe?=
 =?us-ascii?Q?cC14QZIufW2GrdxdZCX5Lg9FVpJUT2AFSVvvxwZ0KM2Kw4CQRw+hLVQzTYu8?=
 =?us-ascii?Q?FWk5LDfoffBBmaoVUhzl7ZCLJER+1pb/q5XmDlRreprKFBYX/10VKVkPU5Bx?=
 =?us-ascii?Q?i+vykGuwaJGhbKgmlt2lS0bPk8jceoZvuYuXPn4zLUelCMgJrKVfdwr5rfYj?=
 =?us-ascii?Q?FynoKwud8RKMoYhL2YcjsT8p40Qn+7ClGrCaAvciC9P8wX7To2QamrD/3TeC?=
 =?us-ascii?Q?+wpRqmjDa4FVALIVj4yg4mnlVcVY4Y1IBoVqZ30svI075pSROd15oU4lykeE?=
 =?us-ascii?Q?pXXot76Umd8qT8UUqPXzh5RiBvWIBGT4WleNZEOWhb+4LUWNrqd4ruDwNK9+?=
 =?us-ascii?Q?ogjAb2JvSQF0cjr18gREThT9CsEIrJJWGZ3yQcqcRjT69wV3hep6uqu/VYyr?=
 =?us-ascii?Q?2+bsjVQsTGa4J7geSfjmx4x2MNQR29ZTPmlRh0IZ3YM39EJgYIkJWZ/Fe/V6?=
 =?us-ascii?Q?VcQstJ0VMB91mYP9bic3SgMO7XdX2j5Yw1mr5V9BkSvHD/3hEpeEeI594ept?=
 =?us-ascii?Q?9rkVFA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b13f918-d135-4dbc-d6da-08db90198e77
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2023 09:52:44.4402
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1wgYby5mezPutioPPxmlGHA4Pb2PFZd6Hrcd0mEFk6iix6gfuvBe3xuH/rJDebA6PTLPhVosJ5shgC+hAcka7wuSpHzFYF1Us2vOPDDkqBM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5676
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 27, 2023 at 08:57:41AM +0800, Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning:
> 
> ./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>