Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp2472540rwb; Sat, 29 Jul 2023 07:29:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlGDPRH2D7jCYjRUZ3xsM8Mi91FYoT3bldum8J+kk/sbJ9qZ077m6gADtEtCECMBxyNq/PJe X-Received: by 2002:a17:906:6496:b0:965:9602:1f07 with SMTP id e22-20020a170906649600b0096596021f07mr2826637ejm.39.1690640968452; Sat, 29 Jul 2023 07:29:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690640968; cv=none; d=google.com; s=arc-20160816; b=JD0i/wKql/TY112yRYMkMXlh3iqPArsirk8tYDI6q+7Vh2tu2S6b9Q9ykLrXzoeFJm DLzfaPhuOV3/UxjcfVHKbgqlxi8Qc8C4sJnnjCuSomLMRVf4SEwMd3g6kD6vJB3CNrl4 rAY1f97csrZV0eguz4gb0uw2liEXAbq8kMXfcKIc0n0g4aIrzf3pbTFauhLf29CyLOxZ xrN/cOicZziC/uGLjK5s9ey2oUJ3aA5ZWjtwtF8vrMSgIVxbdf4GdcusRWKY/NLqXgaR ww18OW07poNYy2iFxyrAWkREFb7FZLiCX6HleHjpDrLGxGRiryB7TH+fExgRRgOMEVAE 6GwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:content-disposition :references:message-id:subject:cc:to:from:date:dkim-signature; bh=s3Dpt9/Akir8D+wN5eg5h6OEnmWtXo2JnD1s7kZNIDo=; fh=fveTl5yYgaN23GWIBu3tcpxVy2n2BtZsXZcXYjtUWJw=; b=oCBs9HZyCWzacMhcNzCc1ZbH27J1cjC6hkG/UNQCQgGDm+C9tQmS+wduDNsoqgn3FZ WJyYuXcAcKyKW7sUU1ALBX4Dl7fmeDbIKCqdaAA5jKiauW6Vwk8cob/XwnTGyzXtjehl YUfidpaiBZEVV7K4A8WvUbc9+Xq5MlCsD4CG/+yWU0FXH8Jd02vdSVOU7sKWE0216kV8 /RIQBdH58WFSAjc02pp6dj42phv24+64dfD99+pS83ANG6jh9gToKwqnoKcEkvGGWRnU kg1Nj05SCmZm4nCT0VFzkYYelkmwyLFvp730+pv/NT5aU1Tm1iy+ZZkz3UD+dxqXoVPa Zfyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=kfia2HBu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z17-20020a170906815100b0098dcadb4002si4663656ejw.492.2023.07.29.07.29.04; Sat, 29 Jul 2023 07:29:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=kfia2HBu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229950AbjG2NtY (ORCPT + 99 others); Sat, 29 Jul 2023 09:49:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbjG2NtW (ORCPT ); Sat, 29 Jul 2023 09:49:22 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AE5D3C34; Sat, 29 Jul 2023 06:48:52 -0700 (PDT) Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36TDbIiM031112; Sat, 29 Jul 2023 13:48:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pp1; bh=s3Dpt9/Akir8D+wN5eg5h6OEnmWtXo2JnD1s7kZNIDo=; b=kfia2HBuXRTqNAeCbXqTPzwMDNPLChvsTp/8vNBovFEZYuqVK5wkkPfTIii7ObaqHbOB GP0qvSzWuZ4l/Vtb+TUHRRnXly35dYEMDH/ODZh/k/e3HiTLPljsnLD42myxinJlQ1zl BqTBB9BkKEkMQDFHPjY+yOkqCAnazvOxINM8T5RP0PPJenIXnzpZxl+fEBhdsYmy4Kd1 fbe6Oc/tnj1xum3r/gUqXFYxmobWitEoDoxQgRBzVM2abaiJ3DZanVssNlkOATPD/3zF oar8YkvpCfR8x7G/+DZ75M7q7b7/eEHd/TTnXc2MNKCd3CV5g8WKFdLnAZM0TLQh2k2b kQ== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3s53jgra16-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 29 Jul 2023 13:48:37 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 36TDKceK003714; Sat, 29 Jul 2023 13:48:36 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3s0txkxd15-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 29 Jul 2023 13:48:36 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 36TDmWLd18088494 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 29 Jul 2023 13:48:33 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D974A20043; Sat, 29 Jul 2023 13:48:32 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C6C820040; Sat, 29 Jul 2023 13:48:32 +0000 (GMT) Received: from osiris (unknown [9.171.58.8]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Sat, 29 Jul 2023 13:48:32 +0000 (GMT) Date: Sat, 29 Jul 2023 15:48:31 +0200 From: Heiko Carstens To: Sven Schnelle Cc: Vasily Gorbik , Alexander Gordeev , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-next@vger.kernel.org, Anastasia Eskova , Randy Dunlap Subject: Re: [PATCH] s390/certstore: select CRYPTO_LIB_SHA256 Message-ID: <20230729134831.6882-C-hca@linux.ibm.com> References: <20230728100430.1567328-1-svens@linux.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230728100430.1567328-1-svens@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: UeuQTJleGIw3rYxRX31Q9iqglf85hkLg X-Proofpoint-ORIG-GUID: UeuQTJleGIw3rYxRX31Q9iqglf85hkLg X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-27_10,2023-07-26_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 mlxscore=0 bulkscore=0 adultscore=0 mlxlogscore=910 clxscore=1011 impostorscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307290126 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 28, 2023 at 12:04:30PM +0200, Sven Schnelle wrote: > A build failure was reported when sha256() is not present: > > gcc-13.1.0-nolibc/s390-linux/bin/s390-linux-ld: arch/s390/kernel/cert_store.o: in function `check_certificate_hash': > arch/s390/kernel/cert_store.c:267: undefined reference to `sha256' > > Therefore make CONFIG_CERT_STORE select CRYPTO_LIB_SHA256. > > Fixes: 8cf57d7217c3 ("s390: add support for user-defined certificates") > Reported-by: Randy Dunlap > Closes: https://lore.kernel.org/all/8ecb57fb-4560-bdfc-9e55-63e3b0937132@infradead.org/ > Signed-off-by: Sven Schnelle > --- > arch/s390/Kconfig | 1 + > 1 file changed, 1 insertion(+) Applied, thanks!