Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <24e7429c-14ed-d953-e652-eac178de76e3@intel.com>
Date:   Sat, 29 Jul 2023 21:53:08 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH 2/2] madvise: don't use mapcount() against large folio for
 sharing check
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <stable@vger.kernel.org>, <willy@infradead.org>,
        <vishal.moola@gmail.com>, <wangkefeng.wang@huawei.com>,
        <minchan@kernel.org>, <yuzhao@google.com>, <david@redhat.com>,
        <ryan.roberts@arm.com>, <shy828301@gmail.com>
References: <20230728161356.1784568-1-fengwei.yin@intel.com>
 <20230728161356.1784568-3-fengwei.yin@intel.com>
 <20230728104103.1357b394f9be6352a7c54c79@linux-foundation.org>
Content-Language: en-US
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20230728104103.1357b394f9be6352a7c54c79@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzRFVEtrVGtWYy9mU3F4UWdqaEdtdk9RejBGVU1Od3dnOHpiY1paNC9WTWJk?=
 =?utf-8?B?QjR4Tk5tZmJqUGpJUVlKVnRqRWVJSXlKT3ZaVVlEQWtzSmM1K2hNYTBHTTlq?=
 =?utf-8?B?OExsV3UxK2Nqd0hhVjB0VHo5Rk52NWV2cmZwK1pnUFVSRmhkVGd0aUp2bUht?=
 =?utf-8?B?eDVlUkZHcnA1OEJpWFhwMUZoTlVCY210ZVhPN1dnVVNNdUl2bXM1SnI3SDlB?=
 =?utf-8?B?cE5SNHcyNFZPTlZkTUtUR3VZd08zbU1nWTFrU0hSVGhMTDl3R0RhT3FMUDlF?=
 =?utf-8?B?RGo1YXhkMlF3TU1keFZpSXkxeEtObXUxMnBmRTB5RXdZQ2sxbzk3VDNlUVNS?=
 =?utf-8?B?Q3pVenBINW4vRyt6b2hlLzFCMUxkYTFreVQ0Tys2R2p2ZE43QkROUTVWOGVq?=
 =?utf-8?B?Wnh3S3BkTjdtQWYybWl1UUpkUTVnSlZyeEJDNWRMTHZjcTNDMjV2Und4L2Zq?=
 =?utf-8?B?dUV5S1ZtKzZwMWlZZWtGdGdUTnRvMGxrS2JBdUI2Vlk5WVgxL0hoRC8yUHdF?=
 =?utf-8?B?RFhVSWtnNGpWVGpyK21DRUZkZ2QvbVVuaE1NSjZHT2FiOENlV2VqSlRFN0lq?=
 =?utf-8?B?N3VrWXFUS3R4YVhIdXp4Tkd1dXdSOFdqckdIVFhuN005MStoQ2dsVG1xNTA2?=
 =?utf-8?B?U2tiYkYyYlhRb3J1eDhBSUtkbExxeVgra2tDQzlKK0RLZlduTU4vMytjU3dO?=
 =?utf-8?B?VUpNMFM3UDBLOTRSbUw2L0Y1emhBRTVJdllmaEVMY2h6RFRSdVFIWlVRRjJN?=
 =?utf-8?B?UkpQNHp3eS82clMrUmdqZVNERFpQYjBKZ29lbWpZQjJtdHlSMW1tcmcyOUd4?=
 =?utf-8?B?RE5rNk95aWovVU5yWXRMYndaUnBtUUh0b0lUYU9pK3lhY2kyUWc4Q3c0NWVX?=
 =?utf-8?B?NG1qSWdHR20zSmt3MFlSeklMdGh3N2dNRFRhbWVRYVFobHV4Rzd5N1NtaHBH?=
 =?utf-8?B?c2g4SmJyUkVPWEJkWmZrVFJZN1l0S1BrRjVHZERSdmNSTm9tZmxPRlRBdkh1?=
 =?utf-8?B?ZndCbXhNUUZxbnEybGc0VlJxRmlhS3RxNVI0dXhaeFBoWHkvMWVkQVJ1ZnVU?=
 =?utf-8?B?N0lCc3BQazZ1M3c5WUFTSkdhSytEVy9zRytCUEYwSWpJMWZuYXhvRzFhYlkw?=
 =?utf-8?B?SmtBc0JCenN5bjljRHp4RWxoaUNEOVZzR2VnZXVJQjBHR2pjS0JENE5BamhR?=
 =?utf-8?B?cmpVNVdUN0pNN1lHQzY5ZkNIdXFrbXl1WFJjQWtqb3dpaVVwc1BJenNVY3JW?=
 =?utf-8?B?Q29rRzJhVHBDWWdpNmc3SmxaTVJjNko5dld5R3M2RlpyNm9uM3RldXM4OVVq?=
 =?utf-8?B?QnhiNzR4cHdWKzFBZDJ6cUgyaGR5R1lKT3JXV21JWEVQa3dadXJhNXA5b0lT?=
 =?utf-8?B?SUx1R0FIT2JhMFRGNnRySG1hMXhBVVc5NmJhZlZFVm50R0laVjV2bEoyNDdJ?=
 =?utf-8?B?bi91K1UyVDdWc0IyVXNqZWt1dFY3cGsvQXB3U3FHQTRqcnRPVyt3dWNrUXRH?=
 =?utf-8?B?TlkwRFh0SjdTZmdyR2lxcmpoUDY1WVFrVmpueUdWdXZ6MGhieWxWeU1DTTFB?=
 =?utf-8?B?Z3FhZERpaU51SUJlQmxFdC9JeEIyM1gxbk55TVpOMGk1d1lubDlnTVZrTzEr?=
 =?utf-8?B?dGpXVkdMbE1qa3JuU2lDb2lSbk5INzZxejVQNG9ZTUJGUlBEcDkwTXlPbXlP?=
 =?utf-8?B?WWxOQk84ejlWR1l3WVZQQTNNbnU1Ym0yYi9ESHl3L3prNmgwcTIxRTN5OXEy?=
 =?utf-8?B?ZUV3TDFSVmczODQ3enVrRlFmQmJUOXN2OS9oZmlLUm9hcDZPUXJNUWt2TTBJ?=
 =?utf-8?B?VzRHbC9Od3oxNUdTZ3JUTXpRZWNKZlhUcHU2aVUzeGxkMFhGNU9NV2QyU05r?=
 =?utf-8?B?bTUrbkVpL2lKemk0R2tMMjBTb2pRU2RRbC80K2ppOTF0Yk5GME9hekx5a1RP?=
 =?utf-8?B?bW9tUHIxMXVaMlBQUnZlQzdpR0xiTWFFSVAwMmYrZUpiNjlMR2pxOG1ndnVS?=
 =?utf-8?B?WHlvckF2ZkNxdGFHVHdMZ1FBa1krSHQ2cTdnRXJ1Ry9Fc3ZzbzlXalJmLy84?=
 =?utf-8?B?ZWRKMksxMEJRdU5rUE5LM0l4VDhpUkVya0VDQ3dCV25GUjhSM1o4QUMrVXR3?=
 =?utf-8?Q?DKwIhqbb4erUHqCun8naZKT9l?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5170ff08-0c16-4edf-96d8-08db903b2a02
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2023 13:53:18.8534
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tt+vbRiYgsLDONaPMFgIUXoYoIaZaxuJlI0oVDKSutIhwQUGZrT7vJE0w9VWR7nfrDkM7Y03zSkP639ioas5YQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8489
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

On 7/29/2023 1:41 AM, Andrew Morton wrote:
> On Sat, 29 Jul 2023 00:13:56 +0800 Yin Fengwei <fengwei.yin@intel.com> wrote:
> 
>> Fixes: 98b211d6415f ("madvise: convert madvise_free_pte_range() to use a folio")
>> Fixes: fc986a38b670 ("mm: huge_memory: convert madvise_free_huge_pmd to use a folio")
> 
> Having two Fixes: for one patch presumably makes backporting more
> complicated and adds risk of making mistakes.
> 
> So I have split this into a three-patch series and I've fixed up the patch naming:
> 
> Subject: madvise:madvise_cold_or_pageout_pte_range(): don't use mapcount() against large folio for sharing check
> Subject: madvise:madvise_free_huge_pmd(): don't use mapcount() against large folio for sharing check
> Subject: madvise:madvise_free_pte_range(): don't use mapcount() against large folio for sharing check
Thanks a lot for your kind help. Will be careful for the future patches.

> 
> I haven't added cc:stable at this time - that awaits the description of
> user-visible effects.
The impact of the patch:
  Without the patch, when user calls madvise() with MADV_COLD, MADV_PAGEOUT
  and MADV_FREE, it's likely THP pages will be skipped. With the patch,
  It's likely the THP pages will be split to pages which will be made code,
  reclaimed and freed.


Regards
Yin, Fengwei