Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 29 Jul 2023 21:12:05 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     =?utf-8?B?5a2Z5YaJ?= <sunran001@208suo.com>,
        airlied <airlied@gmail.com>, daniel <daniel@ffwll.ch>,
        "alexander.deucher" <alexander.deucher@amd.com>
Cc:     amd-gfx <amd-gfx@lists.freedesktop.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/radeon: Prefer 'unsigned int' to bare use of
 'unsigned'
Message-ID: <ZMUeNehNb52Qu/Cp@debian.me>
References: <3a4bebc5-79fb-4799-8743-14a0dde97a4f.sunran001@208suo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="01f/lLxb6k6fTJWx"
Content-Disposition: inline
In-Reply-To: <3a4bebc5-79fb-4799-8743-14a0dde97a4f.sunran001@208suo.com>
Precedence: bulk


--01f/lLxb6k6fTJWx
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 28, 2023 at 10:35:19PM +0800, =E5=AD=99=E5=86=89 wrote:
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>=20
> Signed-off-by: Ran Sun <sunran001@208suo.com>

Your From: address !=3D SoB identity

> ---
>  drivers/gpu/drm/radeon/radeon_object.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/radeon/radeon_object.h b/drivers/gpu/drm/rad=
eon/radeon_object.h
> index 39cc87a59a9a..9b55a7103cfd 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.h
> +++ b/drivers/gpu/drm/radeon/radeon_object.h
> @@ -37,7 +37,7 @@
>   *
>   * Returns corresponding domain of the ttm mem_type
>   */
> -static inline unsigned radeon_mem_type_to_domain(u32 mem_type)
> +static inline unsigned int radeon_mem_type_to_domain(u32 mem_type)
>  {
>   switch (mem_type) {
>   case TTM_PL_VRAM:
> @@ -112,12 +112,12 @@ static inline unsigned long radeon_bo_size(struct r=
adeon_bo *bo)
>   return bo->tbo.base.size;
>  }
> =20
> -static inline unsigned radeon_bo_ngpu_pages(struct radeon_bo *bo)
> +static inline unsigned int radeon_bo_ngpu_pages(struct radeon_bo *bo)
>  {
>   return bo->tbo.base.size / RADEON_GPU_PAGE_SIZE;
>  }
> =20
> -static inline unsigned radeon_bo_gpu_page_alignment(struct radeon_bo *bo)
> +static inline unsigned int radeon_bo_gpu_page_alignment(struct radeon_bo=
 *bo)
>  {
>   return (bo->tbo.page_alignment << PAGE_SHIFT) / RADEON_GPU_PAGE_SIZE;
>  }
> @@ -189,7 +189,7 @@ static inline void *radeon_sa_bo_cpu_addr(struct drm_=
suballoc *sa_bo)
> =20
>  extern int radeon_sa_bo_manager_init(struct radeon_device *rdev,
>           struct radeon_sa_manager *sa_manager,
> -         unsigned size, u32 align, u32 domain,
> +         unsigned int size, u32 align, u32 domain,
>           u32 flags);
>  extern void radeon_sa_bo_manager_fini(struct radeon_device *rdev,
>            struct radeon_sa_manager *sa_manager);

The patch is whitespace-corrupted. Use git-send-email(1) to submit patches.
Also, your patch is also MIME-encoded, hence the corruption.

To Alex: Please don't apply this patch due to reasons above.

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--01f/lLxb6k6fTJWx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZMUeMAAKCRD2uYlJVVFO
o58+AQDBnu90P/KFMkRmE5l99Ib4Tj5NqIUMx+sXAV1aN7lIBgEAqWSXDZxC87Ry
rWvbVbgDxvYYyf8JS2Ln6A60zFCshwg=
=ibKj
-----END PGP SIGNATURE-----

--01f/lLxb6k6fTJWx--