From: Jesse Barnes <jesse.barnes@intel.com>
To: Keith Packard <keithp@keithp.com>
Subject: Re: [RFC] AGP initial support for chipset flushing..
Date: Mon, 29 Oct 2007 13:28:09 -0700
User-Agent: KMail/1.9.7
Cc: Dave Airlie <airlied@skynet.ie>, linux-kernel@vger.kernel.org,
       dri-devel@lists.sourceforge.net
References: <Pine.LNX.4.64.0710290811070.1170@skynet.skynet.ie> <200710291247.24791.jesse.barnes@intel.com> <1193688778.4723.35.camel@koto.keithp.com>
In-Reply-To: <1193688778.4723.35.camel@koto.keithp.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200710291328.10763.jesse.barnes@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1488
Lines: 38

On Monday, October 29, 2007 1:12 pm Keith Packard wrote:
> On Mon, 2007-10-29 at 12:47 -0700, Jesse Barnes wrote:
> > In this case, we're performing basically a
> > dma_sync*(...DMA_TO_DEVICE) right?
>
> But this is just for the GPU; every other DMA device in the system is
> cache-coherent.

Right.

> >   Can we be sure that a single flush is sufficient?  Is there any
> > window between when we flush and when we start accessing memory
> > with the device that we could get into more caching trouble?
>
> An uncached write to this page will not complete until the buffers
> are completely flushed.

Yeah, so we should be safe.

> > Looks reasonable, I'm not sure we can do much better.  The only
> > concern I have is that allocating some more PCI space like that may
> > end up clobbering some *other* hidden BIOS mapping, but there's not
> > a whole lot we can do about that.
>
> This isn't a hidden mapping; the i965 doesn't allocate space for it
> in the BIOS.

I know, that's what I'm worried about.  If the BIOS is broken enough to 
not allocate MMIO space for the flush page, it may also be broken 
enough that our hand crafted MMIO space allocation will end up 
conflicting with some unreported BIOS area, which would be bad.

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/