Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230726145740.1765323-1-arnd@kernel.org> <CAJF2gTTC0BTOyWH4Zod1oRQaUpS9dE-6=otfpGOPcCcffrHohQ@mail.gmail.com>
 <ef413a40-ddc4-4d23-bc56-23b7095ffc83@app.fastmail.com> <fc2b139b-909b-46d7-abbc-7ab287c9d06d@app.fastmail.com>
In-Reply-To: <fc2b139b-909b-46d7-abbc-7ab287c9d06d@app.fastmail.com>
From:   Guo Ren <guoren@kernel.org>
Date:   Sat, 29 Jul 2023 19:19:12 -0400
Message-ID: <CAJF2gTRMZkT=CE0=g25Hfe7v9_GE8UmqhKBP1vsXd06w+9NBiQ@mail.gmail.com>
Subject: Re: [PATCH] csky: fix old style declaration in module.c
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        "linux-csky@vger.kernel.org" <linux-csky@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Jul 29, 2023 at 4:05=E2=80=AFAM Arnd Bergmann <arnd@kernel.org> wro=
te:
>
> On Sat, Jul 29, 2023, at 09:06, Arnd Bergmann wrote:
> > On Sat, Jul 29, 2023, at 06:59, Guo Ren wrote:
>
> > I'd like to enable a few warning options (-Wextra, -Wrestrict,
> > -Wmissing-prototypes, ...) in the Kbuild for 6.6, but the Makefile
> > changes will probably go through the Kbuild tree or linux-mm,
> > and the fixes for existing warnings can just take their normal way.
>
> I just checked my log files again and I now see that there
> are actually a number of -Wcc warnings as well:
>
> csky/kernel/signal.c:255:17: error: no previous prototype for 'do_notify_=
resume' [-Werror=3Dmissing-prototypes]
> csky/mm/fault.c:187:17: error: no previous prototype for 'do_page_fault' =
[-Werror=3Dmissing-prototypes]
> csky/kernel/traps.c:57:13: error: no previous prototype for 'trap_init' [=
-Werror=3Dmissing-prototypes]
> csky/kernel/traps.c:150:15: error: no previous prototype for 'do_trap_unk=
nown' [-Werror=3Dmissing-prototypes]
> csky/kernel/traps.c:152:15: error: no previous prototype for 'do_trap_zdi=
v' [-Werror=3Dmissing-prototypes]
> csky/kernel/traps.c:154:15: error: no previous prototype for 'do_trap_bus=
err' [-Werror=3Dmissing-prototypes]
> csky/kernel/traps.c:157:17: error: no previous prototype for 'do_trap_mis=
aligned' [-Werror=3Dmissing-prototypes]
> csky/kernel/traps.c:168:17: error: no previous prototype for 'do_trap_bkp=
t' [-Werror=3Dmissing-prototypes]
> csky/kernel/traps.c:187:17: error: no previous prototype for 'do_trap_ill=
insn' [-Werror=3Dmissing-prototypes]
> csky/kernel/traps.c:210:17: error: no previous prototype for 'do_trap_fpe=
' [-Werror=3Dmissing-prototypes]
> csky/kernel/traps.c:220:17: error: no previous prototype for 'do_trap_pri=
v' [-Werror=3Dmissing-prototypes]
> csky/kernel/traps.c:230:17: error: no previous prototype for 'trap_c' [-W=
error=3Dmissing-prototypes]
> csky/kernel/vdso/vgettimeofday.c:6:5: error: no previous prototype for '_=
_vdso_clock_gettime' [-Werror=3Dmissing-prototypes]
> csky/kernel/vdso/vgettimeofday.c:12:5: error: no previous prototype for '=
__vdso_clock_gettime64' [-Werror=3Dmissing-prototypes]
> csky/kernel/vdso/vgettimeofday.c:18:5: error: no previous prototype for '=
__vdso_gettimeofday' [-Werror=3Dmissing-prototypes]
> csky/kernel/vdso/vgettimeofday.c:24:5: error: no previous prototype for '=
__vdso_clock_getres' [-Werror=3Dmissing-prototypes]
> csky/kernel/setup.c:104:34: error: no previous prototype for 'csky_start'=
 [-Werror=3Dmissing-prototypes]
> csky/kernel/ptrace.c:320:16: error: no previous prototype for 'syscall_tr=
ace_enter' [-Werror=3Dmissing-prototypes]
> csky/kernel/ptrace.c:336:17: error: no previous prototype for 'syscall_tr=
ace_exit' [-Werror=3Dmissing-prototypes]
>
> I missed these as I was first looking at everything except
> -Wmissing-prototypes that I want to enable. Can you perhaps
> help out and create a fix for these yourself?
Okay, I'll check


>
>        Arnd


--=20
Best Regards
 Guo Ren