Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp3378713rwb; Sun, 30 Jul 2023 06:30:38 -0700 (PDT) X-Google-Smtp-Source: APBJJlHvleFolF1NYaivgsNNB65uSZTXA1SkHp1RAcDf55r5SdVGoenszZ8rGMz1SXWhJjfNvnaj X-Received: by 2002:a17:906:29c:b0:99b:7297:fbf5 with SMTP id 28-20020a170906029c00b0099b7297fbf5mr4174412ejf.61.1690723838115; Sun, 30 Jul 2023 06:30:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690723838; cv=none; d=google.com; s=arc-20160816; b=bafbMkOUjVZqQ3vTXgZDF2wzVVDM89Ce4ScjJe+3Jco7zjPEgOaXXLlm5KUEq7OtiS 0aEs8MhKibuCkkvJnDY6Mr2DoEvNQdFBFcW4q8fD400RJ9/ioEp88QIGVhm/BXkstuD9 s7Z85khzBE2KZJ4Wvait1H2EH/O5aucMQ7zBidH3T3Iz/J4pPKBUYSnY6i4bbiilrUlw 57l0ICBymHS5o5bRXXE/wu8rY4ySSQjDEriv1b5YMB8IbwCqrLmQcSnVYO6JaeYvQEgU i4Hr/1lJAWSLRN1Z9OaHFFh1wmzadEhvc1MMSojymwXOl8Iv5E5d/u6arIyQZDIVYYSr YGWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GvClHRBt8Smdu59iQaMhlSVXAGzRkAViH4hQhuCLT/o=; fh=QxmmNvvoMvBQNYYGD2KmM5kA62hKw18XrfSry6uX5+s=; b=SpzInujNkeQzR/Pzy7JQ0ZIZATYT1NFywderULRf6I9F3rQ126dO3SWLZ4EBQB7O4S oC1XMqm93Jt5eq5WI3rxMTumRk3EGrNDPUpdPWJjME4hTqNT0AowwH/1EU/pJ9Dt+4Xv zs4e3q1q/S6QO2SLMaA9NMNH0ispxGx6dESV43KT4KH6CbL7W4hMnTaxVKxeF0FvFtNt 3dWBj0ig1TP4ucWrMPvkYYw2hh31L+GBeY93enLopAauA5FyRIHB/UrcaKDL2XlRnwlY vIBHQFFrOC03ndrzeGAGQDYxGitHI2agxqorcM1qlTsXdQSfHaB1FTkA8m6+7G51YlfN T6zA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NMvtjkW3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y13-20020a170906524d00b00993cc1242ccsi5412583ejm.623.2023.07.30.06.30.11; Sun, 30 Jul 2023 06:30:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NMvtjkW3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229798AbjG3NCJ (ORCPT + 99 others); Sun, 30 Jul 2023 09:02:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjG3NCH (ORCPT ); Sun, 30 Jul 2023 09:02:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25EAA1AE; Sun, 30 Jul 2023 06:02:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A4F0560C34; Sun, 30 Jul 2023 13:02:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77BF5C433C7; Sun, 30 Jul 2023 13:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690722126; bh=HkBskomY64Ev5J2EbXQPFbdqgVV6hfk9ifCbvd9sVxE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NMvtjkW3gNuTOidDtvPW4GS6/CGkaXLvax+fj+gHpYbW3YNKKrZXu34dXDZG0uZqU OURMUYEml22Fx1y5cmy8afdUhLw0yX4vRMOO4xVnFIX8blm3r2xcuk9wGIG10fYHyG tL4JxFBnrgqVS+F1jdl1BySuJ8YLpCBVesT1svP28poXlzUOeAOGMxK/tu9TlnUqSZ Hg9DBccgEZP6ebJX5w6uQS1QfnW0bGKWb2wpVb2cXH+enz2mN/f0wQ1zC/gLznClR+ MMEL7oylnqYYcIpAX6DHLLWvG6FDxFGeui84T7RVHCeVXPNIo0O09cscDysYopIq/B /lQ6vPVwXAMiQ== Date: Sun, 30 Jul 2023 15:02:02 +0200 From: Andi Shyti To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Maxime Coquelin , Alexandre Torgue Subject: Re: [PATCH 20/22] Input: stmfts - use device core to create driver-specific device attributes Message-ID: <20230730130202.pmnxus5mucwu6bom@intel.intel> References: <20230729005133.1095051-1-dmitry.torokhov@gmail.com> <20230729005133.1095051-20-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230729005133.1095051-20-dmitry.torokhov@gmail.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On Fri, Jul 28, 2023 at 05:51:29PM -0700, Dmitry Torokhov wrote: > Instead of creating driver-specific device attributes with > devm_device_add_group() have device core do this by setting up dev_groups > pointer in the driver structure. > > Signed-off-by: Dmitry Torokhov Reviewed-by: Andi Shyti Andi