Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp3379583rwb; Sun, 30 Jul 2023 06:31:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlGxeraLRp30/twwV8XTki6JrK4XUhzrOoX/E6eoqfrYswuwqgSeu9+R9O7kiTf+YE83pKj9 X-Received: by 2002:a17:906:190:b0:99b:f59c:9d90 with SMTP id 16-20020a170906019000b0099bf59c9d90mr5271429ejb.44.1690723893423; Sun, 30 Jul 2023 06:31:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690723893; cv=none; d=google.com; s=arc-20160816; b=0zgvUNmWf8jmisAEBsPW7t/mX7EBpko9nnzI2PG+07T09pOE0ZHnLa92i12Ekbk0eP 6HhboBNNjBdZDclhx1SnCSxJVj9QDATMjboLzHiueQnJAU0R6r/2ruqXZfJix4iOQjL7 t0o9p/mJdJFOGMa8VQ8RypCX6FEzQ+qw5JZnYMK8W5XcJKpwFgLB1WY9FES+N8bI+ro3 pxOh4x7l8Z5FtHp9JNjn8KzhrUCzyQVS/SrX23ud63L5iVnD/G/auwnvYnR4zqLvNNZz +HXXyZ8tUkzlV1Wd+AvnKgEbfTfFFLJcRzW0goKj/ULgH2dAZRvO7GVnpefrxf1xT/RL 3fuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FIfIpDl9pjS10ZlJCD7CV3iOXnH4AOkVveJT9sCbGf4=; fh=gbjeMvCGBvRj4h8RpvWVSp7meG6g4RvE+iSkOXvP9vA=; b=YN8lCjomI6UIp/Ese5fGXtCx/FR3RXtVD90D4fA7F8bSAptUe/3fOXO/ojDNgLN2xk hgu6LZ0YRgwHJ3UARvKiDx6iQ770kp67ye3Qasy/PG9BBBJz5MBtw/IR7Wk0grfUd8BH JbvzaQsfi2aX0rA/uWNPYRSNlbbOv55LTZthSLd/lAjhsr/OaPpDKCOo/OL43s+PWOUL VW/p9MSpp5fYLCElgSRhoVoSiTZRdr7VfKflMx3OS7ZjFAb7J8NGK6vnvH63bKCVtmLP 4rn5p2GGSly0LyUP6YyiG3QgIeqKgLEXp236nhebD2SNzGtSTBEdHe2tc1XzXBsbMXSL VUUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gFcBX5Mg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h10-20020a170906854a00b00992aea2c6a6si1603287ejy.977.2023.07.30.06.31.09; Sun, 30 Jul 2023 06:31:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gFcBX5Mg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229918AbjG3LjN (ORCPT + 99 others); Sun, 30 Jul 2023 07:39:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjG3LjL (ORCPT ); Sun, 30 Jul 2023 07:39:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19EC31BC; Sun, 30 Jul 2023 04:39:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A325160C1E; Sun, 30 Jul 2023 11:39:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B37DDC433C8; Sun, 30 Jul 2023 11:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690717150; bh=qMWIU+f5yjvvP0Z6YT5sLX6EstSebAQh9vRstxRwT24=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gFcBX5MgCppgO2SzzMLDXtla6lHT9VxURUoMFbCIUzbQ3cQUhkO9pgTYYDmjpDa00 NoE7vR5gEJkpWu/8iHLE/UEGal6Fl2GnBIBaiBFqlho2Fy3OZSu1XpsNAa9pJwqLCK mxP4JHL6ijpQNzySF/SsGEOdU50Osfn2PRspchAM= Date: Sun, 30 Jul 2023 13:39:07 +0200 From: Greg Kroah-Hartman To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev Subject: Re: [PATCH 01/22] Input: cros_ec_keyb - use device core to create driver-specific device attributes Message-ID: <2023073050-syndrome-abreast-391f@gregkh> References: <20230729005133.1095051-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230729005133.1095051-1-dmitry.torokhov@gmail.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 28, 2023 at 05:51:10PM -0700, Dmitry Torokhov wrote: > Instead of creating driver-specific device attributes with > devm_device_add_group() have device core do this by setting up dev_groups > pointer in the driver structure. > > Signed-off-by: Dmitry Torokhov > --- > drivers/input/keyboard/cros_ec_keyb.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) All of these look great, thanks for doing them: Reviewed-by: Greg Kroah-Hartman