Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp3434957rwb; Sun, 30 Jul 2023 07:36:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlGwM6XP8X4jVyEdfc9Yrl7Rg1124y4o1a4Ie/5D1eZxNeTzVxYsAp7uBQ6VZDsJp2H8nPUI X-Received: by 2002:a05:6a21:71c1:b0:13d:2f80:cf1c with SMTP id ay1-20020a056a2171c100b0013d2f80cf1cmr3991312pzc.17.1690727761246; Sun, 30 Jul 2023 07:36:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690727761; cv=none; d=google.com; s=arc-20160816; b=XhqNEX8IVLetoJz2jqE6unJ2HFNie7ezI8rZnI6I4g4J/huw57hezYcSj839l8D6p3 8yZDTHa7CZlMA6leLYNT/Ve73iUcXZWm3kUqCr9ZJ0Zx4bd3j8mB9T0LSJY8ZLWUUgQB npFAZAR1+9HoiF2+rBRuQ6dGGBuE9K6p0IgtzMLYBoB9ThPAr0feDTVeZTOFyd4LwVua aeiaa+IXwodCCKOtoSU6hxoNB9SuzPF13utANizmKJG0UDeTCr+Yq0FOJLJ8L6H0iugH O+04M+QO46RCVWyTLeDXeDTZyTU+1+2Ic2IHYvuFsllgRlLqsbRpph/i4BI1PrSTSow9 BwIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=glTkxbBHI8FuvLUadeSjD4NNnkjJQ+H4w63ZZABdmPA=; fh=1eaCaHFz4yZ3qa+6tggXYsDQjIfvmmKyjoWoGViLoKQ=; b=V4gYkpOCSZbamiM/tBbazakHZfWsblABjSJp04GT9B6OSHiQrxf3KtNnxld7ZA9T86 xhKhT2hZPyeyaiIqqcPFdMoc/d4eqpbSW0UxF06QI146Wn/7u8JiGaL0QoxmBfwnhDc9 W+jlNJL6TPJXIDTZw4FvN4tIkQasqGL7P68ebyvczOC7Z4Bhcw8iu+lzQpaOZaiC7p+s TSP7iarRiEhLMwBO4ZAnMm9QIxi5y/4zbXiveJfc7VzVDxsTIZ4xZwfuAnDZWaM/rVyt g6D9ANOy5GpGk3PoWzMFaxnxZ4SUuwWvfYxO6yfg3B/2NJsREbGGPXlJEHGSpRkf5aR6 37Gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=sQN2Bi8q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z25-20020a056a001d9900b006870cd8a877si4166652pfw.172.2023.07.30.07.35.49; Sun, 30 Jul 2023 07:36:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=sQN2Bi8q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbjG3Nk1 (ORCPT + 99 others); Sun, 30 Jul 2023 09:40:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjG3Nk1 (ORCPT ); Sun, 30 Jul 2023 09:40:27 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E7DC1B8; Sun, 30 Jul 2023 06:40:26 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-5576ad1b7e7so476816a12.1; Sun, 30 Jul 2023 06:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690724426; x=1691329226; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=glTkxbBHI8FuvLUadeSjD4NNnkjJQ+H4w63ZZABdmPA=; b=sQN2Bi8qp05k33larDBVywlucB22K59GBsYSyF/KjdwuffLTv0aYitjRYK/xOVFmFf DWyQkVzHrvffItt8A7nDoO4pP5SluIqk0xEJz/ENeMMAn4+ncNoGD1W/N+NgPJCUKtwp amBwE44DA7jTiJCxR4q34z2/N70oom0WekXDGsCIe3u9ULPZtNGHqXE2xwxKnp6IU8o5 TQf+qcmbii3BuBzjWoImuwYcpJDAijCVhOtk+dWQmU4GkVDzNDNaFdvfiWQHqqW6l+Ax QXVfMqq3y2fQo6nzy64s4bMzlYEund9vGa4r2MpMpfnaGzBFSwkeCssgMKjkxIhy93OI UZSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690724426; x=1691329226; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=glTkxbBHI8FuvLUadeSjD4NNnkjJQ+H4w63ZZABdmPA=; b=XYsAYjR48T1eTiCxofJRH4o6pk0PFGTXA0sy0Uh/FtCfh6sr4MkIod6ZkukA+C1P/s gUJocUJeusHqE9UnPnULVlzXMVvehXoDwwzkL7zBvZI8Xn1fk5jhgF5O/cAifOchFsAN oimDvoETU4j7VV2njcVNGaKwJXj6E6Y3rg3PUF9Z8kOdJrxDtNYy1tBtH3afdnzMJ3ID 8GGS/anYZ3sWsiHLXUK/bib8otkEWI64Sh62iae0CDOQrWxlhT9LHKMF6iTAX03p7JeA vhEN7nzYN1oXzrkSs8gYMuLrvsX/eai4MZ5sDl6tQHHAr6qFYjVJ0WwXDq65dSiHOZTm kXgw== X-Gm-Message-State: ABy/qLZEr0QnEddjjfL3pck5SKOCl98ufHWRp4Ac4ASUNKLqsgbwuHbo S7jP7r8Sd/vOrXHokNde6DH9xiVp/fVKfemH2tk= X-Received: by 2002:a17:90a:c84:b0:263:25f9:65b2 with SMTP id v4-20020a17090a0c8400b0026325f965b2mr4088255pja.4.1690724425701; Sun, 30 Jul 2023 06:40:25 -0700 (PDT) MIME-Version: 1.0 References: <20230726075747.1016930-1-xiaolei.wang@windriver.com> In-Reply-To: <20230726075747.1016930-1-xiaolei.wang@windriver.com> From: Fabio Estevam Date: Sun, 30 Jul 2023 10:40:14 -0300 Message-ID: Subject: Re: [PATCH] ARM: dts: imx: Set default tuning step for imx6sx usdhc To: Xiaolei Wang Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, richardcochran@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xiaolei, On Wed, Jul 26, 2023 at 4:58=E2=80=AFAM Xiaolei Wang wrote: > > If the tuning step is not set, the tuning step is set to 1. > For some sd cards, the following Tuning timeout will occur. > > Tuning failed, falling back to fixed sampling clock > > So set the default tuning step. This refers to the NXP vendor's > commit below: > > https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/ > arch/arm/boot/dts/imx6sx.dtsi#L1108-L1109 > > Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap = and step setting") > Signed-off-by: Xiaolei Wang Thanks for your patch: Reviewed-by: Fabio Estevam