Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bdd94a7c-7364-c262-ed01-d7e6fcb26007@linux.alibaba.com>
Date:   Sun, 30 Jul 2023 22:01:11 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: [PATCH v2] erofs: deprecate superblock checksum feature
To:     =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= <thomas@t-8ch.de>,
        Jingbo Xu <jefflexu@linux.alibaba.com>
Cc:     chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org,
        linux-kernel@vger.kernel.org, Karel Zak <kzak@redhat.com>
References: <20230717112703.60130-1-jefflexu@linux.alibaba.com>
 <f796b2ed-8564-45c3-bb04-44dfabb575c7@t-8ch.de>
From:   Gao Xiang <hsiangkao@linux.alibaba.com>
In-Reply-To: <f796b2ed-8564-45c3-bb04-44dfabb575c7@t-8ch.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Hi Thomas,

On 2023/7/30 21:31, Thomas Weißschuh wrote:
> On 2023-07-17 19:27:03+0800, Jingbo Xu wrote:
>> Later we're going to try the self-contained image verification.
>> The current superblock checksum feature has quite limited
>> functionality, instead, merkle trees can provide better protection
>> for image integrity.
> 
> The crc32c checksum is also used by libblkid to gain more confidence
> in its filesystem detection.
> I guess a merkle tree would be much harder to implement.
> 
> This is for example used by the mount(8) cli program to allow mounting
> of devices without explicitly needing to specify a filesystem.
> 
> Note: libblkid tests for EROFS_FEATURE_SB_CSUM so at least it won't
> break when the checksum is removed.
I'm not sure if we could switch EROFS_FEATURE_SB_CSUM to a simpler
checksum instead (e.g. just sum each byte up if both
EROFS_FEATURE_SB_CSUM and COMPAT_XATTR_FILTER bits are set, or
ignore checksums completely at least in the kernel) if the better
filesystem detection by using sb chksum is needed (not sure if other
filesystems have sb chksum or just do magic comparsion)?

The main problem here is after xattr name filter feature is added
(xxhash is generally faster than crc32c), there could be two
hard-depended hashing algorithms, this increases more dependency
especially for embededed devices.

Thanks,
Gao Xiang