Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <502d8316-1630-5818-5ffe-e094788d847a@linux.intel.com>
Date:   Mon, 31 Jul 2023 09:03:16 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v6 1/6] soundwire: bus: Allow SoundWire peripherals to
 register IRQ handlers
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Lee Jones <lee@kernel.org>,
        Charles Keepax <ckeepax@opensource.cirrus.com>
Cc:     broonie@kernel.org, vkoul@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linus.walleij@linaro.org, lgirdwood@gmail.com,
        sanyog.r.kale@intel.com, alsa-devel@alsa-project.org,
        patches@opensource.cirrus.com, devicetree@vger.kernel.org,
        linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230725102532.2567580-1-ckeepax@opensource.cirrus.com>
 <20230725102532.2567580-2-ckeepax@opensource.cirrus.com>
 <20230728151818.GL8175@google.com>
 <db5f1478-8aca-fb57-c3fc-aa09071a0829@linux.intel.com>
Content-Language: en-US
From:   "Liao, Bard" <yung-chuan.liao@linux.intel.com>
In-Reply-To: <db5f1478-8aca-fb57-c3fc-aa09071a0829@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/29/2023 12:44 AM, Pierre-Louis Bossart wrote:
>
> On 7/28/23 17:18, Lee Jones wrote:
>> Vinod, Bard, Pierre-Louis, Sanyog,
>>
>> This has been on the list for some time now.
>>
>> Would one of you please review this, so we can get it merged?
> Sorry, I thought I provided my tag on an earlier version, but apparently
> that never reached the ML. All my earlier feedback was taken into
> account so no objections from me - just one typo below...
>
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>


The patch looks good to me.

Acked-by: Bard Liao <yung-chuan.liao@linux.intel.com>

>> On Tue, 25 Jul 2023, Charles Keepax wrote:
>>
>>> From: Lucas Tanure <tanureal@opensource.cirrus.com>
>>>
>>> Currently the in-band alerts for SoundWire peripherals can only
>>> be communicated to the driver through the interrupt_callback
>>> function. This however is slightly inconvient for devices that wish to
> inconvenient
>
>>> share IRQ handling code between SoundWire and I2C/SPI, the later would
>>> normally register an IRQ handler with the IRQ subsystem. However there
>>> is no reason the SoundWire in-band IRQs can not also be communicated
>>> as an actual IRQ to the driver.