Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] scsi:libsas: Simplify sas_queue_reset and remove unused
 code
To:     Wenchao Hao <haowenchao2@huawei.com>,
        John Garry <john.g.garry@oracle.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Damien Le Moal <dlemoal@kernel.org>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     <louhongxiang@huawei.com>
References: <20230729102451.2452826-1-haowenchao2@huawei.com>
From:   Jason Yan <yanaijie@huawei.com>
Message-ID: <27bb586c-af75-c2da-1b07-02bfb08e5891@huawei.com>
Date:   Mon, 31 Jul 2023 09:44:39 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20230729102451.2452826-1-haowenchao2@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Wenchao,

On 2023/7/29 18:24, Wenchao Hao wrote:
> sas_queue_reset is always called with param "wait" set to 0, so
> remove it from this function's param list. And remove unused
> function sas_wait_eh.

I did not find any users passing '1' to sas_queue_reset() in the git 
history. It seems it is never used. So It's ok to remove it, I guess.

Just one nit, there should be a blank between "scsi:" and "libsas" in 
the subject:

scsi: libsas: Simplify sas_queue_reset and remove unused code

Otherwise looks good to me:
Reviewed-by: Jason Yan <yanaijie@huawei.com>