Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7fe583de-966e-1e86-3233-556886c943d1@kernel.org>
Date:   Mon, 31 Jul 2023 11:05:08 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] scsi:libsas: Simplify sas_queue_reset and remove unused
 code
Content-Language: en-US
To:     Jason Yan <yanaijie@huawei.com>,
        Wenchao Hao <haowenchao2@huawei.com>,
        John Garry <john.g.garry@oracle.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     louhongxiang@huawei.com
References: <20230729102451.2452826-1-haowenchao2@huawei.com>
 <27bb586c-af75-c2da-1b07-02bfb08e5891@huawei.com>
From:   Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <27bb586c-af75-c2da-1b07-02bfb08e5891@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/31/23 10:44, Jason Yan wrote:
> Hi Wenchao,
> 
> On 2023/7/29 18:24, Wenchao Hao wrote:
>> sas_queue_reset is always called with param "wait" set to 0, so
>> remove it from this function's param list. And remove unused
>> function sas_wait_eh.
> 
> I did not find any users passing '1' to sas_queue_reset() in the git 
> history. It seems it is never used. So It's ok to remove it, I guess.
> 
> Just one nit, there should be a blank between "scsi:" and "libsas" in 
> the subject:
> 
> scsi: libsas: Simplify sas_queue_reset and remove unused code
> 
> Otherwise looks good to me:
> Reviewed-by: Jason Yan <yanaijie@huawei.com>

Yeah, code wise, it looks good.
However, I am seeing issues with completions for commands that use command
duration limits. There are some unusual completions that needs special handling
with CDL (e.g. some aborted commands can be notified with a success and
sense-data-available-bit set. For these, we kick libata-EH but it seems that
this is not well working with libsas. So I wonder if this code may need to be
used for CDL... So let's please hold on before applying this. Let me check the
CDL issues I am seeing first.

-- 
Damien Le Moal
Western Digital Research