Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e8140373-9249-e2cb-9767-8459f90245ee@zhaoxin.com>
Date:   Mon, 31 Jul 2023 11:19:35 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] hwrng: add Zhaoxin HW RNG driver
To:     Corentin Labbe <clabbe.montjoie@gmail.com>
CC:     <olivia@selenic.com>, <herbert@gondor.apana.org.au>,
        <jiajie.ho@starfivetech.com>, <conor.dooley@microchip.com>,
        <martin@kaiser.cx>, <mmyangfl@gmail.com>,
        <jenny.zhang@starfivetech.com>, <linux-kernel@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>, <leoliu@zhaoxin.com>,
        <CobeChen@zhaoxin.com>, <YunShen@zhaoxin.com>,
        <TonyWWang@zhaoxin.com>
References: <20230726113553.1965627-1-LeoLiu-oc@zhaoxin.com>
 <ZMITRjPOQAZ8qaZL@Red>
From:   LeoLiu-oc <leoliu-oc@zhaoxin.com>
In-Reply-To: <ZMITRjPOQAZ8qaZL@Red>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/7/27 14:48, Corentin Labbe 写道:
> Le Wed, Jul 26, 2023 at 07:35:53PM +0800, LeoLiu-oc a écrit :
>> From: leoliu-oc <leoliu-oc@zhaoxin.com>
>>
>> Add support for Zhaoxin HW RNG.
>>
>> Signed-off-by: leoliu-oc <leoliu-oc@zhaoxin.com>
>> ---
>>   drivers/char/hw_random/Kconfig       |  13 +++
>>   drivers/char/hw_random/Makefile      |   1 +
>>   drivers/char/hw_random/via-rng.c     |  17 ++--
> 
> Hello
> 
> You are doing changes in via-rng without stating why.
> If changes are needed in via-rng, you should do this in a separate patch.
> 
> Regards

OK，Got it.Thanks for your advice,I will modify it in the next version.

Leoliu-oc