Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1b30056e-0208-841e-9174-4a977dbba309@linux.alibaba.com>
Date:   Mon, 31 Jul 2023 11:13:22 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2 1/2] mm/compaction: correct comment of candidate pfn in
 fast_isolate_freepages
To:     Kemeng Shi <shikemeng@huawei.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20230721150957.2058634-1-shikemeng@huawei.com>
 <20230721150957.2058634-2-shikemeng@huawei.com>
From:   Baolin Wang <baolin.wang@linux.alibaba.com>
In-Reply-To: <20230721150957.2058634-2-shikemeng@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/21/2023 11:09 PM, Kemeng Shi wrote:
> If no preferred one was not found, we will use candidate page with maximum
> pfn > min_pfn which is saved in high_pfn. Correct "minimum" to "maximum
> candidate" in comment.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huawei.com>

Yes, the 'minimum' can be confused. At least to me, it looks good.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> ---
>   mm/compaction.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/compaction.c b/mm/compaction.c
> index eb1d3d9a422c..c0d8d08fc163 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1526,7 +1526,7 @@ static void fast_isolate_freepages(struct compact_control *cc)
>   				break;
>   		}
>   
> -		/* Use a minimum pfn if a preferred one was not found */
> +		/* Use a maximum candidate pfn if a preferred one was not found */
>   		if (!page && high_pfn) {
>   			page = pfn_to_page(high_pfn);
>