Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <77538959-595b-508d-0144-35d56ab5c7d8@linaro.org>
Date:   Mon, 31 Jul 2023 06:52:19 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v5 2/2] arm64: dts: qcom: Use labels with generic node
 names for ADC channels
Content-Language: en-GB
To:     Marijn Suijten <marijn.suijten@somainline.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        cros-qcom-dts-watchers@chromium.org
Cc:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Jami Kettunen <jami.kettunen@somainline.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Manivannan Sadhasivam <mani@kernel.org>,
        Martin Botka <martin.botka@somainline.org>,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht
References: <20230730-generic-adc-channels-v5-0-e6c69bda8034@somainline.org>
 <20230730-generic-adc-channels-v5-2-e6c69bda8034@somainline.org>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
In-Reply-To: <20230730-generic-adc-channels-v5-2-e6c69bda8034@somainline.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 30/07/2023 23:31, Marijn Suijten wrote:
> As discussed in [1] it is more convenient to use a generic `channel`
> node name for ADC channels while storing a friendly - board-specific
> instead of PMIC-specific - name in the label, if/when desired to
> overwrite the channel description already contained (but previously
> unused) in the driver [2].  Follow up on the dt-bindings' `channel` node
> name requirement, and instead provide this (sometimes per-board) channel
> description through a label property.
> 
> Also remove all the unused label references (not to be confused with
> label properties) from pm660, pmp8074 and pms405.
> 
> [1]: https://lore.kernel.org/linux-arm-msm/20221106193018.270106-1-marijn.suijten@somainline.org/T/#u
> [2]: https://lore.kernel.org/linux-arm-msm/20230116220909.196926-4-marijn.suijten@somainline.org/
> 
> Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
>   arch/arm64/boot/dts/qcom/pm6125.dtsi               | 18 ++++++----
>   arch/arm64/boot/dts/qcom/pm6150.dtsi               |  2 +-
>   arch/arm64/boot/dts/qcom/pm6150l.dtsi              |  8 ++---
>   arch/arm64/boot/dts/qcom/pm660.dtsi                | 33 ++++++++++++------
>   arch/arm64/boot/dts/qcom/pm7250b.dtsi              | 24 ++++++-------
>   arch/arm64/boot/dts/qcom/pm8150.dtsi               |  6 ++--
>   arch/arm64/boot/dts/qcom/pm8150b.dtsi              |  8 ++---
>   arch/arm64/boot/dts/qcom/pm8150l.dtsi              |  6 ++--
>   arch/arm64/boot/dts/qcom/pm8916.dtsi               | 14 ++++----
>   arch/arm64/boot/dts/qcom/pm8950.dtsi               | 39 ++++++++++++++--------
>   arch/arm64/boot/dts/qcom/pm8953.dtsi               | 12 +++----
>   arch/arm64/boot/dts/qcom/pm8994.dtsi               | 12 +++----
>   arch/arm64/boot/dts/qcom/pm8998.dtsi               |  2 +-
>   arch/arm64/boot/dts/qcom/pmi8950.dtsi              | 12 +++----
>   arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi          |  6 ++--
>   arch/arm64/boot/dts/qcom/pmm8155au_2.dtsi          |  6 ++--
>   arch/arm64/boot/dts/qcom/pmp8074.dtsi              | 27 ++++++++++-----
>   arch/arm64/boot/dts/qcom/pms405.dtsi               | 21 ++++++++----
>   arch/arm64/boot/dts/qcom/qrb5165-rb5.dts           | 15 ++++++---
>   .../boot/dts/qcom/sc7180-trogdor-coachz-r1.dts     |  4 +--
>   .../arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi |  3 +-
>   .../boot/dts/qcom/sc7180-trogdor-homestar.dtsi     |  3 +-
>   arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi |  2 +-
>   .../boot/dts/qcom/sc7180-trogdor-pompom-r1.dts     |  2 +-
>   .../boot/dts/qcom/sc7180-trogdor-pompom-r2.dts     |  2 +-
>   .../arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi |  3 +-
>   .../boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi  |  3 +-
>   arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi       |  3 +-
>   arch/arm64/boot/dts/qcom/sc7280-idp.dts            |  2 +-
>   arch/arm64/boot/dts/qcom/sc7280-idp.dtsi           |  2 +-
>   arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi         |  4 +--
>   .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts     | 26 +++++++--------
>   arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi         | 10 +++---
>   arch/arm64/boot/dts/qcom/sdm845-mtp.dts            | 12 +++----
>   .../dts/qcom/sm6125-sony-xperia-seine-pdx201.dts   | 15 ++++++---
>   arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts  |  6 ++--
>   arch/arm64/boot/dts/qcom/sm8250-mtp.dts            | 21 ++++++++----
>   37 files changed, 231 insertions(+), 163 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry