Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Jul 2023 12:06:55 +0800
From:   Hangbin Liu <liuhangbin@gmail.com>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, jiri@resnulli.us, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH net-next] team: Remove NULL check before dev_{put, hold}
Message-ID: <ZMczX9ruN3yUsXQc@Laptop-X1>
References: <20230727005741.114069-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230727005741.114069-1-yang.lee@linux.alibaba.com>
Precedence: bulk

On Thu, Jul 27, 2023 at 08:57:41AM +0800, Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning:
> 
> ./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Hangbin Liu <liuhangbin@gmail.com>

> ---
>  drivers/net/team/team.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
> index d3dc22509ea5..bc50fc3f6913 100644
> --- a/drivers/net/team/team.c
> +++ b/drivers/net/team/team.c
> @@ -2321,8 +2321,7 @@ static struct team *team_nl_team_get(struct genl_info *info)
>  	ifindex = nla_get_u32(info->attrs[TEAM_ATTR_TEAM_IFINDEX]);
>  	dev = dev_get_by_index(net, ifindex);
>  	if (!dev || dev->netdev_ops != &team_netdev_ops) {
> -		if (dev)
> -			dev_put(dev);
> +		dev_put(dev);
>  		return NULL;
>  	}
>  
> -- 
> 2.20.1.7.g153144c
>