Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Jul 2023 08:29:04 +0300
From:   Tony Lindgren <tony@atomide.com>
To:     "Sicelo A. Mhlongo" <absicsz@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] bus: omap_l3_smx: identify timeout source before
 rebooting
Message-ID: <20230731052904.GB5194@atomide.com>
References: <20230730202240.898519-1-absicsz@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230730202240.898519-1-absicsz@gmail.com>
Precedence: bulk

* Sicelo A. Mhlongo <absicsz@gmail.com> [230730 20:23]:
> Identify and print the error source before rebooting the board due to an l3
> application timeout error, by delaying the BUG_ON. This is helpful when
> debugging, e.g. via serial.

Makes sense to try to show some information, but please see the question
below.

> diff --git a/drivers/bus/omap_l3_smx.c b/drivers/bus/omap_l3_smx.c
> index bb1606f5ce2d..70f4903d5468 100644
> --- a/drivers/bus/omap_l3_smx.c
> +++ b/drivers/bus/omap_l3_smx.c
> @@ -170,11 +170,9 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
>  		status = omap3_l3_readll(l3->rt, L3_SI_FLAG_STATUS_0);
>  		/*
>  		 * if we have a timeout error, there's nothing we can
> -		 * do besides rebooting the board. So let's BUG on any
> -		 * of such errors and handle the others. timeout error
> -		 * is severe and not expected to occur.
> +		 * do besides rebooting the board after identifying the
> +		 * error source.
>  		 */
> -		BUG_ON(status & L3_STATUS_0_TIMEOUT_MASK);
>  	} else {
>  		status = omap3_l3_readll(l3->rt, L3_SI_FLAG_STATUS_1);
>  		/* No timeout error for debug sources */
> @@ -190,6 +188,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
>  		ret |= omap3_l3_block_irq(l3, error, error_addr);
>  	}
>  
> +	/*
> +	 * BUG on application timeout errors since they are severe and not
> +	 * expected to occur.
> +	 */
> +	BUG_ON(status & L3_STATUS_0_TIMEOUT_MASK);

Aren't you now checking the bit for both L3_SI_FLAG_STATUS_0 and
L3_SI_FLAG_STATUS_1 register values? I think it should be only for register
L3_SI_FLAG_STATUS_0 value?

Regards,

Tony