Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v13 2/2] spi: loongson: add bus driver for the loongson
 spi controller
To:     Mark Brown <broonie@kernel.org>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jianmin Lv <lvjianmin@loongson.cn>, wanghongliang@loongson.cn,
        Liu Peibao <liupeibao@loongson.cn>,
        loongson-kernel@lists.loongnix.cn,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        zhuyinbo@loongson.cn
References: <20230613075834.5219-1-zhuyinbo@loongson.cn>
 <20230613075834.5219-3-zhuyinbo@loongson.cn>
 <3822f248-39dc-fb8d-321a-7b6c833cbb3e@loongson.cn>
 <2264c9bd-76fb-4a99-b655-f4c7bc2a1d45@sirena.org.uk>
 <8ad55123-fbf2-2b0f-faba-f71bb89c7fb1@loongson.cn>
 <67b74e69-f660-43e3-831f-47dbe0fea6fa@sirena.org.uk>
From:   Yinbo Zhu <zhuyinbo@loongson.cn>
Message-ID: <35724895-6b50-eea1-cc3a-5ad82c501920@loongson.cn>
Date:   Mon, 31 Jul 2023 14:07:44 +0800
User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <67b74e69-f660-43e3-831f-47dbe0fea6fa@sirena.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/7/28 下午8:31, Mark Brown 写道:
> On Fri, Jul 28, 2023 at 11:36:48AM +0800, Yinbo Zhu wrote:
>> 在 2023/7/27 下午7:37, Mark Brown 写道:
>>> On Thu, Jul 27, 2023 at 11:09:16AM +0800, Yinbo Zhu wrote:
> 
>>>> Friendly ping ?
> 
>>> Please don't send content free pings and please allow a reasonable time
>>> for review.  People get busy, go on holiday, attend conferences and so
>>> on so unless there is some reason for urgency (like critical bug fixes)
>>> please allow at least a couple of weeks for review.  If there have been
>>> review comments then people may be waiting for those to be addressed.
> 
>> Sorry, my community experience is poor.  How many weeks does the
>> community usually take to review ?  and this time that I waited for six
>> weeks and then ping.
> 
> The delay here is probably fine - the above is a form letter that I send
> whenever people ping so it tries to cover all eventualities.  How long
> to leave things depends a bit on what the change is, an urgent bugfix is
> going to be different from a spelling fix in a comment.


okay, I got it.

> 
>>> Sending content free pings adds to the mail volume (if they are seen at
>>> all) which is often the problem and since they can't be reviewed
>>> directly if something has gone wrong you'll have to resend the patches
>>> anyway, so sending again is generally a better approach though there are
>>> some other maintainers who like them - if in doubt look at how patches
>>> for the subsystem are normally handled.
> 
>> Sorry, I don't got it, that free ping usually only needs to be sent to
>> the subsystem maintainer?
> 
>> Not recommended to use free ping?  or resend the same patch.  If the
>> patch does not need to be modified, does it require sending the same
>> patch ?  And the version number remains the same?
> 
> I'm saying it's generally better to ping by resending the patch.
> Typically keeping the same version number makes sense when doing that -
> people normally say [PATCH RESEND vN] in the subject line.


okay, I got it

Thanks,
Yinbo