Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4041667rwb; Sun, 30 Jul 2023 23:32:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlFoBHfkfJ0pqMo45QygrrbNC46WchN+XV5OrhEpGc/3Zm78BBEUHo3h/dBNeZjqPsTEsgce X-Received: by 2002:a17:902:7242:b0:1b8:7fd7:e022 with SMTP id c2-20020a170902724200b001b87fd7e022mr7262033pll.28.1690785121775; Sun, 30 Jul 2023 23:32:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690785121; cv=none; d=google.com; s=arc-20160816; b=ytLN9y0s/sChbN2aD1ZaeeOuZyTkyJDuw1TLMg3KtKNfmZImPMaUX0+kS4XHAP3FEe Vh+C/CXZR1BmY57dtE22lT3PCGs8MLdZWiFX+ZbrRBYn4xHgq6kd1ZolxRHZVp52sdx/ S0htiJ96ptfqeNqNf0hunDRfc//z9zg2iSeHBHrCpBqlniEeZ+wOVNjh5UpbjHxVIbtD ixwCj9P2PteEtVM0bOeg5LOCanVe9g3T8Ks5aYy7vBlqXU3tlTkQxTyJdn3JjM1tGueM psFBbBCTRZxlpCB+blLoeFIUKXMdzx8nIj4LA59QKQa7q2pk37x2oF5vFXV7c/PixSPy 2f3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; fh=1vuUTineNPguhZ+8zOKbSd1JaGAv1oLTdRFgyn7ljmw=; b=EgixmkPvBL7Yo8SExTz1fXQgPQCb9KQmM5YDGvUtfDOWSCVH/tTIFTH5mKFFTe/UcA Wskdnmdp4jPN/hup5dolxfiIB+DO07zUJ38b++1vBgHa/94oi9dvB/BTFzaeUhggrtan lHy25AFqUJk/oMYT7SIXt7jLPqnfF18nCFxO9AGpGfj4FbT1ZXE3K6SS7nZfXV/Nl8gn K2dD8mWjH2K1VhUpVjZvsGCG4zwmZZgcpmpX1c0Y/jsLhc+Mz5S+rJf2OWLoECFuuEA+ 0yDQDeWHQ+sNWhzykDs8DrAn+IclbvngtCH2BitQ7HCNtv1tALwrRwI2xCrwq7+voypP 4ejQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x18-20020a170902ec9200b001b9d090151esi7383915plg.237.2023.07.30.23.31.50; Sun, 30 Jul 2023 23:32:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230017AbjGaGUb (ORCPT + 99 others); Mon, 31 Jul 2023 02:20:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbjGaGUa (ORCPT ); Mon, 31 Jul 2023 02:20:30 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B99D4B0; Sun, 30 Jul 2023 23:20:29 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id C887D67373; Mon, 31 Jul 2023 08:20:26 +0200 (CEST) Date: Mon, 31 Jul 2023 08:20:26 +0200 From: Christoph Hellwig To: chengming.zhou@linux.dev Cc: axboe@kernel.dk, hch@lst.de, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com Subject: Re: [PATCH v2 4/4] blk-flush: don't need to end rq twice for non postflush Message-ID: <20230731062026.GD30409@lst.de> References: <20230725130102.3030032-1-chengming.zhou@linux.dev> <20230725130102.3030032-5-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725130102.3030032-5-chengming.zhou@linux.dev> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig