Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Hennerich, Michael" <Michael.Hennerich@analog.com>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: RE: [PATCH 05/22] Input: ad7877 - use device core to create
 driver-specific device attributes
Thread-Topic: [PATCH 05/22] Input: ad7877 - use device core to create
 driver-specific device attributes
Thread-Index: AQHZwbbZ0LP3R7KOoEKEGNapcnAve6/TWqiQ
Date:   Mon, 31 Jul 2023 05:23:01 +0000
Message-ID: <SN7PR03MB71321062471405BBF3F9C5188E05A@SN7PR03MB7132.namprd03.prod.outlook.com>
References: <20230729005133.1095051-1-dmitry.torokhov@gmail.com>
 <20230729005133.1095051-5-dmitry.torokhov@gmail.com>
In-Reply-To: <20230729005133.1095051-5-dmitry.torokhov@gmail.com>
Accept-Language: de-DE, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?guTYpJDRUdBeiQLHDIGwRTcmBw3JHBdn73MVo6TFKNExEZMgiS6REhuCMsDz?=
 =?us-ascii?Q?pur5rBwnnmdt/vxrNCrco+cKBZmnz+rXW42QWRQcJwIZdxfm3d3j/m8EPa8l?=
 =?us-ascii?Q?FDQqNjdmYzGkYampEImLBLUmniluU8UbZm1b+YGTu06Ld+FIcZz5dEVFTXg3?=
 =?us-ascii?Q?FIflULgxVMVXjiUPv8W/7cd689+M9ywmbA6MswgdmVA4sCroaIhaPDnawQFR?=
 =?us-ascii?Q?xEsXrslYyHJd7a4FslMDQ7a4D+2mUgQGrujfuis8jvFyT3yy9An39yQetzMq?=
 =?us-ascii?Q?Z3aQOUEutoQvoKWCEuGV5MBbrIxrzEWJ5g8riC3TgaTPJf3xgpzHgyvtrE68?=
 =?us-ascii?Q?0ZyRqMowoGzKhTluhTevynik2izDwG4TxzxaMdPAOoP4eZ4VyLM+pHE/54zP?=
 =?us-ascii?Q?EjYN0wSSSfJFsAH0zoSum7xjcR/HFrotYliryXvaK/8nC/41P+mjFFJP3Blz?=
 =?us-ascii?Q?7nrAhPiKyXfAbrzF0uoLMNRd+dsJQgFceCdFj23KnusJNiuxaYzpv+M1PRuZ?=
 =?us-ascii?Q?U0rnbA/IkKV0s5rxjI0cxsQpqWqYbjZ+LOyaTaAtViZWatb5JcGJs4z/gEOm?=
 =?us-ascii?Q?3Kxm9C6yUCCvBsoj2HCZ0D4U2DDuaOJLpcEKdOnbk0IbMhTVlHXAcy3WKA9u?=
 =?us-ascii?Q?1XdgaoF69owOOW+2OEtKpoWmga4K3bTsaiTsxQ1Pt86mB8k9iFng/5bUGWI7?=
 =?us-ascii?Q?ezO0XgbQV3DZ+sjRZuQ7UTI9Wk06rvdNS/Vek2+gYBF26CuuvBhB/2dD/y4+?=
 =?us-ascii?Q?I4k0g8X+D8kYqE0vyGYXVxwg2CReOhVuPuqOFZORhnoN/pDs/1U3p0LCnOfc?=
 =?us-ascii?Q?pNB6+dMqOCdebavP2A3+M+2cuo68ArIwV0jLU/yalJ2u6AdBsWSBovgP2DsB?=
 =?us-ascii?Q?de3WXx6RQhilrz6dxTC/MvHirNr7RLvkmAqKWrwVbszUVxN2xYvdTjkYgB8F?=
 =?us-ascii?Q?k2dj6wgwysHfefN9y+iQrsxJshn5uRzHIy4Wnze8r+P+YUzudtlLzc6yIoTn?=
 =?us-ascii?Q?KJqdehRhTwC5shrq+Bw9BGOoXErgKZdOsaiDV97/w2OE3BA29S3XPMp009pP?=
 =?us-ascii?Q?ulCVO62qoRen0DYNlK9GjY55thJG+HAqfTd75Aiw8wj/Mb454IxsYDZdjiut?=
 =?us-ascii?Q?Xw0CymleOoBI4gn7LN10T+LuGT23ryn0Ne7DKsHhNdxYOSY5FGg+f2YXbWVi?=
 =?us-ascii?Q?pztUFtXzl5WlkC2B+NNkpwKW7UXeQe6kQlsaKpPhOOqHguBCekM1eazPkCfR?=
 =?us-ascii?Q?XqBd43JzwvN6WfUQEOu+UzTr9vffUcBNd2EIAizq1sJvOpWkHigSpm5HTsPC?=
 =?us-ascii?Q?iodVZWUPBzEA1+9RqV9QjA/m3Gyy9OhgX6mIGL9xWI7n5NMbIIGmDys3qi3z?=
 =?us-ascii?Q?K0/H89EO1w6v9k/n+XU6oo8/Md8kbXnLonG67ckoJ/rl008Y3nFDv2v+ZbiR?=
 =?us-ascii?Q?KnuPIr/eJxc1Gt4pU8EAX5t9xKqcSx/GFi2bk77YPboQB0yt7uNySKHECPN3?=
 =?us-ascii?Q?YtWPxc9kXLtzyva0X/AljbwNtK0sDbIG34vEkep2eZSLCv9GzeEIGhNy3HEL?=
 =?us-ascii?Q?RXzEo1KJmwVQva8P4grTFijRdWR5NGD1nZE+GRqVyU7i5SpYVkRPhzuh3S4n?=
 =?us-ascii?Q?fQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN7PR03MB7132.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3052ab4a-c097-49d0-2f23-08db91863575
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jul 2023 05:23:01.1114
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +eQ0s6U1r12YVOCQ3iXm+F8fiKEzNDQDI/1YCdyPhvVRoGmxiUNUHh0i5esZ7KSEV1wio9Vp24Bz4RlugXcJDExfLmbKIVDdeCQwMbBE4hA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5943
X-Proofpoint-ORIG-GUID: aY_Myg7Wv2cY_k2mIrzPPQc_IXW7IYM2
X-Proofpoint-GUID: aY_Myg7Wv2cY_k2mIrzPPQc_IXW7IYM2
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-27_10,2023-07-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1011
 lowpriorityscore=0 adultscore=0 priorityscore=1501 mlxscore=0 phishscore=0
 bulkscore=0 spamscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2306200000
 definitions=main-2307310048
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Sent: Samstag, 29. Juli 2023 02:51
> To: linux-input@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Hennerich, Michael
> <Michael.Hennerich@analog.com>
> Subject: [PATCH 05/22] Input: ad7877 - use device core to create driver-
> specific device attributes
>=20
> Instead of creating driver-specific device attributes with
> devm_device_add_group() have device core do this by setting up dev_groups
> pointer in the driver structure.
>=20
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
>  drivers/input/touchscreen/ad7877.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/input/touchscreen/ad7877.c
> b/drivers/input/touchscreen/ad7877.c
> index edb36d663f22..a0598e9c7aff 100644
> --- a/drivers/input/touchscreen/ad7877.c
> +++ b/drivers/input/touchscreen/ad7877.c
> @@ -612,10 +612,11 @@ static umode_t ad7877_attr_is_visible(struct
> kobject *kobj,
>  	return mode;
>  }
>=20
> -static const struct attribute_group ad7877_attr_group =3D {
> +static const struct attribute_group ad7877_group =3D {
>  	.is_visible	=3D ad7877_attr_is_visible,
>  	.attrs		=3D ad7877_attributes,
>  };
> +__ATTRIBUTE_GROUPS(ad7877);
>=20
>  static void ad7877_setup_ts_def_msg(struct spi_device *spi, struct ad787=
7
> *ts)  { @@ -777,10 +778,6 @@ static int ad7877_probe(struct spi_device
> *spi)
>  		return err;
>  	}
>=20
> -	err =3D devm_device_add_group(&spi->dev, &ad7877_attr_group);
> -	if (err)
> -		return err;
> -
>  	err =3D input_register_device(input_dev);
>  	if (err)
>  		return err;
> @@ -810,8 +807,9 @@ static DEFINE_SIMPLE_DEV_PM_OPS(ad7877_pm,
> ad7877_suspend, ad7877_resume);
>=20
>  static struct spi_driver ad7877_driver =3D {
>  	.driver =3D {
> -		.name	=3D "ad7877",
> -		.pm	=3D pm_sleep_ptr(&ad7877_pm),
> +		.name		=3D "ad7877",
> +		.dev_groups	=3D ad7877_groups,
> +		.pm		=3D pm_sleep_ptr(&ad7877_pm),
>  	},
>  	.probe		=3D ad7877_probe,
>  };
> --
> 2.41.0.487.g6d72f3e995-goog