Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4088495rwb; Mon, 31 Jul 2023 00:39:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlFkOx9bDT9mYvV8IWPJzzQpiQaN97VU+AlNzYA4KVsJH3ryHfqnvAQJwE6z/b5ruC1NEIDp X-Received: by 2002:a17:906:208c:b0:993:d1b6:61cc with SMTP id 12-20020a170906208c00b00993d1b661ccmr6013944ejq.44.1690789155786; Mon, 31 Jul 2023 00:39:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690789155; cv=none; d=google.com; s=arc-20160816; b=sh93w5eno5dQXDRytwcN8kCD7HwuM7veOwK2EGMry0SKORgmQN+ltPXkDRPw2eYjov Z7evqRvGBOkNf1hW2dkfAKMQuUIajPwvqXkLmNhL2uiQ/Ndh/Gn7IgOOkG3yndl4O+fd +rqG3HffX5gaAvA4aFyIxLMB7sgC/bsnt+kMk+9rrtgRfziLJH2kTwZp7r+klglVFmgf awWoDcQ0Os0mLEYuazYQDLwseqYajykOdV/KX/mBAtepPiZDBbC4pGUynWGhc547fifw C6DIZPXjIzI3lVt5nIknJqLYGPHSahcyRe3sWydo5m3UvSL847aPOQV2ttehRCyA19D+ krgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=UHco60urGZ6G/nxYf/5tK+uquiY3LMdODRfGp/n82IA=; fh=VqUK6AeEMGnfu/wq0K4s5Jcf6oo7f0Pi5mSvMxr0vL4=; b=HiVXoUJE+0iXC5WXKg0cuBvjlqiUpgWL9Z3PGgA0a710T+WgXyH4y7HHzkSI2+beYt a5nNFkIkWt3sJ+bq+hfpzcDiACBQ15gMWXhJSyukHsnJmdo8nfW1tqtfsnU0c8/LIeDU cMZlg75McwdUtshScJKZBPMOAWjnH9e/xuQtl3jCBe3HP/gnjg+4e/LLN5KQwvAZ02oK Mbe2ZpyXrVofdAi1w7McOgifLoi/FEjI8hjApdEtOm3H0xWHYto2FGk3Vt2K8i7uOzwU dMJLKqFUrOS92SVAbIvEA3TrOzGjnVxk9SJ4Z8GZA4908VpViaVjpFViDi8cFKH8o5tZ mTDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=me8WSfKg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s11-20020a170906a18b00b00992b6af11f0si5563431ejy.362.2023.07.31.00.38.50; Mon, 31 Jul 2023 00:39:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=me8WSfKg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230425AbjGaHTg (ORCPT + 99 others); Mon, 31 Jul 2023 03:19:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231653AbjGaHSZ (ORCPT ); Mon, 31 Jul 2023 03:18:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 918431FFA; Mon, 31 Jul 2023 00:17:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D22060F07; Mon, 31 Jul 2023 07:16:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C38C0C433C7; Mon, 31 Jul 2023 07:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690787797; bh=Kbl3vl8F9PAkSdvmheeUSu12turbgGYFzXBz/7n21cE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=me8WSfKgL7EuiAQCQk2k/wnTmUfKNmqXGsSpWG+gwMjoqU2XRNroqffRh+zTdKxd8 oirX0a+WPlMLaE2hG+crYRWK7ZFqJ52ztSd0t97QlHdVZ7WTr1BUOTKOsFav4gJqV7 tAOuDZgo3GGo40lrlp9cTc30WF0OFHYIyEhjeSi0lXjNzRfV11TbmVBQmD8Ear9yXT X5bKETveI6O1oBCq2xOvNQFld4CHQ6XqneB/PuhrMmpIooWTEHshbQSZw/aymC+Q91 mImzaPZbGlu9cvWP9D1Xo2cAdfCP09ucDLlx+5UIlq8aXkgUFqSBR26PMv1uEobcwg H+wx/shfBal6Q== Date: Mon, 31 Jul 2023 09:16:30 +0200 From: Simon Horman To: Lin Ma Cc: michael.chan@broadcom.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, saeedm@nvidia.com, leon@kernel.org, simon.horman@corigine.com, louis.peens@corigine.com, yinjun.zhang@corigine.com, huanhuan.wang@corigine.com, tglx@linutronix.de, bigeasy@linutronix.de, na.wang@corigine.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com Subject: Re: [PATCH net-next v1] rtnetlink: remove redundant checks for nlattr IFLA_BRIDGE_MODE Message-ID: References: <20230726080522.1064569-1-linma@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726080522.1064569-1-linma@zju.edu.cn> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 26, 2023 at 04:05:22PM +0800, Lin Ma wrote: > The previous patch added the nla_len check in rtnl_bridge_setlink, which > is the only caller for ndo_bridge_setlink handlers defined in low-level > driver codes. Hence, this patch cleanups the redundant checks in each > ndo_bridge_setlink handler function. > > Please apply the fix discussed at the link: > https://lore.kernel.org/all/20230726075314.1059224-1-linma@zju.edu.cn/ > first before this one. FWIIW, the patch at the link above seems to be in net-next now. > > Suggested-by: Hangbin Liu > Signed-off-by: Lin Ma Reviewed-by: Simon Horman