Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b20862ba-bfa5-69b8-08e6-08ce76cf36a5@quicinc.com>
Date:   Mon, 31 Jul 2023 15:22:30 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 6/8] soc: qcom: socinfo: adjust the position of QDU1010
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>
CC:     <quic_tsoni@quicinc.com>, <quic_shashim@quicinc.com>,
        <quic_kaushalk@quicinc.com>, <quic_tdas@quicinc.com>,
        <quic_tingweiz@quicinc.com>, <quic_aiquny@quicinc.com>,
        <kernel@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230731061325.26431-1-quic_tengfan@quicinc.com>
 <20230731061325.26431-7-quic_tengfan@quicinc.com>
 <a037a8d3-9ba4-80ee-b34e-9a795ebb6e5b@linaro.org>
From:   Tengfei Fan <quic_tengfan@quicinc.com>
In-Reply-To: <a037a8d3-9ba4-80ee-b34e-9a795ebb6e5b@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 7/31/2023 3:00 PM, Krzysztof Kozlowski 写道:
> On 31/07/2023 08:13, Tengfei Fan wrote:
>> Adjust the position of QDU1010, so that QDU1010 have
>> same sequence with QCOM_ID_QDU1010 in bindings file.
>>
>> Change-Id: I86d46eca55e877aaa1fd948db99b41ae138a3129
> 
> Please run scripts/checkpatch.pl and fix reported warnings. Some
> warnings can be ignored, but the code here looks like it needs a fix.
> Feel free to get in touch if the warning is not clear.
> 
will check if still need this patch.
>> ---
>>   drivers/soc/qcom/socinfo.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>> index 4d49945b3a35..ad7699b401a8 100644
>> --- a/drivers/soc/qcom/socinfo.c
>> +++ b/drivers/soc/qcom/socinfo.c
>> @@ -405,8 +405,8 @@ static const struct soc_id soc_id[] = {
>>   	{ qcom_board_id(SA8775P) },
>>   	{ qcom_board_id(QRU1000) },
>>   	{ qcom_board_id(QDU1000) },
>> -	{ qcom_board_id(QDU1010) },
>>   	{ qcom_board_id(IPQ5019) },
> 
> Same comment as on previous patch.
> 
Will remove this patch, another is handling this: 
https://lore.kernel.org/lkml/20230724083745.1015321-1-quic_kathirav@quicinc.com/T/
>> +	{ qcom_board_id(QDU1010) },
> 
> Best regards,
> Krzysztof
> 

-- 
Thx and BRs,
Tengfei Fan