Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ad6aba3b-f8b8-9cf5-aa50-ad34a7406b5d@quicinc.com>
Date:   Mon, 31 Jul 2023 16:07:43 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 5/8] dt-bindings: arm: qcom,ids: Adjust the position of
 QCOM_ID_QDU1010
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>
CC:     <quic_tsoni@quicinc.com>, <quic_shashim@quicinc.com>,
        <quic_kaushalk@quicinc.com>, <quic_tdas@quicinc.com>,
        <quic_tingweiz@quicinc.com>, <quic_aiquny@quicinc.com>,
        <kernel@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230731061325.26431-1-quic_tengfan@quicinc.com>
 <20230731061325.26431-6-quic_tengfan@quicinc.com>
 <981a79ee-5258-eb76-020a-765f5f39866f@linaro.org>
 <53132580-53b6-06bc-8b48-51a3f56ab71d@quicinc.com>
 <dc327138-0fc2-0766-0d86-08977b07fb76@linaro.org>
From:   Tengfei Fan <quic_tengfan@quicinc.com>
In-Reply-To: <dc327138-0fc2-0766-0d86-08977b07fb76@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 7/31/2023 4:02 PM, Krzysztof Kozlowski 写道:
> On 31/07/2023 09:21, Tengfei Fan wrote:
>>
>>
>> 在 7/31/2023 3:00 PM, Krzysztof Kozlowski 写道:
>>> On 31/07/2023 08:13, Tengfei Fan wrote:
>>>> Adjust the position of QCOM_ID_QDU1010, so that there is a coherent
>>>> sequence of numbers.
>>>>
>>>> Change-Id: Id083e1ecc92c063c1a07a81c66dcb034020964b0
>>>
>>> Please run scripts/checkpatch.pl and fix reported warnings. Some
>>> warnings can be ignored, but the code here looks like it needs a fix.
>>> Feel free to get in touch if the warning is not clear.
>>>
>> sure, will do this check if this patch still need.
> 
> I understand that resending this might not be needed, but just to
> clarify: you must run checkpatch on all your patches before sending
> them. This is the most basic step required before sending anything.
> 
> Best regards,
> Krzysztof
> 
Thanks Krzysztof remind me kindly, will do checkpatch confirm if have 
other patch need push to upstream.
new patcheset already remove this patch, and already got your review, 
Thanks again!

-- 
Thx and BRs,
Tengfei Fan