Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eff61afa-8969-7f22-baf6-771347860efa@amlogic.com>
Date:   Mon, 31 Jul 2023 17:10:33 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible and DT bindings
 for Amlogic C3 Reset Controller
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Jerome Brunet <jbrunet@baylibre.com>
Cc:     linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, kelvin.zhang@amlogic.com
References: <20230719060954.14864-1-zelong.dong@amlogic.com>
 <20230719060954.14864-2-zelong.dong@amlogic.com>
 <f7b72ee90009f6749700a7bd79a3a63786a82a32.camel@pengutronix.de>
 <68b7d772-8dc4-a781-031b-ea33dae41751@linaro.org>
From:   Zelong Dong <Zelong.Dong@amlogic.com>
In-Reply-To: <68b7d772-8dc4-a781-031b-ea33dae41751@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bkQwelEzOFlQRzBXSEM1b3dsaE9jbm5xbnF3Zi9Cd1dIbG81SW96aTBoanEv?=
 =?utf-8?B?eFpEbnlNNkpvSTZUSVpaWW5RdFlhOHhqZmhCcC9IMCtnWGhHNFRobWJ6T1p5?=
 =?utf-8?B?eThWbENqVTRvWEQ1RU93WHBZSzRwL2pOV0RWVWI5c2tUN1hYdHQ2dk1PMnd5?=
 =?utf-8?B?Q0Zuc2hsY3ZxQVpLUjRZcldxOVFTdGY3RlBVMldjazlsVklMNEtjYmJqdUx6?=
 =?utf-8?B?dk9YVEVtVjVXZnl2MEdMeEd6eElUMDhKWlZCWld4aExGY0JydTJVOHZzRWIx?=
 =?utf-8?B?cVBkUHc0Wi94V2N2ckdhNXF0bk50VjVLYjNtN2ZHMzlCWUdlOFhiVTdzZ1ph?=
 =?utf-8?B?NSt1b0t5TS9YU01BVHhNV0tFVThLM0NoWFZCTDFzNmV6b2VIbmZ3VnNlUTlE?=
 =?utf-8?B?Sk0zaTdPR0pjWEx6UzE1R1p5TENFM1JVYWJzdEZBVzg2SVJtcXNqWW1WbDlZ?=
 =?utf-8?B?U1h1WVBKdnFOS3FjQmNEWnJBLzFWV1NjYko1Q21PV3hBNGZXUVdMaFprNmZF?=
 =?utf-8?B?OFBZekZpSWEraHdFN2t5OTRmQ0dRWFRuZU1lTzVYcXJSNGdocVQ3enRKdTZW?=
 =?utf-8?B?V1BMcGs5QWpXNlA3V1ViOENZQ2xQdUpEb3ArSDU0bUJCOTNhQWlyZ08zYm4v?=
 =?utf-8?B?OU5XN0dPaXpVVk5qYlV4dTdXWFZKNUtldVhoRkJFeEJKei91b0lobDN1S1pC?=
 =?utf-8?B?U1dVL1FZYVl5QXZ4YnFtT09JZFF0RTdpcFR4b2hoci9OMElOSjRpWDBSZWRq?=
 =?utf-8?B?S1VOQkxKT2dhLzdLNmtGM1AvamMrUVpqWVJ6cVNRMDE4a2tOK1FhcmhadDFu?=
 =?utf-8?B?b1BVM2xEWjdUc2tpLzc5WU5KTEUxNEY1Q1pPbkVsRHNSdnpPWU52MFp6R3ZT?=
 =?utf-8?B?T0tFMG5MWjJVa3VsQXo3RWRLRUlMOWdWK3QrdE1oSU81bmpuWlJZckNqa1Nl?=
 =?utf-8?B?UGhhWWJUWU5CeWp4bFVmWVp2TU16Sm1kMUJBcC9RbG1iYmI4dDhIY2FzK0ow?=
 =?utf-8?B?a3ZFWFBCWWRhTXc5bmhXMFQ5eUN1ZVNKLy95Qi8vSGxXS2xGR3BGZGR3amgw?=
 =?utf-8?B?VUlsTlBQdFY1MjRibjlYZmUxSzh2Wi8zUW5ESHhOY2pwbDAzTDFPMFJqc1Fw?=
 =?utf-8?B?enZ2K2hjQjc1VnZBQXE2aVh0ek9HeFo3Z3o3VVNDUVd4VmFmVi9YbjR2WXhR?=
 =?utf-8?B?VUVKcnd1Nm52M1V0WStTOVFFeFphb2tFcDBPMWhMQ3RRN2FVMzdZRG9xcTFD?=
 =?utf-8?B?WTNuUXNvVnE1bTFiMUcxbTYxYVJZL2oyMkI2WG00dnY1OThORm1EelN2QUEx?=
 =?utf-8?B?NEcvdFl0eVR2ZGVGdGtsY2VTdnJmQlhXZmVMazR0ZktBZTg0V0t0dnlqdi9l?=
 =?utf-8?B?VTFtcGQyQW5mN01iTmtLZ2ZpNEttUU1lUjJYNDZtSTBQQVVLTURwVFMxUzRk?=
 =?utf-8?B?bnVEVU5OQmpYSXUxZzhaM0p6cnB4TnRuaXlEZkRWdXU2UWI4V2M3dUQyVEl5?=
 =?utf-8?B?UUkreVc0d0N4RU95WWh2V3ZTMDZBOGVldWkrN3FFbzdPN2RpdVZ2K3ozL2hz?=
 =?utf-8?B?T0RTa24xcmpyWnl6UjU1d01oWDdPT21DdkJ5UGd1SjlzSEgwRk50cGVZQ0ty?=
 =?utf-8?B?enMvYTFWVFFJdzN2SXo1aEJicjlvZGI4TjNrRGZKYjE4RmFqTlRXZ3VuUVNB?=
 =?utf-8?B?R2kxMmFNM3BDbFA5QzJ6bVNYUGVWRXJ1S0xZRktXWGtUTWhLY09uMGpxWmh2?=
 =?utf-8?B?Zk5xREY3UmYvR3A1cG1FZW9ZM1dYN3FRRksvb29MbWlnYzdOSC9idmVpRE0v?=
 =?utf-8?B?eTNGc0p0Si9tUzVRempRWDMxNUNOMk80ZExROVNsVTJnLzBOK2pSS2M2Vm1Y?=
 =?utf-8?B?cThxbTlUQ0R3enAzMlFPeW5Geng5dDc3WFZzKzVKZVBxbFNXZzZPM1RoN0ZL?=
 =?utf-8?B?Zi9PYmhqTkpKWXpSZC95MVkydFVPeU9oY00zbjkra083UUxIRFl6cUJLenV0?=
 =?utf-8?B?alNIYnlON0NrdWpJWGFDbE85L0hxcnlSU2F2WmRqTlhkQTRTMDNldXFLWEdP?=
 =?utf-8?B?NjRiUmRLMU9taVlyRnU3WDdWRFFIQWtiZFdKNHc4V2Y4SDFmbDhSQmtabmJw?=
 =?utf-8?B?Nkxpek5sRWdDNnBqMnhHTmRSS0Q1VDhIbGtpekdoKzhoenZ5QnpiNXc5WUxR?=
 =?utf-8?B?MGc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6640b021-2c41-4ffe-de89-08db91a61c52
X-MS-Exchange-CrossTenant-AuthSource: TY0PR03MB7240.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 09:11:23.2039
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 88Ogvj8Df5pN3lXPpD7glwZq17LzaU2JuNPRkDqhy1uogB23ol3h7p6Lxx+/vLNiRwy7ANl8d5FLrd+4Q9I8dQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR03MB7188
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


在 2023/7/29 0:40, Krzysztof Kozlowski 写道:
> On 28/07/2023 17:49, Philipp Zabel wrote:
>>>       maxItems: 1
>>> diff --git a/include/dt-bindings/reset/amlogic,c3-reset.h b/include/dt-bindings/reset/amlogic,c3-reset.h
>>> new file mode 100644
>>> index 000000000000..d9127863f603
>>> --- /dev/null
>>> +++ b/include/dt-bindings/reset/amlogic,c3-reset.h
>>
>> Given that this is only included by
>> arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi, should this header be
>> moved to arch/arm64/boot/dts/amlogic ?
> 
> I think there is ongoing work or at least plan to use the IDs also in
> clock/reset drivers for all Amlogic platforms. Do I recall this correctly?
> 
> Best regards,
> Krzysztof
> 
So far, Amlogic reset headers are only included by DTS, reset driver 
will not include these.
Should I move all the headers (include/dt-bindings/reset/amlogic,*.h) to 
arch/arm64/boot/dts/amlogic ?