Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9b57e5f7-62b6-fd65-4dac-a71c9dc08abc@linux.alibaba.com>
Date:   Mon, 31 Jul 2023 18:58:14 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: [syzbot] [erofs?] [fat?] WARNING in erofs_kill_sb
To:     Christoph Hellwig <hch@lst.de>,
        syzbot <syzbot+69c477e882e44ce41ad9@syzkaller.appspotmail.com>
Cc:     brauner@kernel.org, chao@kernel.org, huyue2@coolpad.com,
        jack@suse.cz, jefflexu@linux.alibaba.com, linkinjeon@kernel.org,
        linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, sj1557.seo@samsung.com,
        syzkaller-bugs@googlegroups.com, xiang@kernel.org
References: <000000000000f43cab0601c3c902@google.com>
 <20230731093744.GA1788@lst.de>
From:   Gao Xiang <hsiangkao@linux.alibaba.com>
In-Reply-To: <20230731093744.GA1788@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/7/31 17:37, Christoph Hellwig wrote:
> On Mon, Jul 31, 2023 at 12:57:58AM -0700, syzbot wrote:
>> Hello,
>>
>> syzbot found the following issue on:
>>
>> HEAD commit:    d7b3af5a77e8 Add linux-next specific files for 20230728
> 
> Hmm, the current linux-next tree does not seem to have that commit ID
> any more, and the line numbers don't match up.  I think it is the
> WARN_ON for the magic, which could probably be just removed.  I'll
> try the reproducers when I find a bit more time.

Previously, deactivate_locked_super() or .kill_sb() will only be
called after fill_super is called, and .s_magic will be set at
the very beginning of erofs_fc_fill_super().

After ("fs: open block device after superblock creation"), such
convension is changed now.  Yet at a quick glance,

WARN_ON(sb->s_magic != EROFS_SUPER_MAGIC);

in erofs_kill_sb() can be removed since deactivate_locked_super()
will also be called if setup_bdev_super() is falled.  I'd suggest
that removing this WARN_ON() in the related commit, or as
a following commit of the related branch of the pull request if
possible.

Thanks,
Gao Xiang