Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbXJ3Aro (ORCPT ); Mon, 29 Oct 2007 20:47:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752334AbXJ3Arg (ORCPT ); Mon, 29 Oct 2007 20:47:36 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:35310 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752293AbXJ3Arf (ORCPT ); Mon, 29 Oct 2007 20:47:35 -0400 Message-ID: <47267F15.9090302@garzik.org> Date: Mon, 29 Oct 2007 20:47:17 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.5 (X11/20070727) MIME-Version: 1.0 To: Mathieu Desnoyers CC: Randy Dunlap , hch@infradead.org, linux-kernel@vger.kernel.org, Sam Ravnborg , Jens Axboe , Prasanna S Panchamukhi , Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S. Miller" , Ingo Molnar , Peter Zijlstra , Philippe Elie , Linus Torvalds , "William L. Irwin" , Arjan van de Ven , Christoph Lameter , Valdis.Kletnieks@vt.edu Subject: Re: [RFC] Create instrumentation directory (git repository) References: <20071029215138.GA4233@Krystal> <20071029154741.cb093f55.rdunlap@xenotime.net> <4726649A.5020605@garzik.org> <20071029230409.GB16943@Krystal> <472667F3.3000505@garzik.org> <20071029233515.GA19413@Krystal> In-Reply-To: <20071029233515.GA19413@Krystal> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1834 Lines: 40 Mathieu Desnoyers wrote: > I see no good reason to have so many different adhoc instrumentation > mechanisms for profiling (sched, vm, oprofile) and tracing (blktrace, > suspend/resume tracing) all over the place. Merging them in a single > directory seems like a good step towards a more generic > instrumentation/profiling/tracing infrastructure. Moving files about in directories should be at the /lowest/ end of the priority scale. It makes diffs unreadable, file histories and diffing difficult, and a host of other problems. Please solve the /real/ problems, and then come back and clean up the file structure after that is done. Massive file renaming to satisfying some imagined future everything-is-golden scheme is the /last/ step. It is the last step taken because the previous steps inevitably give you guidance that you otherwise would not have had at the start of the task. When I try to diff between old and new alpha oprofile code, I really want to know that the reason why diffing is a pain in the ass is more than "it seemed like a good first step." > Back to "profile" and "probes" directory names, they might be short, but > they do not represent the whole markup-profiling-tracing trio, > "profile" lacks the tracing part and "probe" lacks the markup part. You can always add more letters (and words) to even reach the desired level of specificity. That does nothing to help readability though. Anyway, it should be clear from existing precedent -- existing pathnames -- that "instrumentation" is too long, and really IMO too vague anyway. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/