Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 31 Jul 2023 10:58:21 +0000
Message-Id: <CUGAYUWIYL8Y.1UID37JVB3IIZ@seitikki>
Subject: Re: [PATCH] tpm/tpm_tis: Disable interrupts for TUXEDO InfinityBook
 S 15/17 Gen7
From:   "Jarkko Sakkinen" <jarkko@kernel.org>
To:     "Takashi Iwai" <tiwai@suse.de>
Cc:     "Peter Huewe" <peterhuewe@gmx.de>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        "Lino Sanfilippo" <l.sanfilippo@kunbus.com>,
        <linux-integrity@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230726180035.14511-1-tiwai@suse.de>
 <CUE1URH8QI55.15YQBHZNSL2UJ@seitikki> <878razdwnh.wl-tiwai@suse.de>
In-Reply-To: <878razdwnh.wl-tiwai@suse.de>
Precedence: bulk

On Sat Jul 29, 2023 at 7:06 AM UTC, Takashi Iwai wrote:
> On Fri, 28 Jul 2023 21:24:30 +0200,
> Jarkko Sakkinen wrote:
> >=20
> > On Wed Jul 26, 2023 at 6:00 PM UTC, Takashi Iwai wrote:
> > > TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on
> > > tpm_tis like a few other laptops.  Add an entry for the workaround.
> > >
> > > Cc: stable@vger.kernel.org
> > > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
> > > Link: https://bugzilla.suse.com/show_bug.cgi?id=3D1213645
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > > ---
> > >  drivers/char/tpm/tpm_tis.c | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > >
> > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> > > index cc42cf3de960..a98773ac2e55 100644
> > > --- a/drivers/char/tpm/tpm_tis.c
> > > +++ b/drivers/char/tpm/tpm_tis.c
> > > @@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_ta=
ble[] =3D {
> > >  			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"),
> > >  		},
> > >  	},
> > > +	{
> > > +		.callback =3D tpm_tis_disable_irq,
> > > +		.ident =3D "TUXEDO InfinityBook S 15/17 Gen7",
> > > +		.matches =3D {
> > > +			DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
> > > +			DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"),
> > > +		},
> > > +	},
> > >  	{
> > >  		.callback =3D tpm_tis_disable_irq,
> > >  		.ident =3D "UPX-TGL",
> > > --=20
> > > 2.35.3
> >=20
> > Hi does this occur with the latest linux-next and/or v6.5-rc3?
>
> Not tested yet, but do you have any relevant fix except for the commit
> 481c2d14627d ("tpm,tpm_tis: Disable interrupts after 1000 unhandled
> IRQs")?  That commit was already tested, at least.

OK, I will pick this, thank you.

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko