Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753123AbXJ3BIj (ORCPT ); Mon, 29 Oct 2007 21:08:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751989AbXJ3BIb (ORCPT ); Mon, 29 Oct 2007 21:08:31 -0400 Received: from www.tglx.de ([62.245.132.106]:38338 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbXJ3BIb (ORCPT ); Mon, 29 Oct 2007 21:08:31 -0400 Date: Tue, 30 Oct 2007 02:06:43 +0100 (CET) From: Thomas Gleixner To: Hiroshi Shimamoto cc: Arjan van de Ven , vgoyal@in.ibm.com, hbabu@us.ibm.com, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, "Eric W. Biederman" Subject: Re: [PATCH] Revert x86: add lapic_shutdown for x86_64 In-Reply-To: <4726753D.3010601@ct.jp.nec.com> Message-ID: References: <47195763.1090803@ct.jp.nec.com> <47195807.6030809@ct.jp.nec.com> <20071024062933.GA4622@in.ibm.com> <47266132.5050001@ct.jp.nec.com> <20071029161534.6e7f0db6@laptopd505.fenrus.org> <4726753D.3010601@ct.jp.nec.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 32 On Mon, 29 Oct 2007, Hiroshi Shimamoto wrote: > Arjan van de Ven wrote: > > On Mon, 29 Oct 2007 15:39:46 -0700 > > Hiroshi Shimamoto wrote: > > > >> lapic_shutdown is useless on x86_64. > >> > > > > .... but since the goal is to get apic_32.c and apic_64.c to be more > > converging (to the point of becoming the same file)... isn't your patch > > going in the opposite direction? > > > Hmm, I'm not sure that this revert affects x86 unification. > Vivek said that probably we don't have to introduce lapic_shutdown() for 64bit. > So I submitted this patch which reverts my previous post, it was applied before > the comment. Don't worry, we sort this out. There is some inevitable friction loss for now, but we are getting closer. I gave the apic code some care to get a readable diff out of it. Result is in: git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git cleanup Thanks, tglx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/