Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4293327rwb; Mon, 31 Jul 2023 04:57:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlHAVtOs1bdEjhck4xmwb1YQe+rLTk1Iv3N+fEmym5wa46KzAmnFA4t0r0q1EBEwwgeWdbO7 X-Received: by 2002:a17:902:ec82:b0:1bb:9c45:130f with SMTP id x2-20020a170902ec8200b001bb9c45130fmr11235366plg.69.1690804675170; Mon, 31 Jul 2023 04:57:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690804675; cv=none; d=google.com; s=arc-20160816; b=ymrY3ldiiGOtIx/PUTs1Afj1TAAMAbUkxTND61EAySznJ2EWP5TEon+XcxmsUCqy9k XpVBdUn+pAffjgA4qHkt1T5ne4LHDTSwuhLsYs+Uhpb5WzPFNVIhbIo9UR3sIQjX7jvb lc3rTyaW51jt3hvcCMYe2iIblO9e4egADdQZuzxEEZ/ZRoxnRf4py/GBFU3sz87pf9ns EHrkyqvJDzp65nhOyVQLwQUQp//EwPtPch90Ldo82mUgelYSjol8doR+JaP+Y6V2Kkdl K+1vtnzObfXXXIfQyXnbss3b4AE/mQHz2dSlua1FdCqozLQmytCLd4B+equhoGm7ZhyE h8Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MqN1zyOK2vwgyh1OErUwVoR7+gI9rdomT7d/iuN3gj0=; fh=Bmwo45jh2IfXyPPjZw5JpwScV7Oce9CqNpIavqWS/c0=; b=BZ+66B0YEHXlw9G7uShNHqTckDr92v4imUyiZvaZW0Zk9Z6EO2/m0Flwy/DVP1EsF9 xZmBRagdO4+0xwTjZwoQKXMVxtOdcuv0GiWl4iYbaRcOGY7fSPlNvWL4B0QW3WUvFvmU V9YfsOmBwCvc8+ajI0QS27VSD3OFQXmiHVeZCoSeBKym3niD1rbts95mO4ZWFUqt4ZwP RFK5pGEdMo1Ioqg65Kj6ajwTy7gxfUPbyWo+j3An8wvT/R7robofliazARjKw9Aw7x3J SpxH2aKMvFw5HWMxNe9k8NoLMDr5Ta/HYK9V4/veuvMvuSySvDT0RFny8jJepN4tI9oH VlUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PbRZrZDQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h2-20020a170902f54200b001b86c526fd8si49721plf.448.2023.07.31.04.57.42; Mon, 31 Jul 2023 04:57:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PbRZrZDQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbjGaLSR (ORCPT + 99 others); Mon, 31 Jul 2023 07:18:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231162AbjGaLSM (ORCPT ); Mon, 31 Jul 2023 07:18:12 -0400 Received: from mgamail.intel.com (unknown [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28764E52; Mon, 31 Jul 2023 04:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690802292; x=1722338292; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=87FJUSPLcNXOCb7lHfymEPJKHULKnzHi3EOabZ1gBGw=; b=PbRZrZDQV18A7KoxfUbO5ap13+ZUmfrFfuKSsI49ovs7gRLi12MFngVg dHkQwpWhpi7xCvAFdwv3D4sUlfGu/vPHQ5Ih6gaVTwmU+CghrTtbccO4l DUeQUBbAt1N/7pOUYo1ozrK83xRO4IcbZkugVROJwkO+A+dvdSTe7zQPR JnJD0FUEB7EiM6k7bg5xb2xI8D2md6MT+oIhfp3vCXk0tYDYq4I2RjNDv zMzrPLk9UCxJSCFmF/IKkwKvPilHWVA7t/U2sqLShcbS+JGPKCIjJIL9N DkJMSOrQCn/evYnay0pFmQfl/xkvIJQFXCqBorqXiOIp3/SFa9ynv9Him Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10787"; a="399939020" X-IronPort-AV: E=Sophos;i="6.01,244,1684825200"; d="scan'208";a="399939020" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2023 04:14:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="871645957" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 31 Jul 2023 04:14:07 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id A981B1E8; Mon, 31 Jul 2023 14:14:15 +0300 (EEST) Date: Mon, 31 Jul 2023 14:14:15 +0300 From: Mika Westerberg To: Tom Rix Cc: andreas.noever@gmail.com, michael.jamet@intel.com, YehezkelShB@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thunderbolt: set variable tmu_params storage class specifier to static Message-ID: <20230731111415.GH14638@black.fi.intel.com> References: <20230702190608.3441704-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230702190608.3441704-1-trix@redhat.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 02, 2023 at 03:06:08PM -0400, Tom Rix wrote: > smatch reports > drivers/thunderbolt/tmu.c:30:3: warning: symbol > 'tmu_params' was not declared. Should it be static? > > This variable is only used in its defining file so should be static. > > Signed-off-by: Tom Rix Applied, thanks!