Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 31 Jul 2023 11:07:39 +0000
Message-Id: <CUGB5ZDAQVCH.1MBPZYSTIKAVO@seitikki>
Cc:     <mario.limonciello@amd.com>,
        <James.Bottomley@hansenpartnership.com>, <Jason@zx2c4.com>,
        <linux-integrity@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <regressions@leemhuis.info>, <stable@vger.kernel.org>,
        <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/1] tpm: disable hwrng for fTPM on some AMD designs
From:   "Jarkko Sakkinen" <jarkko@kernel.org>
To:     "Daniil Stas" <daniil.stas@posteo.net>
References: <20230214201955.7461-2-mario.limonciello@amd.com>
 <20230727183805.69c36d6e@g14> <CUE1Z76QDX0Z.2K0OU6TPMS50X@seitikki>
 <20230728231810.48370d44@g14> <CUGA0YM7BIJN.3RDWZ1WZSWG28@seitikki>
 <20230731132837.64690d7b@g14>
In-Reply-To: <20230731132837.64690d7b@g14>
Precedence: bulk

On Mon Jul 31, 2023 at 10:28 AM UTC, Daniil Stas wrote:
> On Mon, 31 Jul 2023 10:14:05 +0000
> "Jarkko Sakkinen" <jarkko@kernel.org> wrote:
>
> > On Fri Jul 28, 2023 at 8:18 PM UTC, Daniil Stas wrote:
> > > On Fri, 28 Jul 2023 19:30:18 +0000
> > > "Jarkko Sakkinen" <jarkko@kernel.org> wrote:
> > > =20
> > > > On Thu Jul 27, 2023 at 3:38 PM UTC, Daniil Stas wrote: =20
> >  [...] =20
> > > >=20
> > > > This is needs a bit more elaboration in order to be comprehended.
> > > >=20
> > > > Do you mean by "stutter" unexpected delays and when do they
> > > > happen?
> > > >=20
> > > > BR, Jarkko =20
> > >
> > > Yes, unexpected delays. They just happen randomly.
> > > You can google "AMD fTPM stuttering", there are a lot of examples.
> > > Here is one: https://www.youtube.com/watch?v=3DTYnRL-x6DVI =20
> >=20
> > What if you make tpm_amd_is_rng_defective() to unconditonally return
> > true? Does this make the problem dissappear, or not?
> >=20
> > BR, Jarkko
>
> I already tried compiling kernel without CONFIG_HW_RANDOM_TPM enabled,
> which does the same.
> Yes, it removes the issue.

Thank you, just wanted sanity check that I exactly know what is going on.

BR, Jarkko