Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4320257rwb; Mon, 31 Jul 2023 05:18:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlEInkIIRmDEgg1tMop1jhsk8WWM/QBAFy89byuv/sKCuv7vIXnaD8r1IE1SmkU/jNeU0CaS X-Received: by 2002:a05:6a00:2ea6:b0:686:2539:9ff2 with SMTP id fd38-20020a056a002ea600b0068625399ff2mr10633490pfb.9.1690805895576; Mon, 31 Jul 2023 05:18:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690805895; cv=none; d=google.com; s=arc-20160816; b=IQnbix917yGRSAzLKux8b5sBDHFndhGpPnYFf40AUIllU74aW9SiX2qWVhzBDcH6aV oWXhoTvBWbsNJgr4UVXik4dZQSH7JhQ8FKEo4pC8AnGknDCqMsE3DVa/A/0l47E5wpG3 L4uHnK9USKJEo7xxvnsFLVeg/OvEyQ1T9wYLx7YIF2m++r5TRCwuKjruUhY1IfcSdR8M PPGUXZdJsudhj7Kdcip4awUTWqQnpwCMOSunElcSihCLfVd8YBGT3hkHoqGa2cHzwbXh jA+senk7ahgdpw64rvpR79MZ+kWieK7QLTvevgHMKI8ni7AVAb/Ic5b6OIliXWazeGH2 gEMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XnhE/MJy7KpATP6aWLjVTXZKI0FxtMo18WDQHlC4OP0=; fh=LlGHSq8jZuwDQMtDdZVKOHArDf4RztNIQfXdwngy6Ec=; b=FlvgSHf/pFMjrYhEzWNT8P+ORih7LvCZNGhKXpeHPHS7H5GKFI36DQ6QT/Ied0M6fc V4Rx9g/XcFUD4PQvqyb80/JeMOVAclEXF/WINihVOPB01F/FiQQQl7SJG1IaoLWqkDbR izgVpLG3rXbYJTKeDexba0C1Rq5rQBYlm/yOFgbmNddBftOV2itqGhQXK/Vepy+nMMpD zx8QqMKGQ59xJcP5bWYCfFiNyAaxz2ARi0KerU6MRJf/C/FDdtasAUTyHrHK/R1mH9C/ kgIJISfNbLLFBKHq06OqPm0uORpQIxPJh2UNVRwVZbhsDqLtdTWT3r6frN0t0c8tZlUw XG7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=r6NCuUd2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h11-20020a63574b000000b00553ce421356si7205832pgm.56.2023.07.31.05.18.02; Mon, 31 Jul 2023 05:18:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=r6NCuUd2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231430AbjGaLFc (ORCPT + 99 others); Mon, 31 Jul 2023 07:05:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229868AbjGaLFb (ORCPT ); Mon, 31 Jul 2023 07:05:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B305A98; Mon, 31 Jul 2023 04:05:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 48A196100C; Mon, 31 Jul 2023 11:05:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24852C433C7; Mon, 31 Jul 2023 11:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690801529; bh=aDQytpIehxdC9Y92aOCsKJiiWVzUj/QKa0p5med/PCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r6NCuUd2dWAFRltw2+pGmuDVTotQpjH0ekKpzZTX6xFqUgNw1T9VfYT3y9t9W5+Zi a90PJEXjCJlyzYqhxvr/DW6eMaqAi8zS6wVgLCL/aR8FuEgbQLT1Uwoy4WRgpwA9Qx +/vFsSMs5e4xpn7tonapNyoZMS+bpeH9TBXzd6Xo= Date: Mon, 31 Jul 2023 13:05:26 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Luis Chamberlain , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Ulf Hansson , Yangbo Lu , Joshua Kinard , Daniel Vetter , linux-arm-kernel@lists.infradead.org, open list , linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org Subject: Re: [PATCH 5/5] modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules Message-ID: <2023073135-destiny-washbowl-2689@gregkh> References: <20230731083806.453036-1-hch@lst.de> <20230731083806.453036-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230731083806.453036-6-hch@lst.de> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 31, 2023 at 10:38:06AM +0200, Christoph Hellwig wrote: > It has recently come to my attention that nvidia is circumventing the > protection added in 262e6ae7081d ("modules: inherit > TAINT_PROPRIETARY_MODULE") by importing exports from their propriertary > modules into an allegedly GPL licensed module and then rexporting them. > > Given that symbol_get was only ever inteded for tightly cooperating > modules using very internal symbols it is logical to restrict it to > being used on EXPORY_SYMBOL_GPL and prevent nvidia from costly DMCA "EXPORT" :) > circumvention of access controls law suites. > > All symbols except for four used through symbol_get were already exported > as EXPORT_SYMBOL_GPL, and the remaining four ones were switched over in > the preparation patches. > > Fixes: 262e6ae7081d ("modules: inherit TAINT_PROPRIETARY_MODULE") > Signed-off-by: Christoph Hellwig Thanks for fixing this hole up, it's much needed. Reviewed-by: Greg Kroah-Hartman