Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4354426rwb; Mon, 31 Jul 2023 05:51:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlGntfPkiajEBIjzmxmSeqnSfuEoY+G5AX++0pLsjwKt+qrkh7favxYWcrcDooi64KUtXGNT X-Received: by 2002:a2e:84ce:0:b0:2b6:c081:6323 with SMTP id q14-20020a2e84ce000000b002b6c0816323mr5706305ljh.50.1690807877853; Mon, 31 Jul 2023 05:51:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690807877; cv=none; d=google.com; s=arc-20160816; b=jtoZA/ehf4gnaWRXBnMtY9Vp1LtbPLk478nj+tvxOSDc/eKDKmTIck6V8Zvu1ZTemd nsK3a/G2NwUsJrgBZGEI8gn9ItYEmIvqPZwE+y/KMWzH8a/Hsm1zRlPq7EJTuiQSHYhD JSsRc+Hs55A+QSg5JDo6W82++Ktr0CRMu49W08CndwXAH1Yg3SrKwbAar+qlIfSpOonQ ue4sZgmtg72JL9NYLDJUIv73yvkow8OUxW37EmQ/uuISdyRgMuqw8NwKCsuwsRaerDL3 7eHXdBGSCks+vdKJWlqkvbxPvb1aD8OhbU5hrMFCmgPo9bgjG2F8EJUsZ4NfPJ6mfs8/ gj9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:message-id:subject:cc:to:from:date; bh=HGzcuKs3hWCNjXN5X5sfq9Ab+XyNsh25IJ7QlEdTUI8=; fh=2jjjKxOoIP8adYJrb3FkpUdDMnSNJm2HxfzZQllnNZc=; b=SLC+/z7GfoTbzFQwcQoGKTpjpIq8ITqJKm9yWMCEkiykTMJYidyLCkqu/Zawl/INYO PmKlUR6VlPyEE1AR0N6o0RyF2IEMN2exON9ZecTOSg9IauT4SV6h3+EJdPvADXKr2HKI KE30GxUh6yR/8E6e26uT6mr3x5nYgPlnbJL0SqOwO/2+aSf48nRnNE9ImKkGnj5S1EW+ pNVUO0O2xkBGD9JuVqZvZpvS2nl4auc+F3yrjQS6l8+G4NAcbD+S7JaR0wOYTD2A+oM4 HJbz2gDVdnthGIMGMxwcX+fOMNKevx6XzHDUfVZNMcMN96q5J2z9M6OZnCt964NAhWua tZOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n22-20020a170906841600b0099367afd642si6512805ejx.66.2023.07.31.05.50.52; Mon, 31 Jul 2023 05:51:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232564AbjGaLWa (ORCPT + 99 others); Mon, 31 Jul 2023 07:22:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231166AbjGaLWT (ORCPT ); Mon, 31 Jul 2023 07:22:19 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D4C31BDB; Mon, 31 Jul 2023 04:22:01 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 0EB0367373; Mon, 31 Jul 2023 13:21:56 +0200 (CEST) Date: Mon, 31 Jul 2023 13:21:55 +0200 From: Christoph Hellwig To: Pintu Kumar Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, iommu@lists.linux.dev, pintu.ping@gmail.com, Sumit Semwal , Benjamin Gaignard , Liam Mark , Laura Abbott , Brian Starkey , John Stultz , Christian =?iso-8859-1?Q?K=F6nig?= , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v2] dma-contiguous: define proper name for global cma region Message-ID: <20230731112155.GA3662@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1690598115-26287-1-git-send-email-quic_pintu@quicinc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,FAKE_REPLY_C, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pintu, On Sat, Jul 29, 2023 at 08:05:15AM +0530, Pintu Kumar wrote: > The current global cma region name defined as "reserved" > which is misleading, creates confusion and too generic. > > Also, the default cma allocation happens from global cma region, > so, if one has to figure out all allocations happening from > global cma region, this seems easier. > > Thus, change the name from "reserved" to "global-cma-region". I agree that reserved is not a very useful name. Unfortuately the name of the region leaks to userspace through cma_heap. So I think we need prep patches to hardcode "reserved" in add_default_cma_heap first, and then remove the cma_get_name first.