Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f84bbc50-2cd1-833d-7e99-e669cfc17c74@gmx.de>
Date:   Mon, 31 Jul 2023 14:43:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/1] fbdev: mmp: fix value check in mmphw_probe()
Content-Language: en-US
To:     Yuanjun Gong <ruc_gongyuanjun@163.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Lisa Du <cldu@marvell.com>, linux-fbdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230727170318.18412-1-ruc_gongyuanjun@163.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20230727170318.18412-1-ruc_gongyuanjun@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:juz6mdP1klo=;LOJz6O8knWygtmqjGiIEI6XwyS1
 vi/+iNVpY57sgRndt7MHyb4s5I5O1MhTHRFvlchhO0LgVeav7bWsSHRXA+Gmc5lyog5MTf5Uo
 Ow4/G7POV3BL1jVSyJyCPOxJQ6PPyOUH8r1TiOIQE21GRy6D4uQC2egTrzbM27WVgAONBHY+q
 cbx762NkSJVn2kLA9FgVEHk19+rhXa8C8VBQVWaXI4xx1vqJS+lAU3GG15ZMsHIXNl8yk7Z7c
 3mHHiDTpI5vhW7Hpy1SvhUwPchS/vC3iAbniWP1uhd63ifuRIQDMjqOmjvo/9u5uX2QREwhTI
 mYeEzTjjn28NyVQsERmoZUFrkdhiNanmHa/ymvBeSw5lO2bhb5pJ7xqXSyni8VREayvR/Xv1a
 kbKACL8G7RMl6/Q/ymc4Z164eG1S2+8dpIkSgW4haMep1zSAtS3RvalxaN96zRrzWHthFi25N
 gRcGylWWL8vC257jnDajrGCfSVckN9UDgG8NNuvejJUFibbEm0WxMx5g+oEKFJRIH+j+2YqcP
 5xJj55n6epFIQmOCSgPKJY2Y0I2yIIazpMKvSRMzafGIEjROLeHHe28dw5i4UkwhVXSTuFl8L
 CS8X8tGeR0379mDqNM3/R1oMFKGA3JbyC4bfquDSY12dE0Uj5eoDBf+z+ZkJ6r0Dd3NfbfDQT
 5beTjO2kfoqGPCnJuEFIo0yoO6KEC4bX6/iuMfAJqYOJULwA4FRkL2AY1rAIJIM4ZgrGDW7hy
 rd/nN2LLnQu1grTvUnkwEQyEqtWHWfAHkJ8u9T8Lhxza5FZe9MpF0C7i503rmI8UuzpxdmYEM
 4ddCwY02xJ+q5ieJEIOXdB223saFD26KbRlB3NbHdelzjCpNWBH+/xzryKFo3ZG5c24pOz8SI
 6ctMYWNxUQoOd8Ttqo0ka58vugJ3RGycf6XA8nrVJiHrXXrdprS+p6UCjSUQrv1QzaelH2pBu
 SmGG9umZhcxtzvi0YifIbpQu2FQ=
Precedence: bulk

On 7/27/23 19:03, Yuanjun Gong wrote:
> in mmphw_probe(), check the return value of clk_prepare_enable()
> and return the error code if clk_prepare_enable() returns an
> unexpected value.
>
> Fixes: d63028c38905 ("video: mmp display controller support")
> Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163.com>

applied.
Thanks!
Helge

> ---
>   drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c b/drivers/video/fbdev=
/mmp/hw/mmp_ctrl.c
> index 51fbf02a0343..76b50b6c98ad 100644
> --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> @@ -519,7 +519,9 @@ static int mmphw_probe(struct platform_device *pdev)
>   			      "unable to get clk %s\n", mi->clk_name);
>   		goto failed;
>   	}
> -	clk_prepare_enable(ctrl->clk);
> +	ret =3D clk_prepare_enable(ctrl->clk);
> +	if (ret)
> +		goto failed;
>
>   	/* init global regs */
>   	ctrl_set_default(ctrl);