Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a29cf254-80c9-50e6-c723-71a8f03e6e35@pengutronix.de>
Date:   Mon, 31 Jul 2023 14:42:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply
Content-Language: en-US
To:     =?UTF-8?Q?Guido_G=c3=bcnther?= <guido.gunther@puri.sm>,
        David Heidelberg <david@ixit.cz>
Cc:     devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Fabio Estevam <festevam@gmail.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Peng Fan <peng.fan@nxp.com>, linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        linux-arm-kernel@lists.infradead.org, kernel@puri.sm
References: <20230730121047.43115-1-david@ixit.cz>
 <ZMebuXJKFMpjCuul@qwark.sigxcpu.org>
From:   Ahmad Fatoum <a.fatoum@pengutronix.de>
In-Reply-To: <ZMebuXJKFMpjCuul@qwark.sigxcpu.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hello David,
Hello Guido,

On 31.07.23 13:32, Guido Günther wrote:
> Hi,
> On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote:
>> Resolves following warning:
>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
>> 	from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#
>>
>> Cc: kernel@puri.sm
>> Cc: Guido Günther <agx@sigxcpu.org>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>  arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>> index b3549eae6278..a8b5da3ca08f 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>> @@ -1031,7 +1031,7 @@ &usdhc2 {
>>  	pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
>>  	bus-width = <4>;
>>  	vmmc-supply = <&reg_usdhc2_vmmc>;
>> -	power-supply = <&wifi_pwr_en>;
>> +	vqmmc-supply = <&wifi_pwr_en>;
> 
> From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE`
> so I don't think vqmmc is correct here. I wonder if there's a better way
> to model that in DT? Any suggestions would be welcome.

I think mmc-pwrseq is what you are after.

Cheers,
Ahmad

> 
> Cheers,
>  -- Guido
> 
>>  	broken-cd;
>>  	disable-wp;
>>  	cap-sdio-irq;
>> -- 
>> 2.40.1
>>
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |