Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76b3c602-ab9d-7368-2c83-f5a8f4f0f330@gmx.de>
Date:   Mon, 31 Jul 2023 14:37:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] fbdev/amifb: Replace zero-length arrays with
 DECLARE_FLEX_ARRAY() helper
Content-Language: en-US
To:     Atul Raut <rauji.raut@gmail.com>
Cc:     linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        linux-kernel-mentees@lists.linuxfoundation.org
References: <20230731021808.24997-1-rauji.raut@gmail.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20230731021808.24997-1-rauji.raut@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:7h3/yL6t/qk=;+J46rFQhxCOAdSskQUGZ+gnmBGC
 dVBvHoqWyyTn0IjIia/X5UrDziZjViqhLXA4ZJbaNdral0IGCd+HcuKsPq1XjRC66wKjbsaFq
 vLCCZwzJzPYV8FWVzkzjop8YGbWZyZCYqha599kevSG0g9xX30OTyK0TrrVXkqmPSSuflkcLl
 uBVSBDr+B4i8VIsUbptEITjyFoj0oPhe9Jq3NEA0Upj/tI4CvE0FU6xBBEae7dp2fQZHi+PS3
 /G/bgTMYAp8CpxVzogZG27o0ETM/doRFn8/FhCUjRovSQpXqoSeXUZ4VuVzFoO8QWUCo+sQVM
 e1GudTgpHngilR5ayD6hKEZMnuGfWLMjqwsD3QrW5Jg/kAOnlr7E38k4OJhD++iJXpc2Hc+2W
 EnxvLp0riV+2uPxd5SOR1L2dXo0mA6E7MMUPTGGfHJAWPABHgKUqExzGv3YGeN9yN2iMyW2Wq
 qG/HZ9R44CEdMG1DkdiM8B0fTI7k+OPukX8hxfCFEya8Pl6d3WUKOWvfpPmfgwcssQhqrqs2b
 aUzS5GI0hutNwiBXf/Gs2jyCYhvGo+LXtO+dVglnpHEwgcluA2xuVC4LG6tqbF0GEgoaQgryZ
 Qufb79yjzLR+6SDp3uHLtQZxv4xknJVmI97eR6tvOugRadzcDOClulFaXPsALJxML2+3MF1YB
 iPLJbtU0C83K9A+9EGp+VgC1tKSAuR0mo/+Xpq4ZPq4V8bKdYrKDs2eGjzIxQw2RUPwbNqkkI
 TBqv7sXGuoNQv3JDHYYt+jEpOax0cUkSkho9KsgG2vWo9qkzAr72aMmosLSSBzGpbSUZZy+pH
 5I/lAO6cL1c1koENnUoqfELQi8PxZF5v3rcAsfpspeP1/uL/6EzDZ2w+ouQxQ/wHrh2BTSvdI
 wlcfRWOHj87hQedfAEeXnp3M9e+fWLXiwJiiMpX/3deBv4cTfJaa10+twJoIganjCj7gTRL2F
 UuSifw==
Precedence: bulk

On 7/31/23 04:18, Atul Raut wrote:
> Replacing zero-length arrays with C99 flexible-array members
> because they are deprecated. Use the new DECLARE_FLEX_ARRAY()
> auxiliary macro instead of defining a zero-length array.
>
> This fixes warnings such as:
> ./drivers/video/fbdev/amifb.c:690:6-10: WARNING use flexible-array membe=
r instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#=
zero-length-and-one-element-arrays)
>
> Signed-off-by: Atul Raut <rauji.raut@gmail.com>

applied.
Thanks!
Helge

> ---
>   drivers/video/fbdev/amifb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/amifb.c b/drivers/video/fbdev/amifb.c
> index d88265dbebf4..f216b2c702a1 100644
> --- a/drivers/video/fbdev/amifb.c
> +++ b/drivers/video/fbdev/amifb.c
> @@ -687,7 +687,7 @@ struct fb_var_cursorinfo {
>   	__u16 height;
>   	__u16 xspot;
>   	__u16 yspot;
> -	__u8 data[1];			/* field with [height][width]        */
> +	DECLARE_FLEX_ARRAY(__u8, data);	/* field with [height][width]        *=
/
>   };
>
>   struct fb_cursorstate {