Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4470357rwb; Mon, 31 Jul 2023 07:23:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlEPMW5Czy9YypHM83Ky5mMfygdsEaY8q2hrggjbixyF/dN49PiBa7ZKhGRUTsG/hsKB6ncL X-Received: by 2002:a17:902:f683:b0:1bb:1523:b2d7 with SMTP id l3-20020a170902f68300b001bb1523b2d7mr10569464plg.14.1690813386547; Mon, 31 Jul 2023 07:23:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690813386; cv=none; d=google.com; s=arc-20160816; b=yKVkGTHxV0y5ec2zXNVmIb4vBBUTnJ9l5SP2xOIiGbnOH7zjeCETfSkpTNKQye7rB2 HZSSCP5uYcp7qMAwHicJa92EFoNNWLiewMkVEXyC8CXCnsTHBJGWlBS6VKq6PrNuqoNy yi+zE57uPl0ib3H7QRwxDY0xIG19k8cwmHRV52dcl8VpJjxoKkw/p9wjox3FIUZcuWD/ fPlvE6bxcCGEESQ1+SMChVOSKtwiHuuaCFONz0XFv2T4nhUwskWhh9VjMn4scfHdWQc5 w+/LzPuwsnKjXEcqV/X8yIXW1TZ31XDGQ8pzwtENNRHNei1EWVkah8Bzl2lQNnYJdLWe mAlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=RFZUc4YGd9y/kzyYMSYgqOOrh8lwopicVxQoutR+c10=; fh=DVelK2yEnauoQP/N3GrI40H9xaJkDJcjyQRrMsedm34=; b=qgQH0zoXQAnRVdMFZzP7ZLYto0BhaBEmaeSu3f47+cfYGAJn+gBDuje4SgLSxk6783 DCtJauvtTwF0d408vW3mgJ3z4nayJFKqWYOEbNajsdyDTSN4cs5qFbe+kQjLv5I08AYb V8GMLmWujJfEgT7dOk6ejWXtbYTDDEDFL4voc9eTIk4MhRtC5qO+sIKSBC3b4145kxE5 PWxCG5yl0vOv8VxfMSAkmTdp/vmguJgU34RSuklLNg3k39K9C2gHnOOgFRJ9teRe2YRh tGJFVscAAY1q+AAnKBJS5nAmy4W86yHubomE7kyp0n7yYp6SU68WzNzEdqKYvLtbzWM+ s8Yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ix22-20020a170902f81600b001b9d203659dsi4203366plb.14.2023.07.31.07.22.45; Mon, 31 Jul 2023 07:23:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230486AbjGaN5A (ORCPT + 99 others); Mon, 31 Jul 2023 09:57:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232818AbjGaNzv (ORCPT ); Mon, 31 Jul 2023 09:55:51 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 204CD2680; Mon, 31 Jul 2023 06:53:29 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id D7B2367373; Mon, 31 Jul 2023 15:53:25 +0200 (CEST) Date: Mon, 31 Jul 2023 15:53:25 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , Gao Xiang , syzbot , chao@kernel.org, huyue2@coolpad.com, jack@suse.cz, jefflexu@linux.alibaba.com, linkinjeon@kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, sj1557.seo@samsung.com, syzkaller-bugs@googlegroups.com, xiang@kernel.org Subject: Re: [syzbot] [erofs?] [fat?] WARNING in erofs_kill_sb Message-ID: <20230731135325.GB6016@lst.de> References: <000000000000f43cab0601c3c902@google.com> <20230731093744.GA1788@lst.de> <9b57e5f7-62b6-fd65-4dac-a71c9dc08abc@linux.alibaba.com> <20230731111622.GA3511@lst.de> <20230731-augapfel-penibel-196c3453f809@brauner> <20230731-unbeirrbar-kochen-761422d57ffc@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230731-unbeirrbar-kochen-761422d57ffc@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 31, 2023 at 03:22:28PM +0200, Christian Brauner wrote: > Uh, no. I vasty underestimated how sensitive that change would be. Plus > arguably ->kill_sb() really should be callable once the sb is visible. > > Are you looking into this or do you want me to, Christoph? I'm planning to look into it, but I won't get to it before tomorrow.