Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230719063558.3131045-1-maobibo@loongson.cn> <f19c393b-8c2e-e3aa-988a-88a423b59b99@loongson.cn>
 <86h6prt2vx.wl-maz@kernel.org> <5a891302-9657-ec95-4438-bc19d0efb556@loongson.cn>
In-Reply-To: <5a891302-9657-ec95-4438-bc19d0efb556@loongson.cn>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Mon, 31 Jul 2023 22:16:37 +0800
Message-ID: <CAAhV-H4wJiw43h2GfSey5CYUsmqX9SE+CAPSPUng9EQFMOcRdw@mail.gmail.com>
Subject: Re: [PATCH v5 0/2] irqchip/loongson-eiointc: Add simple irq routing method
To:     bibo mao <maobibo@loongson.cn>
Cc:     Marc Zyngier <maz@kernel.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Jianmin Lv <lvjianmin@loongson.cn>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= <philmd@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jul 26, 2023 at 6:08=E2=80=AFPM bibo mao <maobibo@loongson.cn> wrot=
e:
>
>
>
> =E5=9C=A8 2023/7/26 17:53, Marc Zyngier =E5=86=99=E9=81=93:
> > On Wed, 26 Jul 2023 10:45:51 +0100,
> > bibo mao <maobibo@loongson.cn> wrote:
> >>
> >> slight ping :)
> >
> > Given that you have sent this series 5 times in two weeks, I don't
> > think anyone is in a hurry to review it again. Just give it time.
> Ok, I see.
> Sorry to bring out some noise and thanks for your response.
1, If we really need a "virtual eiointc" variant, please document it
in Documentation/loongarch/irq-chip-model.rst and
Documentation/translations/zh_CN/loongarch/irq-chip-model.rst.
2, Then, I think it is better to only modify the type of 'index' in
Patch-1, and move the 'if (index < 0) ...' modifications to Patch-2.
Because all "virtual eiointc" code should be in a single patch.


Huacai
>
> Regards
> Bibo Mao
> >
> > Thanks,
> >
> >       M.
> >
> >>
> >> =E5=9C=A8 2023/7/19 14:35, Bibo Mao =E5=86=99=E9=81=93:
> >>> Fix return value checking of eiointc_index where int type
> >>> is converted uint32_t and check smaller than 0.
> >>>
> >>> Add simple irq route support on system with only one eiointc node,
> >>> rather than use anysend method.
> >>>
> >>> ---
> >>> Changes in v5:
> >>>   Modify typo issue.
> >>>
> >>> Changes in v4:
> >>>   Modify some spell checking problems.
> >>>   Add Fixes tag.
> >>>
> >>> Changes in v3:
> >>>   Modify some spell checking problems.
> >>>
> >>> Changes in v2:
> >>>   Use the simple irq routing on embeded board like 2K0500 and 2K2000
> >>> board, since there is only one eio node.
> >>>
> >>> ---
> >>> Bibo Mao (2):
> >>>   irqchip/loongson-eiointc: Fix return value checking of eiointc_inde=
x
> >>>   irqchip/loongson-eiointc: Simplify irq routing on some platforms
> >>>
> >>>  drivers/irqchip/irq-loongson-eiointc.c | 93 +++++++++++++++++++++++-=
--
> >>>  1 file changed, 82 insertions(+), 11 deletions(-)
> >>>
> >>
> >>
> >
>