Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4562320rwb; Mon, 31 Jul 2023 08:40:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlE0KL0ljgYqAuC6uZvhJpt4rD6JgfWoh9C3U5WhPYxJUHKxrfOfuMkzSw8ONy7kKANWS7S/ X-Received: by 2002:a05:6a20:2455:b0:133:6696:1db with SMTP id t21-20020a056a20245500b00133669601dbmr12011209pzc.29.1690818056625; Mon, 31 Jul 2023 08:40:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690818056; cv=none; d=google.com; s=arc-20160816; b=XIZC9m5oSB1Y27i+Rqcuxwmrk6hvljgY2xgCt+xg/ALZ/yUMnrHLkyux7zm3NTlcP5 D00l4PT91lGUeyF63dV9che/1p6Ot58hOPLuEunSVLldW8/SNSSMIm54I3GLNcwAEKUI lAIQM9kby/1r/KAwfIZX/VgL05pXUnqm7v1T3OPBgi0MKMO1EVDztsYoQyQjNooMIs8r Rj5OXkv4AtyhDyR12ctithXGsqUPthTpRz0SUWjdWRALfXtYxxIxmNKTLXZiYicnkWk7 GjChJewpQXOnyzmb73+q9dtjFHXUpPw/KinhDZNJs2p5p0tki/VZ8Q/bW0cjZ3/nls4s pqpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=EjKKDKTgLyOvGv5sy2GJLzprFjeTslG0HAwYAbAMPbA=; fh=S8mxYXkdc0aaRlMvrbT+bH5acHl6Achjtd7kXkEXoSM=; b=cFSuqgpcZnwz2xrjWdOa0C7ZX7ZiSQfY0Q3+fzV3WytPdfxB9VUeLd75tszUEoYYTx 6rvm9qennp0pm4GNIhhEdXQcLeRpTyHZFUPnw/FZsZ/CrMJoRqpqm+2Kw2V21wot5JUu evU+mL8ITuf1gQnecmtwja362fP6DwRu0Dwgt9RtAor8b34N9QLZZH8o9+UqyZYpuDJc 4yMAjIHeT7j0kD8dzYtjii1X91Fks7iVxlVKin58eskePrVjuFJ2WkRV/8L3QdM0qMe8 v8EycvzPcP81NevrMaTk9Gil14nmrn48fe7Bg2T1a0H/RpNCpHQfgYVv6yOXwbn8C5Jo T47g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gentoo.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 137-20020a63018f000000b0055c8d14df3asi7131797pgb.799.2023.07.31.08.40.43; Mon, 31 Jul 2023 08:40:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gentoo.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232786AbjGaPIt (ORCPT + 99 others); Mon, 31 Jul 2023 11:08:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230133AbjGaPIs (ORCPT ); Mon, 31 Jul 2023 11:08:48 -0400 Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECF4910EB; Mon, 31 Jul 2023 08:08:46 -0700 (PDT) Message-ID: Date: Mon, 31 Jul 2023 11:08:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH 3/5] rtc: ds1685: use EXPORT_SYMBOL_GPL for ds1685_rtc_poweroff Content-Language: en-US To: Christoph Hellwig , Luis Chamberlain , Greg Kroah-Hartman , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Ulf Hansson , Yangbo Lu Cc: Daniel Vetter , linux-arm-kernel@lists.infradead.org, open list , linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org References: <20230731083806.453036-1-hch@lst.de> <20230731083806.453036-4-hch@lst.de> From: Joshua Kinard In-Reply-To: <20230731083806.453036-4-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/31/2023 04:38, Christoph Hellwig wrote: > ds1685_rtc_poweroff is only used externally via symbol_get, which was > only ever intended for very internal symbols like this one. Use > EXPORT_SYMBOL_GPL for it so that symbol_get can enforce only being used > on EXPORT_SYMBOL_GPL symbols. > > Signed-off-by: Christoph Hellwig > --- > drivers/rtc/rtc-ds1685.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c > index 0f707be0eb87fa..04dbf35cf3b706 100644 > --- a/drivers/rtc/rtc-ds1685.c > +++ b/drivers/rtc/rtc-ds1685.c > @@ -1432,7 +1432,7 @@ ds1685_rtc_poweroff(struct platform_device *pdev) > unreachable(); > } > } > -EXPORT_SYMBOL(ds1685_rtc_poweroff); > +EXPORT_SYMBOL_GPL(ds1685_rtc_poweroff); > /* ----------------------------------------------------------------------- */ > > Acked-by: Joshua Kinard