Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6dbb6b3f-1a7d-f378-ac46-e045b165f33c@oracle.com>
Date:   Mon, 31 Jul 2023 14:16:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v5 1/5] perf metric: Event "Compat" value supports
 matching multiple identifiers
Content-Language: en-US
To:     Jing Zhang <renyu.zj@linux.alibaba.com>,
        Ian Rogers <irogers@google.com>
Cc:     Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org,
        Zhuo Song <zhuo.song@linux.alibaba.com>,
        Shuai Xue <xueshuai@linux.alibaba.com>
References: <1690525040-77423-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1690525040-77423-2-git-send-email-renyu.zj@linux.alibaba.com>
 <268b3891-be4b-5f63-eff3-7b6d83e906e9@oracle.com>
 <0801b73c-6649-8c54-8dca-276efc2a4967@linux.alibaba.com>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <0801b73c-6649-8c54-8dca-276efc2a4967@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1piZUtHeHRjRkE4emtTOXN5RVhYOTFOckJUSHYrSmduYTZoYnpiRTdLOG1Y?=
 =?utf-8?B?RWRidUt5UG0xeXcyTnYzSS9aY2FpajlhbkppelV5dEVuWjVIb1AzSnVyV0Ri?=
 =?utf-8?B?U3pSL3d3MXhyclByL29XS1I3ZW4vcjZxcU9TMUVzb0dMZndiV2hpbHE0WEpR?=
 =?utf-8?B?eEM5YzBTdzlpNHRpeUZMNW1WRjN2NkxWdlJiaU85TWhnRyt3eEl0STduMmlC?=
 =?utf-8?B?M1lsZ0pGeTNyd3VWODFJQUNJTzQ2eDAwMllOdFRnbjRQbyt0TXppR0NQUkR0?=
 =?utf-8?B?TzVqV1V0T3J0M0xwRkJIWXBGMTFhRkpqTytESHgxOXJCbHgreGFOcTF2OVFw?=
 =?utf-8?B?V3FMNW1oWEorRW9FQlU0RHVKaFY4eTBDaEE4N2tqNGJoTUlPVnlQMFJHTm5x?=
 =?utf-8?B?SktJYzY4SmltTXdFU1RsdWFORWxUUFVjdDlHeWdHdkxueU1TcmFjWnRMaVB2?=
 =?utf-8?B?VFVLTCtSakpkcEliOFVmSWJIWDJSUCtZdEJpWUVoRjZhL1g2TEpreW44ZG0r?=
 =?utf-8?B?MGpuZDdzanBRTmdNMWR3WkRxdlJrQU16b1hIVkVGRHluMFdkblQ1VDdLVGoz?=
 =?utf-8?B?Z2IzcGFSWFhjUExodGwrZGVUcXQ1eVNmdS9zL2Nvdm5WakJ4Tm4zK0hPOEp3?=
 =?utf-8?B?c0RGT2pXVDdHRlRnVVJKVjkzd0daWURVOU8xQkNOcG5ramg0YlQ4K0RlWFBT?=
 =?utf-8?B?cGZNTzJYTUJMREtGTDJ5ZzduUHdVY1JIblJndFM2VFhLRlVGQWlNc0M5bXVW?=
 =?utf-8?B?QzBzUGZjT2lpK3lOdEhGM3Fyb0IvaHpYS2dGVHltK3FSTlkwOThNY01JcU9i?=
 =?utf-8?B?ZUZmSTNPRFFQTUdHUXFrS0wrNlJkeEZKcGM0NXl6S09pSnRJNzZvMU1ZRHh3?=
 =?utf-8?B?R2dMT2c1UXc1b2Z6TGhGYlVQVTVSRFY0OUNackN6aHB4SHA2RERaSDZQMTAz?=
 =?utf-8?B?UTQrMVhRWmtPMTRSSkdtZlh0Z1dob09yZGZQZVgxTDVsUVAwZ3JINSt3b0R1?=
 =?utf-8?B?NGJkNlNONExMVlZ4eVNFV3N5YlgyMTB5eGI0anA0THNwRU0zalY2cU03TnpB?=
 =?utf-8?B?N1JQWFBpaUIxdEFkcENJeHoyUDNjUEZENkpTb0NZMDdsZ1AxYjNQbUoxRXp4?=
 =?utf-8?B?N2ZCQUtMNmZsN2RLa1o0YmJLN1ZJSkU5Nk5uUHF1V21XOUNxUGFMMXJnR2I1?=
 =?utf-8?B?Q1FDY08rVEJQWnVoOEtVYTZINVdCZndGc1dLOXo5VE0wMENBa0tNVTNwc09q?=
 =?utf-8?B?aXczNnRCQ0lIZHVWTHlSZEx5RXdGZ1NyVXlCV3MwWUtieFdDaEdGd0lDSUdt?=
 =?utf-8?B?M0djdUlTOERmWTN3RzRDVktac3FFalhwV1FwTndMenBHa3cwVWsxUjdMMExM?=
 =?utf-8?B?MHhtWWN5aG1nNmJ6R0ZMdUNVVWkwNjdqUnFLeVhMZFc2YnJUU3Y2dzdLRDZi?=
 =?utf-8?B?K0hUWDA2M3VhL2lvZXRqeEhxbmZxMFNHZHNCZmZjY3NuTWZ6Z0hpZjlPbW5r?=
 =?utf-8?B?ODg0VGZ1Qm9NdDFjN2VpNHJFa2NEM3JQZWpoTlg0YkRpQmN4blFSbVNOR2dp?=
 =?utf-8?B?ZncyQVA4bnNBaVJTQ0FSTWV6bU4vSUdXTFF3UWltaXo0RC9LRWJDOWlCS3NP?=
 =?utf-8?B?VlVoZ2wzVzBrcERoQXl3VlE4UUxuWmhNeUxGNFRXYUtOR1VBaUJqOTM4bEVS?=
 =?utf-8?B?VTBGVWpkeUV6d2FuSThnMlVSZThRbHRpRWxTanF2Qkg2bHNTV0xtSGM4WUJI?=
 =?utf-8?B?YUx2YzhSNUpRbGhwZUJIdnBCbzRTOW1kdE5wdis5K28rOHltdDErd3c1RTk4?=
 =?utf-8?B?a1RWdi9XWExvNmtjbkxQakdwMm5weHBaR2svR3hHMFoydGhGWkJYVGd2amd2?=
 =?utf-8?B?dXE3cEoxK0tLRXhrMWFWRVFkTjdjTC9tLzkxdks5dS95QXBiWGhrbHlwNXNP?=
 =?utf-8?B?ckNjZDhUU3ZnTjF3ZjFsYzUxTkJZLy9OMGlZc3pXWEhVd21iREdPbVZDY2lP?=
 =?utf-8?B?WEJBNWVTdEk5cXp3UlBWZmF4eURULzIzTHhvKzZjYjNvNU5wWnV2OWlpbVRF?=
 =?utf-8?B?T0QvWVVzZTZYcE1jeWY3MStuU0w4UGsvaE8wcHg5SC9RYTBQOGp2c0dQZ2Y4?=
 =?utf-8?Q?P3OBie9V3vts8N+QHBF/aPD83?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?MW5za3Jxb3lLVHhweUkydlk5L3N2MDJpTjRUdURPeHRkc1FrTUFFdWxXL3Fy?=
 =?utf-8?B?YW9JK1dBUEdUVitwNzlaSHpDUDBXRllHUHc1dWx2UVhyQkpzaXh3MkhNenNO?=
 =?utf-8?B?K1luUDNydzJTVlUwZVhWNzBnMjVyMlZtK0EvZjdVUkx3TDk1WjJVNmdHQWVs?=
 =?utf-8?B?ZFdlUTJmL1BERnc3cHRjVUk1ZGV3Vkg5Nk5NQWlXeXV0M29BbmZNSE42VlAr?=
 =?utf-8?B?YndEN0MxTUZNTVliKzBFbjJlMGx1c2lIR0VlNmpKd1RKVzJyeUU5TnE3TjRO?=
 =?utf-8?B?eTlyd1Y0NjF3YktoWXZQSlR5RHpOY0RWQmdpVnNkSlhqWU4rRDNnNTVPMzZz?=
 =?utf-8?B?cW9ML01MdUdNYllPbTRQZ21taEN6WVRCY1o1ZVp0U2lJd25vSmlUMVg3ZGE4?=
 =?utf-8?B?YmVXOTYwVEhoMUo5cU5MUzlGODVTMzlJTUJvYkRKM21jTFRhUFRVanlFbDRO?=
 =?utf-8?B?bDdDOWs3U1UrNTBmU0JJbHUyNUNxNStTanFOQU9jSTVha1o2bXd2azloVXVX?=
 =?utf-8?B?cEh5VXFKZ1daSWwwSi9WUTlaaXA2NFlLWFFMdE1vSmlxMnB5UGd5b2U1Rkwx?=
 =?utf-8?B?S3NnSjhOdmIvclB2NVJEM2ZueEc0TnJud1NGdG4wWFNRbGx2ZWRXVHFhYkxU?=
 =?utf-8?B?UnpJSTQrMmV3eEpsZFFrQ25BSFJmMGNOdVhWYitDWDN2RzM0RWtKZ0QwdkJ1?=
 =?utf-8?B?WUQvd09naWUxcWJWTVNRL0orREVxWnhtd1oxc3RTdlVPRkQrY0RJakdmb2NN?=
 =?utf-8?B?MHY1OCswRExhN0dORUsrVCs4MG84RjZrWnM0TGNSM2RabGNoKzRlWlpuODFo?=
 =?utf-8?B?UkI3c0FOdzVuYmFtMmZrZ3h0dC9qRmUrNHhKQXROUDhCbmVlbHFjYzF5RHNF?=
 =?utf-8?B?a1gwaWlMMVg2U05iSGlEZTc4Y0ZhM3NYUG5rR1p5UU95NXdISFFidXErb2tk?=
 =?utf-8?B?NlF0UkgvRTRDYmxkWUxydHczbnVWZTBUbEE0WEZuK3FiVFlrWFVYNG81MXJo?=
 =?utf-8?B?Q0JTRkhiT0RYM0VEd2I2eXY3SjBDZ1lJZ2lVWDFvaVlYZFpBRmRzTFgrVEVi?=
 =?utf-8?B?TzFxVWtraFRreU9RZ0NCWWtCemVUNDlZVHRraGlSM3BDTkh3QmszRThNT05D?=
 =?utf-8?B?RW51Yll0NmdITnR2M3JzVUZROHpFYmtaUit6MGJvN09mK1MwQjFmVWdvcHRm?=
 =?utf-8?B?YU1GT2lsWmY2YXpFSnM5dEljVlJLNC82VFdWVEhRRkhXK2krSEpoM1gvTk4z?=
 =?utf-8?B?dEpzVUJZNEdKUHc4eW9kS3ZtZ2dVSk9IZmxBOGhDcitsdUcwWHN4dkRPK2h3?=
 =?utf-8?Q?D5S8l65q33kO8B6u0t3PmQuBgqRql7Xm3b?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8523ba55-0ebd-4e7a-702e-08db91c8602e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 13:16:39.8526
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TRv1juL+1DFAAl2sWcVimU1GscWDzAWOyLrAGvLZgQjKjAlKKolbqW80YL9A+Q1lUl72yRpZ1iuCfZAsmoXZeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB5915
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-31_06,2023-07-31_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0
 mlxlogscore=999 malwarescore=0 adultscore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307310119
X-Proofpoint-ORIG-GUID: aQT-zrSPedoAuSimfWDsMhMV-0ec7RBE
X-Proofpoint-GUID: aQT-zrSPedoAuSimfWDsMhMV-0ec7RBE
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 31/07/2023 11:59, Jing Zhang wrote:
>> why not use a comma-separated list? that is more common
>>
> Hi John,
> 
> I use a semicolon instead of a comma because I want to distinguish it from the function
> of the comma in "Unit" and avoid confusion between the use of commas in "Unit" and "Compat".
> Because in “Compat”, the semicolon means "or". So I think semicolons are more appropriate,
> what do you think?
> 

I suppose semicolon is ok in this case.

Thanks,
John