Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4616804rwb; Mon, 31 Jul 2023 09:27:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlERwuIGhplStCZgUM5HaXIXWp6266d1Myc7AZVl1S7Rx+mFk0XgDC7S1zG45s04IU78f55m X-Received: by 2002:a05:6a00:44c9:b0:687:2cba:67ad with SMTP id cv9-20020a056a0044c900b006872cba67admr6566375pfb.2.1690820845801; Mon, 31 Jul 2023 09:27:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690820845; cv=none; d=google.com; s=arc-20160816; b=oa2V7XfFD8Pmx1AQOr9oSOPRKL5KwRMJSlCuWfUq8jXQjce0Mwcw+IZYNawUVUhymY i4ompKVn+FYRnSHXzMrJBDisPSPds462jNjT4kDdnvO6yAsoP9kPBq3dwRomPqUMGMyR nfzr1v48l8yhLyYw27Fu4dOUTZABsML6E/5+dL8eibmqocy3bCIb9QWfMfZyzOzxV4US nb7Qx2ye8fcYbSAkWpgUInsDNr/JBZF1+0sGtLJQEGL0r12ChSbtkWZUTFiCaVXvV7fc XiENd5nHm43TgdD5rkmvV2kQhZL7MD/YKKP4/ruNpCv2oGOzH+EXou0Ao3BL2oPYEKKE RiQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OAlHFh23Ai3rWydq2AQncjIomKYZrH2FnJx20P7QKlA=; fh=Y/ZBMWPN6PVqE0PdVxcMTtX8ajjPZEGD24oLfOg78Xk=; b=a2r6lbIlqG5UKfpLIp6EQJKXUH4zcQYdvXu+LxD5d2kaVHHZaBVUTe8DtonRwWVKa7 qfotxFvvwxa4f8QGLYyruaBGqOe48HYCM3m+Py0GakQbz4XGd+mDENizKofSJy5ror/H EG1i37RnUW+y8b428zpHou2URTFOpqLqYXYafeoZRhwf3tUqpJCJAog3Q8iDjD6hvmF8 w1DN6P23tpdDF48TlM6o16dawJ9914/NNvz4z/AiyoU/oPHgDb/fsW4D5OwFAN1OdqtH s3aKplYIshSom595cGvmDBKBp4lU7mgUGbLWKFi1fFQIdi56/2rmywIAkRPij7q7gK6U ElSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OP8BfhoE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bx20-20020a056a00429400b006874c4a7b6asi440416pfb.29.2023.07.31.09.27.13; Mon, 31 Jul 2023 09:27:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OP8BfhoE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbjGaP6r (ORCPT + 99 others); Mon, 31 Jul 2023 11:58:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229896AbjGaP6q (ORCPT ); Mon, 31 Jul 2023 11:58:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9342511B; Mon, 31 Jul 2023 08:58:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 27E19611FC; Mon, 31 Jul 2023 15:58:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 075BBC433C7; Mon, 31 Jul 2023 15:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690819124; bh=R1G04hta+saztdfdrFiAoSHpGKl0V0AP6qVL7ELtNro=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OP8BfhoEG5YnNRPnRTDoXNpryf59JCNmvEbP/jVRlE+we9YGAZNCDAB/FslU1Yy9s FhD1ATE37t/1vfHy/Bg9Ez9+mB8wrrATlEH1pAk5odqQNyQrZxv2PwBPLvrVZGoMy7 Tncwhoi0jOhtm+VDWY/NJxve7zq5s+CmRUQ8Wmmg= Date: Mon, 31 Jul 2023 17:58:41 +0200 From: Greg KH To: Hugo Villeneuve Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, isaac.true@canonical.com, jesse.sung@canonical.com, l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Hugo Villeneuve , stable@vger.kernel.org, Andy Shevchenko , Lech Perczak Subject: Re: [PATCH v9 06/10] serial: sc16is7xx: fix regression with GPIO configuration Message-ID: <2023073105-elevation-canister-2777@gregkh> References: <20230725142343.1724130-1-hugo@hugovil.com> <20230725142343.1724130-7-hugo@hugovil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725142343.1724130-7-hugo@hugovil.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 25, 2023 at 10:23:38AM -0400, Hugo Villeneuve wrote: > From: Hugo Villeneuve > > Commit 679875d1d880 ("sc16is7xx: Separate GPIOs from modem control lines") > and commit 21144bab4f11 ("sc16is7xx: Handle modem status lines") > changed the function of the GPIOs pins to act as modem control > lines without any possibility of selecting GPIO function. > > As a consequence, applications that depends on GPIO lines configured > by default as GPIO pins no longer work as expected. > > Also, the change to select modem control lines function was done only > for channel A of dual UART variants (752/762). This was not documented > in the log message. > > Allow to specify GPIO or modem control line function in the device > tree, and for each of the ports (A or B). > > Do so by using the new device-tree property named > "nxp,modem-control-line-ports" (property added in separate patch). > > When registering GPIO chip controller, mask-out GPIO pins declared as > modem control lines according to this new DT property. > > Fixes: 679875d1d880 ("sc16is7xx: Separate GPIOs from modem control lines") > Fixes: 21144bab4f11 ("sc16is7xx: Handle modem status lines") > Cc: # 6.1.x: 95982fad dt-bindings: sc16is7xx: Add property to change GPIO function > Cc: # 6.1.x: 1584d572 serial: sc16is7xx: refactor GPIO controller registration > Cc: # 6.1.x: ac2caa5a serial: sc16is7xx: remove obsolete out_thread label > Cc: # 6.1.x: d90961ad serial: sc16is7xx: mark IOCONTROL register as volatile > Cc: # 6.1.x: 6dae3bad serial: sc16is7xx: fix broken port 0 uart init Where are these git commit ids from? I don't see them in Linus's tree, how are they supposed to be picked up by the stable developers if they are not valid ones? confused, greg k-h