Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Peter Zijlstra <peterz@infradead.org>, axboe@kernel.dk
Cc:     linux-kernel@vger.kernel.org, peterz@infradead.org,
        mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net,
        andrealmeid@igalia.com, Andrew Morton <akpm@linux-foundation.org>,
        urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com,
        Arnd Bergmann <arnd@arndb.de>, linux-api@vger.kernel.org,
        linux-mm@kvack.org, linux-arch@vger.kernel.org,
        malteskarupke@web.de
Subject: Re: [PATCH v1 06/14] futex: Add sys_futex_wait()
In-Reply-To: <20230721105744.090372309@infradead.org>
References: <20230721102237.268073801@infradead.org>
 <20230721105744.090372309@infradead.org>
Date:   Mon, 31 Jul 2023 18:35:38 +0200
Message-ID: <878rawnin9.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote:
> +int futex_wait(u32 __user *uaddr, unsigned int flags, u32 val, ktime_t *abs_time, u32 bitset)
> +{
> +	struct hrtimer_sleeper timeout, *to;
> +	struct restart_block *restart;
> +	int ret;
> +
> +	to = futex_setup_timer(abs_time, &timeout, flags,
> +			       current->timer_slack_ns);
> +
> +	ret = __futex_wait(uaddr, flags, val, to, bitset);
> +	if (!to)
> +		return ret;

Can you please put an empty new line and a comment between the __futex_wait()
and the if (!to) check? The original code was less obfuscated.

Other than that: Reviewed-by: Thomas Gleixner <tglx@linutronix.de>